linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6qdl-wandboard: Move FEC reset pin into the FEC pin group
@ 2014-04-23 20:13 Fabio Estevam
  2014-04-29  5:24 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2014-04-23 20:13 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@freescale.com>

Remove GPIO3_29 (FEC PHY reset pin) from the hog group and place it into
pinctrl_enet pin group instead.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
index 5c6f10c..79498ca 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
@@ -104,7 +104,6 @@
 				MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x80000000 /* WL_REG_ON */
 				MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000 /* WL_HOST_WAKE */
 				MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* WL_WAKE */
-				MX6QDL_PAD_EIM_D29__GPIO3_IO29   0x80000000
 			>;
 		};
 
@@ -136,6 +135,7 @@
 				MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL	0x1b0b0
 				MX6QDL_PAD_GPIO_16__ENET_REF_CLK	0x4001b0a8
 				MX6QDL_PAD_GPIO_6__ENET_IRQ		0x000b1
+				MX6QDL_PAD_EIM_D29__GPIO3_IO29   	0x80000000
 			>;
 		};
 
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: dts: imx6qdl-wandboard: Move FEC reset pin into the FEC pin group
  2014-04-23 20:13 [PATCH] ARM: dts: imx6qdl-wandboard: Move FEC reset pin into the FEC pin group Fabio Estevam
@ 2014-04-29  5:24 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2014-04-29  5:24 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Apr 23, 2014 at 05:13:22PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Remove GPIO3_29 (FEC PHY reset pin) from the hog group and place it into
> pinctrl_enet pin group instead.

If you can clean up the pinctrl settings to kill hog group completely
for the board, I would be happy to take the patch.  Otherwise, let's
leave it there for now, until you see a real problem with having the
pin in hog group than pinctrl_enet.

Shawn

> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> index 5c6f10c..79498ca 100644
> --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> @@ -104,7 +104,6 @@
>  				MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x80000000 /* WL_REG_ON */
>  				MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000 /* WL_HOST_WAKE */
>  				MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x80000000 /* WL_WAKE */
> -				MX6QDL_PAD_EIM_D29__GPIO3_IO29   0x80000000
>  			>;
>  		};
>  
> @@ -136,6 +135,7 @@
>  				MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL	0x1b0b0
>  				MX6QDL_PAD_GPIO_16__ENET_REF_CLK	0x4001b0a8
>  				MX6QDL_PAD_GPIO_6__ENET_IRQ		0x000b1
> +				MX6QDL_PAD_EIM_D29__GPIO3_IO29   	0x80000000
>  			>;
>  		};
>  
> -- 
> 1.8.3.2
> 
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-29  5:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-23 20:13 [PATCH] ARM: dts: imx6qdl-wandboard: Move FEC reset pin into the FEC pin group Fabio Estevam
2014-04-29  5:24 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).