linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx6q: work around faulty PMU irq routing
Date: Thu, 24 Apr 2014 22:23:49 +0200	[thread overview]
Message-ID: <1398371029-21176-1-git-send-email-l.stach@pengutronix.de> (raw)

The i.MX6 PMU has a design errata where the interrupts of all cores are
wired together into a single irq line. To work around this we have to
bounce the interrupt around all cores until we find the one where the PMU
counter overflow has happened.

This causes the perf measurements to be less accurate and we can't really
handle the case where two cores fire a PMU irq at the same time. The
implemented woraround makes perf at least somewhat useable on imx6 SoCs
with more than one core.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-imx/mach-imx6q.c | 38 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
index e60456d85c9d..73976c484826 100644
--- a/arch/arm/mach-imx/mach-imx6q.c
+++ b/arch/arm/mach-imx/mach-imx6q.c
@@ -16,6 +16,7 @@
 #include <linux/delay.h>
 #include <linux/export.h>
 #include <linux/init.h>
+#include "linux/interrupt.h"
 #include <linux/io.h>
 #include <linux/irq.h>
 #include <linux/irqchip.h>
@@ -33,6 +34,7 @@
 #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
+#include "asm/pmu.h"
 #include <asm/system_misc.h>
 
 #include "common.h"
@@ -261,6 +263,39 @@ static void __init imx6q_axi_init(void)
 	}
 }
 
+/*
+ * The i.MX6 PMU has a design errata where the interrupts of all cores are
+ * wired together into a single irq line. To work around this we have to
+ * bounce the interrupt around all cores until we find the one where the PMU
+ * counter overflow has happened.
+ */
+static irqreturn_t imx6q_pmu_handler(int irq, void *dev, irq_handler_t handler)
+{
+	irqreturn_t ret = handler(irq, dev);
+	int next;
+
+	if (ret == IRQ_NONE) {
+		/*
+		 * Kick the irq over to the next cpu, regardless of it's
+		 * online status (it might have gone offline while we were busy
+		 * bouncing the irq).
+		 */
+		next = (smp_processor_id() + 1) % num_present_cpus();
+		irq_set_affinity(irq, cpumask_of(next));
+	}
+
+	return ret;
+}
+
+struct arm_pmu_platdata imx6q_pmu_platdata = {
+	.handle_irq		= imx6q_pmu_handler,
+};
+
+static struct of_dev_auxdata imx6q_auxdata_lookup[] __initdata = {
+	OF_DEV_AUXDATA("arm,cortex-a9-pmu", 0, "arm-pmu", &imx6q_pmu_platdata),
+	{}
+};
+
 static void __init imx6q_init_machine(void)
 {
 	struct device *parent;
@@ -276,7 +311,8 @@ static void __init imx6q_init_machine(void)
 
 	imx6q_enet_phy_init();
 
-	of_platform_populate(NULL, of_default_bus_match_table, NULL, parent);
+	of_platform_populate(NULL, of_default_bus_match_table,
+			imx6q_auxdata_lookup, parent);
 
 	imx_anatop_init();
 	cpu_is_imx6q() ?  imx6q_pm_init() : imx6dl_pm_init();
-- 
1.9.1

             reply	other threads:[~2014-04-24 20:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 20:23 Lucas Stach [this message]
2014-04-24 20:32 ` [PATCH] ARM: imx6q: work around faulty PMU irq routing Fabio Estevam
2014-04-25  5:33   ` Dirk Behme
2014-04-25  5:37 ` Dirk Behme
2014-04-25  9:13   ` Lucas Stach
2014-04-29  5:28     ` Shawn Guo
2014-04-29  9:55       ` Lucas Stach
2014-04-29 11:17         ` Dirk Behme
2014-04-29 18:33           ` Frank Li
2014-04-30  9:21             ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398371029-21176-1-git-send-email-l.stach@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).