From: ashwin.chaugule@linaro.org (Ashwin Chaugule)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 3/3] ARM: Check if a CPU has gone offline
Date: Fri, 25 Apr 2014 15:48:49 -0400 [thread overview]
Message-ID: <1398455329-18136-4-git-send-email-ashwin.chaugule@linaro.org> (raw)
In-Reply-To: <1398455329-18136-1-git-send-email-ashwin.chaugule@linaro.org>
PSCIv0.2 adds a new function called AFFINITY_INFO, which
can be used to query if a specified CPU has actually gone
offline. Calling this function via cpu_kill ensures that
a CPU has quiesced after a call to cpu_die.
Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
arch/arm/kernel/psci_smp.c | 32 ++++++++++++++++++++++++++++++++
include/uapi/linux/psci.h | 5 +++++
2 files changed, 37 insertions(+)
diff --git a/arch/arm/kernel/psci_smp.c b/arch/arm/kernel/psci_smp.c
index 570a48c..94e230c 100644
--- a/arch/arm/kernel/psci_smp.c
+++ b/arch/arm/kernel/psci_smp.c
@@ -16,6 +16,8 @@
#include <linux/init.h>
#include <linux/smp.h>
#include <linux/of.h>
+#include <linux/delay.h>
+#include <uapi/linux/psci.h>
#include <asm/psci.h>
#include <asm/smp_plat.h>
@@ -66,6 +68,35 @@ void __ref psci_cpu_die(unsigned int cpu)
/* We should never return */
panic("psci: cpu %d failed to shutdown\n", cpu);
}
+
+int __ref psci_cpu_kill(unsigned int cpu)
+{
+ int err, i;
+
+ if (!psci_ops.affinity_info)
+ return 1;
+ /*
+ * cpu_kill could race with cpu_die and we can
+ * potentially end up declaring this cpu undead
+ * while it is dying. So, try again a few times.
+ */
+
+ for (i=0; i<10; i++) {
+ err = psci_ops.affinity_info(cpu_logical_map(cpu), 0);
+
+ if (err == PSCI_AFFINITY_INFO_RET_OFF)
+ return 1;
+
+ msleep(10);
+ pr_info("Retrying again to check for CPU kill\n");
+ }
+
+ pr_err("psci: Cannot kill CPU:%d, psci ret val: %d\n",
+ cpu, err);
+ /* Make platform_cpu_kill() fail. */
+ return 0;
+}
+
#endif
bool __init psci_smp_available(void)
@@ -78,5 +109,6 @@ struct smp_operations __initdata psci_smp_ops = {
.smp_boot_secondary = psci_boot_secondary,
#ifdef CONFIG_HOTPLUG_CPU
.cpu_die = psci_cpu_die,
+ .cpu_kill = psci_cpu_kill,
#endif
};
diff --git a/include/uapi/linux/psci.h b/include/uapi/linux/psci.h
index a4136c3..857209b 100644
--- a/include/uapi/linux/psci.h
+++ b/include/uapi/linux/psci.h
@@ -74,4 +74,9 @@
#define PSCI_RET_NOT_PRESENT -7
#define PSCI_RET_DISABLED -8
+/* Return values from the PSCI_ID_AFFINITY_INFO Function. */
+#define PSCI_AFFINITY_INFO_RET_ON 0
+#define PSCI_AFFINITY_INFO_RET_OFF 1
+#define PSCI_AFFINITY_INFO_RET_ON_PENDING 2
+
#endif /* _UAPI_LINUX_PSCI_H */
--
1.8.3.2
next prev parent reply other threads:[~2014-04-25 19:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 19:48 [PATCH v8 0/3] PSCI v0.2 support and DT bindings Ashwin Chaugule
2014-04-25 19:48 ` [PATCH v8 1/3] PSCI: Add initial support for PSCIv0.2 functions Ashwin Chaugule
2014-04-25 19:48 ` [PATCH v8 2/3] Documentation: devicetree: Add new binding for PSCIv0.2 Ashwin Chaugule
2014-04-25 19:48 ` Ashwin Chaugule [this message]
2014-04-28 6:18 ` [PATCH v8 3/3] ARM: Check if a CPU has gone offline Anup Patel
2014-04-28 12:16 ` Ashwin Chaugule
2014-04-28 12:23 ` Christoffer Dall
2014-04-28 12:30 ` Ashwin Chaugule
2014-04-28 13:03 ` Paolo Bonzini
2014-04-28 13:06 ` Christoffer Dall
2014-04-28 13:48 ` Paolo Bonzini
2014-04-28 13:54 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398455329-18136-4-git-send-email-ashwin.chaugule@linaro.org \
--to=ashwin.chaugule@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).