linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 09/17] ASoC: fsl-ssi: make fsl,mode property optional
Date: Mon, 28 Apr 2014 12:54:50 +0200	[thread overview]
Message-ID: <1398682498-24357-10-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1398682498-24357-1-git-send-email-mpa@pengutronix.de>

The simple soundcard binding has its own way for specifying the dai
format. To be able to use this binding we have to make the fsl,mode
property optional. As the property is used in existing devicetrees
keep the option around for compatibility reasons.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 sound/soc/fsl/fsl_ssi.c | 41 ++++++++++++++++++++++++++---------------
 1 file changed, 26 insertions(+), 15 deletions(-)

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index f2255cb..3821dac 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -564,12 +564,9 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream,
 	return 0;
 }
 
-/**
- * fsl_ssi_set_dai_fmt - configure Digital Audio Interface Format.
- */
-static int fsl_ssi_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
+static int _fsl_ssi_set_dai_fmt(struct fsl_ssi_private *ssi_private,
+		unsigned int fmt)
 {
-	struct fsl_ssi_private *ssi_private = snd_soc_dai_get_drvdata(cpu_dai);
 	struct ccsr_ssi __iomem *ssi = ssi_private->ssi;
 	u32 strcr = 0, stcr, srcr, scr, mask;
 	u8 wm;
@@ -707,6 +704,17 @@ static int fsl_ssi_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
 		fsl_ssi_setup_ac97(ssi_private);
 
 	return 0;
+
+}
+
+/**
+ * fsl_ssi_set_dai_fmt - configure Digital Audio Interface Format.
+ */
+static int fsl_ssi_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
+{
+	struct fsl_ssi_private *ssi_private = snd_soc_dai_get_drvdata(cpu_dai);
+
+	return _fsl_ssi_set_dai_fmt(ssi_private, fmt);
 }
 
 /**
@@ -1130,7 +1138,6 @@ static int fsl_ssi_probe(struct platform_device *pdev)
 	const uint32_t *iprop;
 	struct resource res;
 	char name[64];
-	bool ac97 = false;
 
 	/* SSIs that are not connected on the board should have a
 	 *      status = "disabled"
@@ -1143,14 +1150,6 @@ static int fsl_ssi_probe(struct platform_device *pdev)
 	if (!of_id || !of_id->data)
 		return -EINVAL;
 
-	sprop = of_get_property(np, "fsl,mode", NULL);
-	if (!sprop) {
-		dev_err(&pdev->dev, "fsl,mode property is necessary\n");
-		return -EINVAL;
-	}
-	if (!strcmp(sprop, "ac97-slave"))
-		ac97 = true;
-
 	ssi_private = devm_kzalloc(&pdev->dev, sizeof(*ssi_private),
 			GFP_KERNEL);
 	if (!ssi_private) {
@@ -1160,10 +1159,19 @@ static int fsl_ssi_probe(struct platform_device *pdev)
 
 	ssi_private->soc = of_id->data;
 
+	sprop = of_get_property(np, "fsl,mode", NULL);
+	if (sprop) {
+		if (!strcmp(sprop, "ac97-slave"))
+			ssi_private->dai_fmt = SND_SOC_DAIFMT_AC97;
+		else if (!strcmp(sprop, "i2s-slave"))
+			ssi_private->dai_fmt = SND_SOC_DAIFMT_I2S |
+				SND_SOC_DAIFMT_CBM_CFM;
+	}
+
 	ssi_private->use_dma = !of_property_read_bool(np,
 			"fsl,fiq-stream-filter");
 
-	if (ac97) {
+	if (fsl_ssi_is_ac97(ssi_private)) {
 		memcpy(&ssi_private->cpu_dai_drv, &fsl_ssi_ac97_dai,
 				sizeof(fsl_ssi_ac97_dai));
 
@@ -1274,6 +1282,9 @@ static int fsl_ssi_probe(struct platform_device *pdev)
 	}
 
 done:
+	if (ssi_private->dai_fmt)
+		_fsl_ssi_set_dai_fmt(ssi_private, ssi_private->dai_fmt);
+
 	return 0;
 
 error_sound_card:
-- 
1.9.1

  parent reply	other threads:[~2014-04-28 10:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28 10:54 [PATCH v4 00/17] ASoC: fsl-ssi: Driver cleanup Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 01/17] ASoC: fsl-ssi: Fix register values when disabling Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 02/17] ASoC: fsl-ssi: Move debugging to seperate file Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 03/17] ASoC: fsl-ssi: Use dev_name for DAI driver struct Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 04/17] ASoC: fsl-ssi: Move imx-specific probe to seperate function Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 05/17] ASoC: fsl-ssi: Remove useless DMA code Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 06/17] ASoC: fsl-ssi: Cleanup probe function Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 07/17] ASoC: fsl-ssi: Remove unnecessary variables from ssi_private Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 08/17] ASoC: fsl-ssi: introduce SoC specific data Markus Pargmann
2014-05-20 22:02   ` Mark Brown
2014-05-27  6:21     ` Markus Pargmann
2014-04-28 10:54 ` Markus Pargmann [this message]
2014-04-28 10:54 ` [PATCH v4 10/17] ASoC: fsl-ssi: Transmit enable synchronization Markus Pargmann
2014-05-20 22:04   ` Mark Brown
2014-04-28 10:54 ` [PATCH v4 11/17] ASoC: fsl-ssi: Move fsl_ssi_set_dai_sysclk above fsl_ssi_hw_params Markus Pargmann
2014-05-20 22:05   ` Mark Brown
2014-04-28 10:54 ` [PATCH v4 12/17] ASoC: fsl-ssi: set bitclock in master mode from hw_params Markus Pargmann
2014-05-20 22:08   ` Mark Brown
2014-05-27  7:05     ` Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 13/17] ASoC: fsl-ssi: remove unnecessary spinlock Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 14/17] ASoC: fsl-ssi: Set framerate divider correctly for i2s master mode Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 15/17] ASoC: fsl-ssi: Fix baudclock handling Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 16/17] ASoC: fsl-ssi: reorder and document fsl_ssi_private Markus Pargmann
2014-04-28 10:54 ` [PATCH v4 17/17] ASoC: fsl-ssi: Use regmap Markus Pargmann
2014-04-28 21:43 ` [PATCH v4 00/17] ASoC: fsl-ssi: Driver cleanup Michael Grzeschik
2014-05-20 22:10 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398682498-24357-10-git-send-email-mpa@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).