linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: remove redundant code in machine_halt
@ 2014-05-07  5:50 Neil Zhang
  2014-05-14  7:51 ` Neil Zhang
  0 siblings, 1 reply; 3+ messages in thread
From: Neil Zhang @ 2014-05-07  5:50 UTC (permalink / raw)
  To: linux-arm-kernel

There is no need to call local_irq_disable twice.

Signed-off-by: Neil Zhang <zhangwm@marvell.com>
---
 arch/arm/kernel/process.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 81ef686..18cfce4 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -195,7 +195,6 @@ void machine_halt(void)
 	local_irq_disable();
 	smp_send_stop();
 
-	local_irq_disable();
 	while (1);
 }
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: remove redundant code in machine_halt
  2014-05-07  5:50 [PATCH] ARM: remove redundant code in machine_halt Neil Zhang
@ 2014-05-14  7:51 ` Neil Zhang
  2014-07-04  3:05   ` Neil Zhang
  0 siblings, 1 reply; 3+ messages in thread
From: Neil Zhang @ 2014-05-14  7:51 UTC (permalink / raw)
  To: linux-arm-kernel

> -----Original Message-----
> From: Neil Zhang [mailto:zhangwm at marvell.com]
> Sent: 2014?5?7? 13:50
> To: linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> Cc: rmk+kernel at arm.linux.org.uk; Neil Zhang
> Subject: [PATCH] ARM: remove redundant code in machine_halt
> 
> There is no need to call local_irq_disable twice.
> 
> Signed-off-by: Neil Zhang <zhangwm@marvell.com>
> ---
>  arch/arm/kernel/process.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index
> 81ef686..18cfce4 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -195,7 +195,6 @@ void machine_halt(void)
>  	local_irq_disable();
>  	smp_send_stop();
> 
> -	local_irq_disable();
>  	while (1);
>  }
> 
> --
> 1.7.9.5

Any comments?

Best Regards,
Neil Zhang

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: remove redundant code in machine_halt
  2014-05-14  7:51 ` Neil Zhang
@ 2014-07-04  3:05   ` Neil Zhang
  0 siblings, 0 replies; 3+ messages in thread
From: Neil Zhang @ 2014-07-04  3:05 UTC (permalink / raw)
  To: linux-arm-kernel

> -----Original Message-----
> From: Neil Zhang
> Sent: 2014?5?14? 15:52
> To: Neil Zhang; linux-arm-kernel at lists.infradead.org;
> linux-kernel at vger.kernel.org
> Cc: rmk+kernel at arm.linux.org.uk
> Subject: RE: [PATCH] ARM: remove redundant code in machine_halt
> 
> > -----Original Message-----
> > From: Neil Zhang [mailto:zhangwm at marvell.com]
> > Sent: 2014?5?7? 13:50
> > To: linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> > Cc: rmk+kernel at arm.linux.org.uk; Neil Zhang
> > Subject: [PATCH] ARM: remove redundant code in machine_halt
> >
> > There is no need to call local_irq_disable twice.
> >
> > Signed-off-by: Neil Zhang <zhangwm@marvell.com>
> > ---
> >  arch/arm/kernel/process.c |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index
> > 81ef686..18cfce4 100644
> > --- a/arch/arm/kernel/process.c
> > +++ b/arch/arm/kernel/process.c
> > @@ -195,7 +195,6 @@ void machine_halt(void)
> >  	local_irq_disable();
> >  	smp_send_stop();
> >
> > -	local_irq_disable();
> >  	while (1);
> >  }
> >
> > --
> > 1.7.9.5
> 
> Any comments?
> 

Ping!

> Best Regards,
> Neil Zhang

Best Regards,
Neil Zhang

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-07-04  3:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-07  5:50 [PATCH] ARM: remove redundant code in machine_halt Neil Zhang
2014-05-14  7:51 ` Neil Zhang
2014-07-04  3:05   ` Neil Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).