From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F55C433E2 for ; Mon, 14 Sep 2020 08:43:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB9A22192A for ; Mon, 14 Sep 2020 08:43:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AcE2fz/j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB9A22192A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q7eKRQQXtKbKNLbYqBZi17E6LmrcYHaS3ACyR/03isg=; b=AcE2fz/jCvyMZHh9Bnw9oWp4d yYqRp97y5W7NuOhzjprJLlrC6kspJ9Nd7r0BX8tu9JtLiDRYaCdQ8g2OPsWAC24sqJrXjmDb/bLgN CaXpU0gezMoD9zsRZsdiROL8HbJwfrSFpm3sUburSP3ppWYvI+xwDhvsdX179qKTQxRKgMkmuN/es 4PKle9D0i4JqoLc7PWBBvxiw4FTR9oJ6wzN9HGDmgFovZHxpAsJ27guQXuNJCiL3NIZC8EUPHlV5B VHhu5p87XH8IiNt51Nsq+9A8HuR66CvO+H6cZof/T+Wyi/g2rD0Jad8EKyZUomn4OWSvsByGxlfgP en1b9TCrw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHk3t-0006f0-4v; Mon, 14 Sep 2020 08:42:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHk3p-0006eA-RV for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 08:42:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 399861045; Mon, 14 Sep 2020 01:42:05 -0700 (PDT) Received: from [10.57.12.229] (unknown [10.57.12.229]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 89C8B3F718; Mon, 14 Sep 2020 01:42:02 -0700 (PDT) Subject: Re: [PATCH v6 1/6] arm64: kprobe: add checks for ARMv8.3-PAuth combined instructions To: Will Deacon , Dave Martin References: <20200904104209.32385-1-amit.kachhap@arm.com> <20200904104209.32385-2-amit.kachhap@arm.com> <20200907214551.GD13815@willie-the-truck> <20200908105107.GQ6642@arm.com> <20200911135539.GA19961@willie-the-truck> From: Amit Kachhap Message-ID: <13a63fa2-b703-6418-c12f-37537069e0e7@arm.com> Date: Mon, 14 Sep 2020 14:12:00 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200911135539.GA19961@willie-the-truck> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_044205_973460_9B085C31 X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki K Poulose , Catalin Marinas , Mark Brown , James Morse , Vincenzo Frascino , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/11/20 7:25 PM, Will Deacon wrote: > On Tue, Sep 08, 2020 at 11:51:08AM +0100, Dave Martin wrote: >> On Mon, Sep 07, 2020 at 10:45:51PM +0100, Will Deacon wrote: >>> On Fri, Sep 04, 2020 at 04:12:04PM +0530, Amit Daniel Kachhap wrote: >>>> diff --git a/arch/arm64/include/asm/insn.h b/arch/arm64/include/asm/insn.h >>>> index 0bc46149e491..324234068fee 100644 >>>> --- a/arch/arm64/include/asm/insn.h >>>> +++ b/arch/arm64/include/asm/insn.h >>>> @@ -359,9 +359,21 @@ __AARCH64_INSN_FUNCS(brk, 0xFFE0001F, 0xD4200000) >>>> __AARCH64_INSN_FUNCS(exception, 0xFF000000, 0xD4000000) >>>> __AARCH64_INSN_FUNCS(hint, 0xFFFFF01F, 0xD503201F) >>>> __AARCH64_INSN_FUNCS(br, 0xFFFFFC1F, 0xD61F0000) >>>> +__AARCH64_INSN_FUNCS(braaz, 0xFFFFFC1F, 0xD61F081F) >>>> +__AARCH64_INSN_FUNCS(brabz, 0xFFFFFC1F, 0xD61F0C1F) >>>> +__AARCH64_INSN_FUNCS(braa, 0xFFFFFC00, 0xD71F0800) >>>> +__AARCH64_INSN_FUNCS(brab, 0xFFFFFC00, 0xD71F0C00) >>> >>> When do we need to distinguish these variants? Can we modify the mask/value >>> pair so that we catch bra* in one go? That would match how they are >>> documented in the Arm ARM. >>> >>>> __AARCH64_INSN_FUNCS(blr, 0xFFFFFC1F, 0xD63F0000) >>>> +__AARCH64_INSN_FUNCS(blraaz, 0xFFFFFC1F, 0xD63F081F) >>>> +__AARCH64_INSN_FUNCS(blrabz, 0xFFFFFC1F, 0xD63F0C1F) >>>> +__AARCH64_INSN_FUNCS(blraa, 0xFFFFFC00, 0xD73F0800) >>>> +__AARCH64_INSN_FUNCS(blrab, 0xFFFFFC00, 0xD73F0C00) >>> >>> Same here for blra* >>> >>>> __AARCH64_INSN_FUNCS(ret, 0xFFFFFC1F, 0xD65F0000) >>>> +__AARCH64_INSN_FUNCS(retaa, 0xFFFFFFFF, 0xD65F0BFF) >>>> +__AARCH64_INSN_FUNCS(retab, 0xFFFFFFFF, 0xD65F0FFF) >>>> __AARCH64_INSN_FUNCS(eret, 0xFFFFFFFF, 0xD69F03E0) >>>> +__AARCH64_INSN_FUNCS(eretaa, 0xFFFFFFFF, 0xD69F0BFF) >>>> +__AARCH64_INSN_FUNCS(eretab, 0xFFFFFFFF, 0xD69F0FFF) >>> >>> ... and here for ereta*. >> >> From my side: >> >> I thought about this myself, but I thought that this may be easier to >> maintain if we avoid lumping instructions together. > > Maybe, but I'm just suggesting to lump them together in the same way as the > Arm ARM, which I think helps readability because it lines up directly with > the text. > >> I guess I'm happy either way. > > Ok, thanks. Amit -- can you repost the series with that change, please, and > I'll queue the lot for 5.10? My v8 revision posted just now has this clubbing of instructions. Thanks, Amit > > Thanks, > > Will > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel