From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA324C7EE25 for ; Thu, 8 Jun 2023 21:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FTDzrNpfFnNhgGW6389iAeKKr1FvX9X4uRcGNmTcyxA=; b=qJiZTooGOnkjVb ANVCyLKcwxRKrZI7ZnvaaomTDOYk+OGjSG0sFCEFIbi62IVY5a9eKlWBAgWslSPljSfnT7CxZ3uGw vgsyxTs+h3x/Iux9OCfgRTqSihdABP6cQXJN84ReHcI+0kl5SAhmOUhGkuHgtqMk90dqM7ox3PcRc 9M3EO2wSQzbT5CfJyrbBfVcokhDrGg+C/dcd6Ce4n2x5z7Dyn8g9YjfEPLu8CTgjbE1bp3Xj3Jodg wxxlwtYar4F/p3ZH8R0/5f8pdiYuBdkF+byxfy/V87cT7UnprHx1lviLSCSswHmD5hCy3As7xKM20 4Xl0FiDwqF3mdG94oBww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7NME-00Ai34-0l; Thu, 08 Jun 2023 21:39:50 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7NMB-00Ai1w-02; Thu, 08 Jun 2023 21:39:48 +0000 Received: from [192.168.1.141] ([37.4.248.58]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MvJwN-1pq7aO1WPx-00rGMj; Thu, 08 Jun 2023 23:39:41 +0200 Message-ID: <13fd5204-4670-264d-5553-1475af3b203e@i2se.com> Date: Thu, 8 Jun 2023 23:39:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 01/12] mmc: bcm2835: fix deferred probing Content-Language: en-US To: Sergey Shtylyov , Ulf Hansson , linux-mmc@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20230608194519.10665-1-s.shtylyov@omp.ru> <20230608194519.10665-2-s.shtylyov@omp.ru> From: Stefan Wahren In-Reply-To: <20230608194519.10665-2-s.shtylyov@omp.ru> X-Provags-ID: V03:K1:fKVW1rSYgvHG7LqI8zcNuFf32oiMHK/6x8XgMt8c29LehE+2hC4 3VsnBIXRxTh4vw8hirLs0+ljbgV/tmdgXlkNZtdUHlrecCaweLzxappcX/hBjQRBnoG2tkd 6VnAblH0B/wgV0em7BsGCrr7ITFtWMWFBhoIiOjtqAEXlXdY7A05EJUMFquG/s8mtLxDKv8 3RRv/OQxpxJ0vR9tQvinA== UI-OutboundReport: notjunk:1;M01:P0:pK5VfF5H3Yk=;eueny/g8neKs75jjcYYGQ0+Mab+ 4wMB7a9aO6/bq47UYEcZ+2+qMMA9C/x+8Z6xWB8+HDb5aSlaBcDMfPUPWWKf6HS2YixMKjzk6 TnjrgDLBAZtUsgYcp+mKKTFqK2ifG9iT1MAMjTiJV72CYHRjEiB9Ylpkcu+e35PO2cV8UpktI UTE6pxRiiRX0fUMTOfRcxL3dJa4KHKUFT4G957eRcdqOE8KvYMehhFbzLRDmHELfpbn9nB/md TXdOqAXUsB/y6EdQhSbRP/zkyEyBw6XK9L1bNWxvDRKPvJq2X319W05KcO/2JGF9lEm0Co4dH CY+YKIoEGS2rioyePtsqMhkMR15jpSDSaemvqa55Gjj9xCoWvVvD4IEaJk7oSh/bA6x+mZjeL ZFOWIuiXr5jHKwASJdNiXGDwEj5LIzJ1BinQQOhGepMKt9Ln9YY3eaINNNJyFLBzbLSC3ZrSM PEiVX7Yql6I1MES1hydJq2MGmPwhshV8HcJ6tKQM1TQgFnD2ET+6DtKsK8konYXsomN3dxPMx XkQpGRkZB04we+iZeu/7orAE2/cNZXlnoWwhSoj7wAZx8a5/mMypZQN6JU7fQKoi2ryCFgODn HlzKECglk0NcxRDeiYD2SzVy1NHVVHzv4G5Q5rtu0oxFzq3UFWs+P6fBrtATGGED2Y8uwOF5U HBM8VdB09xA6h6czxv7hZUVc5A1s072ddXPo2R4VyA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_143947_427062_36B4E4FD X-CRM114-Status: GOOD ( 22.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sergey, was there a cover for this series, since the RFC series before had one? Am 08.06.23 um 21:45 schrieb Sergey Shtylyov: > The driver overrides the error codes and IRQ0 returned by platform_get_irq() > to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe > permanently instead of the deferred probing. Switch to propagating the error > codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now > can safely ignore it... > > Fixes: 660fc733bd74 ("mmc: bcm2835: Add new driver for the sdhost controller.") I know this is very theoretical, but does the statement "IRQ0 is no longer returned by platform_get_irq()" also applies to the time of the fixes commit? I'm asking because the fix could be backported to Linux 4.14. Best regards > Signed-off-by: Sergey Shtylyov > --- > Changes in version 2: > - refreshed the patch; > - slightly reformatted the patch description. > > drivers/mmc/host/bcm2835.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c > index 8648f7e63ca1..eea208856ce0 100644 > --- a/drivers/mmc/host/bcm2835.c > +++ b/drivers/mmc/host/bcm2835.c > @@ -1403,8 +1403,8 @@ static int bcm2835_probe(struct platform_device *pdev) > host->max_clk = clk_get_rate(clk); > > host->irq = platform_get_irq(pdev, 0); > - if (host->irq <= 0) { > - ret = -EINVAL; > + if (host->irq < 0) { > + ret = host->irq; > goto err; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel