* [PATCH] ARM: pxa: fix typo 'CONFIG_SPI_PXA2XX_MASTER'
@ 2014-05-16 10:40 Paul Bolle
2014-07-04 13:07 ` Haojian Zhuang
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2014-05-16 10:40 UTC (permalink / raw)
To: linux-arm-kernel
CONFIG_SPI_PXA2XX_MASTER was used were it was surely meant to use
CONFIG_SPI_PXA2XX_MODULE. Use the IS_ENABLED() macro here, as it guards
against typos like this one.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested, and (hardware) testing for the modular case might be needed.
This typo was introduced in v2.6.28.
arch/arm/mach-pxa/corgi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-pxa/corgi.c b/arch/arm/mach-pxa/corgi.c
index 57d60542f982..ccff8d82cc27 100644
--- a/arch/arm/mach-pxa/corgi.c
+++ b/arch/arm/mach-pxa/corgi.c
@@ -513,7 +513,7 @@ static struct pxa2xx_udc_mach_info udc_info __initdata = {
.gpio_pullup = CORGI_GPIO_USB_PULLUP,
};
-#if defined(CONFIG_SPI_PXA2XX) || defined(CONFIG_SPI_PXA2XX_MASTER)
+#if IS_ENABLED(CONFIG_SPI_PXA2XX)
static struct pxa2xx_spi_master corgi_spi_info = {
.num_chipselect = 3,
};
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: pxa: fix typo 'CONFIG_SPI_PXA2XX_MASTER'
2014-05-16 10:40 [PATCH] ARM: pxa: fix typo 'CONFIG_SPI_PXA2XX_MASTER' Paul Bolle
@ 2014-07-04 13:07 ` Haojian Zhuang
0 siblings, 0 replies; 2+ messages in thread
From: Haojian Zhuang @ 2014-07-04 13:07 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 16, 2014 at 6:40 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> CONFIG_SPI_PXA2XX_MASTER was used were it was surely meant to use
> CONFIG_SPI_PXA2XX_MODULE. Use the IS_ENABLED() macro here, as it guards
> against typos like this one.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested, and (hardware) testing for the modular case might be needed.
> This typo was introduced in v2.6.28.
>
> arch/arm/mach-pxa/corgi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-pxa/corgi.c b/arch/arm/mach-pxa/corgi.c
> index 57d60542f982..ccff8d82cc27 100644
> --- a/arch/arm/mach-pxa/corgi.c
> +++ b/arch/arm/mach-pxa/corgi.c
> @@ -513,7 +513,7 @@ static struct pxa2xx_udc_mach_info udc_info __initdata = {
> .gpio_pullup = CORGI_GPIO_USB_PULLUP,
> };
>
> -#if defined(CONFIG_SPI_PXA2XX) || defined(CONFIG_SPI_PXA2XX_MASTER)
> +#if IS_ENABLED(CONFIG_SPI_PXA2XX)
> static struct pxa2xx_spi_master corgi_spi_info = {
> .num_chipselect = 3,
> };
> --
> 1.9.0
>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-04 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-16 10:40 [PATCH] ARM: pxa: fix typo 'CONFIG_SPI_PXA2XX_MASTER' Paul Bolle
2014-07-04 13:07 ` Haojian Zhuang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).