From: minyard@acm.org (minyard at acm.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Set hardirq tracing to on when idling
Date: Sun, 25 May 2014 14:15:23 -0500 [thread overview]
Message-ID: <1401045323-7116-1-git-send-email-minyard@acm.org> (raw)
From: Corey Minyard <cminyard@mvista.com>
The CPU will go to idle with interrupts off, but the interrupts
will wake up the idle. This was causing very long irqsoff trace
values because, basically, the whole idle time was traces with
irqs off, even though they weren't really off. Rework the idle
code to turn hardirq tracing to on befor calling idle.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
arch/arm/kernel/process.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
I'm not sure this is correct for all ARM boards, but it fixes the
issue for the Vexpress board I have. No more 4 second irqsoff
times.
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 1ca6cf1..92413af 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -133,11 +133,12 @@ void (*arm_pm_idle)(void);
static void default_idle(void)
{
+ trace_hardirqs_on();
if (arm_pm_idle)
arm_pm_idle();
else
cpu_do_idle();
- local_irq_enable();
+ raw_local_irq_enable();
}
void arch_cpu_idle_prepare(void)
--
1.8.3.1
next reply other threads:[~2014-05-25 19:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 19:15 minyard at acm.org [this message]
2014-05-26 9:26 ` [PATCH] arm: Set hardirq tracing to on when idling Arnd Bergmann
2014-05-27 13:21 ` Corey Minyard
2014-05-27 16:16 ` Arnd Bergmann
2014-05-27 18:50 ` Corey Minyard
2014-05-27 16:38 ` Stanislav Meduna
2014-05-27 18:49 ` Arnd Bergmann
2014-05-27 18:53 ` Stephen Boyd
2014-05-27 19:27 ` Arnd Bergmann
2014-05-27 19:33 ` Stephen Boyd
2014-05-27 19:39 ` Arnd Bergmann
2014-05-27 20:22 ` Stephen Boyd
2014-05-28 0:28 ` Corey Minyard
2014-05-28 6:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401045323-7116-1-git-send-email-minyard@acm.org \
--to=minyard@acm.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).