linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: rename ARM_ERRATA_753970
Date: Mon, 26 May 2014 11:01:11 +0200	[thread overview]
Message-ID: <1401094871.25902.20.camel@x220> (raw)
In-Reply-To: <1396805315.7723.8.camel@x220>

ARM_ERRATA_753970 was renamed to PL310_ERRATA_753970 in v3.2, through
commit fa0ce4035d48 ("ARM: 7162/1: errata: tidy up Kconfig options for
PL310 errata workarounds"). Two selects were added in v3.15-rc1 that
still use the previous name. Rename these.

Make these statements depend on CACHE_PL310, like all other selects of
PL310_ERRATA_753970. That way it will only be selected if its dependency
is met.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
I reported this before v3.15-rc1. I don't know whether any fixes are
pending. None are in linux-next. And ignoring an errata were one
apparently could be needed sounds, well, scary. Perhaps it is not.
Anyhow, to make sure this gets fixed, hopefully before v3.15, I'm
submitting this (untested!) patch.

A related observation. There are three PL310 errata options: one depends
on CACHE_PL310, three depend on CACHE_L2X0. The one depending on
CACHE_PL310 is selected only if CACHE_PL310 is set.

But the three depending on CACHE_L2X0 are selected a few times if
CACHE_L2X0 is set, in other cases if CACHE_PL310 is set, and in some
cases always. There may be good reasons for this, but it looks odd. I
know nothing about the PL310 cache and its erratas, so I haven't looked
into this any further.

 arch/arm/mach-mvebu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 3f73eecbcfb0..501d0f42e7b2 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -35,7 +35,7 @@ config MACH_ARMADA_370
 config MACH_ARMADA_375
 	bool "Marvell Armada 375 boards" if ARCH_MULTI_V7
 	select ARM_ERRATA_720789
-	select ARM_ERRATA_753970
+	select PL310_ERRATA_753970 if CACHE_PL310
 	select ARM_GIC
 	select ARMADA_375_CLK
 	select CPU_V7
@@ -48,7 +48,7 @@ config MACH_ARMADA_375
 config MACH_ARMADA_38X
 	bool "Marvell Armada 380/385 boards" if ARCH_MULTI_V7
 	select ARM_ERRATA_720789
-	select ARM_ERRATA_753970
+	select PL310_ERRATA_753970 if CACHE_PL310
 	select ARM_GIC
 	select ARMADA_38X_CLK
 	select CPU_V7
-- 
1.9.0

  reply	other threads:[~2014-05-26  9:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201404052101.19381.arnd@arndb.de>
2014-04-05 19:02 ` [GIT PULL 1/8] ARM: SoC non-critical bug fixes for 3.15 Arnd Bergmann
2014-04-05 19:03 ` [GIT PULL 2/8] ARM: SoC: cleanups " Arnd Bergmann
2014-04-05 19:04 ` [GIT PULL 3/8] ARM: SoC specific changes Arnd Bergmann
     [not found]   ` <1396777049.30640.9.camel@x220>
2014-04-06 17:02     ` Kconfig ARM_ERRATA_753970? Gregory CLEMENT
2014-04-06 17:28       ` Paul Bolle
2014-05-26  9:01         ` Paul Bolle [this message]
2014-06-20 20:21           ` [PATCH] ARM: mvebu: rename ARM_ERRATA_753970 Jason Cooper
2014-06-20 20:42             ` Paul Bolle
2014-06-20 21:10               ` Jason Cooper
2014-06-23  7:58                 ` Paul Bolle
2014-06-20 20:53             ` Russell King - ARM Linux
2014-06-23  9:01               ` [PATCH v2] " Paul Bolle
2014-06-23  9:07                 ` Russell King - ARM Linux
2014-06-23  9:34                   ` Paul Bolle
2014-09-12 11:10                     ` [PATCH v3] " Paul Bolle
2014-09-12 13:31                       ` Russell King - ARM Linux
2014-11-05  9:11                         ` Paul Bolle
2014-04-05 19:04 ` [GIT PULL 4/8] ARM: SoC: board changes Arnd Bergmann
2014-04-05 19:05 ` [GIT PULL 5/8] ARM: SoC: device tree changes Arnd Bergmann
2014-04-05 19:06 ` [GIT PULL 6/8] ARM: SoC: driver changes Arnd Bergmann
2014-04-05 19:06 ` [GIT PULL 7/8] ARM: SoC: sh " Arnd Bergmann
2014-04-05 19:07 ` [GIT PULL 8/8] ARM: SoC: late cleanups Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401094871.25902.20.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).