From: santosh.shukla@linaro.org (Santosh Shukla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Exynos : Fix build error with thumb2
Date: Mon, 26 May 2014 21:23:45 +0530 [thread overview]
Message-ID: <1401119625-11309-1-git-send-email-santosh.shukla@linaro.org> (raw)
From: santosh shukla <santosh.shukla@linaro.org>
Add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode.
IIUC, arm assembler fail to load value of "global" variable
l2xo_regs_phys for thum2 mode and wrapping it in non-global symbol like
.Ll2x0_regs_phys solves the build break issue.
arch/arm/mach-exynos/sleep.S: Assembler messages:
arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address
calculation (value = 0x00000004)
fix inspired from [1]
[1] https://lkml.org/lkml/2010/3/31/235
Signed-off-by: santosh shukla <santosh.shukla@linaro.org>
---
arch/arm/mach-exynos/sleep.S | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/sleep.S b/arch/arm/mach-exynos/sleep.S
index a2613e9..dc8c6b6 100644
--- a/arch/arm/mach-exynos/sleep.S
+++ b/arch/arm/mach-exynos/sleep.S
@@ -54,7 +54,7 @@ ENTRY(exynos_cpu_resume)
ldr r1, =CPU_CORTEX_A9
cmp r0, r1
bne skip_l2_resume
- adr r0, l2x0_regs_phys
+ adr r0, .Ll2x0_regs_phys
ldr r0, [r0]
cmp r0, #0
beq skip_l2_resume
@@ -79,6 +79,8 @@ skip_l2_resume:
b cpu_resume
ENDPROC(exynos_cpu_resume)
#ifdef CONFIG_CACHE_L2X0
+
+.Ll2x0_regs_phys:
.globl l2x0_regs_phys
l2x0_regs_phys:
.long 0
--
1.7.9.5
next reply other threads:[~2014-05-26 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 15:53 Santosh Shukla [this message]
2014-05-28 14:03 ` [PATCH] ARM: Exynos : Fix build error with thumb2 Santosh Shukla
2014-06-02 10:10 ` Dave Martin
2014-06-04 8:07 ` Santosh Shukla
2014-06-11 15:13 ` Kukjin Kim
-- strict thread matches above, loose matches on Subject: below --
2015-03-16 17:38 [PATCH] ARM: Exynos: " Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401119625-11309-1-git-send-email-santosh.shukla@linaro.org \
--to=santosh.shukla@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).