[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Sachin Kamat]

Almost all Exynos-series of SoCs that run in secure mode don't need
additional offset for every CPU, with Exynos4412 being the only
exception.

Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).

While at it, fix the coding style (space around *).

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/mach-exynos/firmware.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
index eb91d2350f8c..e8797bb78871 100644
--- a/arch/arm/mach-exynos/firmware.c
+++ b/arch/arm/mach-exynos/firmware.c
@@ -57,8 +57,13 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
 
 	boot_reg = sysram_ns_base_addr + 0x1c;
 
-	if (!soc_is_exynos4212() && !soc_is_exynos3250())
-		boot_reg += 4*cpu;
+	/*
+	 * Almost all Exynos-series of SoCs that run in secure mode don't need
+	 * additional offset for every CPU, with Exynos4412 being the only
+	 * exception.
+	 */
+	if (soc_is_exynos4412())
+		boot_reg += 4 * cpu;
 
 	__raw_writel(boot_addr, boot_reg);
 	return 0;
-- 
1.7.9.5

[PATCH v2 Resend 2/2] ARM: dts: Add secure firmware support for Arndale-octa

[Sachin Kamat]

From: Tushar Behera <tushar.behera@linaro.org>

Arndale-Octa board is always configured to work with trustzone
firmware binary. Added DTS node entry to enable this support.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos5420-arndale-octa.dts |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index 6ee8149fd5c4..434fd9d3e09d 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -26,6 +26,11 @@
 		bootargs = "console=ttySAC3,115200";
 	};
 
+	firmware at 02073000 {
+		compatible = "samsung,secure-firmware";
+		reg = <0x02073000 0x1000>;
+	};
+
 	fixed-rate-clocks {
 		oscclk {
 			compatible = "samsung,exynos5420-oscclk";
-- 
1.7.9.5

[PATCH v2 Resend 2/2] ARM: dts: Add secure firmware support for Arndale-octa

[Kukjin Kim]

On 05/28/14 13:13, Sachin Kamat wrote:
> From: Tushar Behera<tushar.behera@linaro.org>
>
> Arndale-Octa board is always configured to work with trustzone
> firmware binary. Added DTS node entry to enable this support.
>
> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
> ---
>   arch/arm/boot/dts/exynos5420-arndale-octa.dts |    5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
> index 6ee8149fd5c4..434fd9d3e09d 100644
> --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
> +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
> @@ -26,6 +26,11 @@
>   		bootargs = "console=ttySAC3,115200";
>   	};
>
> +	firmware at 02073000 {
> +		compatible = "samsung,secure-firmware";
> +		reg =<0x02073000 0x1000>;
> +	};
> +
>   	fixed-rate-clocks {
>   		oscclk {
>   			compatible = "samsung,exynos5420-oscclk";

Applied, thanks.

- Kukjin

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Andreas Färber]

Am 28.05.2014 06:13, schrieb Sachin Kamat:
> Almost all Exynos-series of SoCs that run in secure mode don't need
> additional offset for every CPU, with Exynos4412 being the only
> exception.
> 
> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
> 
> While at it, fix the coding style (space around *).
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
applying the 5410 patches...

Tested-by: Andreas F?rber <afaerber@suse.de>

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Kukjin Kim]

On 05/31/14 03:19, Andreas F?rber wrote:
> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>> Almost all Exynos-series of SoCs that run in secure mode don't need
>> additional offset for every CPU, with Exynos4412 being the only
>> exception.
>>
>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>
>> While at it, fix the coding style (space around *).
>>
>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>> ---
>>   arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
> applying the 5410 patches...
>
> Tested-by: Andreas F?rber<afaerber@suse.de>
>
Andreas, thanks for your test :-)

Sachin, How about exynos4210, 5250, 5260 and 5440?...
I need to check again, honestly I don't remember all of Exynos SoCs' 
different things ;-) Then will apply into fixes for 3.16.

Thanks,
Kukjin

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Tomasz Figa]

On 30.05.2014 20:42, Kukjin Kim wrote:
> On 05/31/14 03:19, Andreas F?rber wrote:
>> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>>> Almost all Exynos-series of SoCs that run in secure mode don't need
>>> additional offset for every CPU, with Exynos4412 being the only
>>> exception.
>>>
>>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>>
>>> While at it, fix the coding style (space around *).
>>>
>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>>> ---
>>>   arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>> applying the 5410 patches...
>>
>> Tested-by: Andreas F?rber<afaerber@suse.de>
>>
> Andreas, thanks for your test :-)
> 
> Sachin, How about exynos4210, 5250, 5260 and 5440?...
> I need to check again, honestly I don't remember all of Exynos SoCs'
> different things ;-) Then will apply into fixes for 3.16.

Exynos4210 doesn't use secure firmware, at least on any board supported
in mainline. Not sure about those Exynos5 models, but the only boards
supported in mainline with firmware node in DT are based on Exynos4412
or Exynos5410.

Best regards,
Tomasz

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Tushar Behera]

On 05/31/2014 12:17 AM, Tomasz Figa wrote:
> On 30.05.2014 20:42, Kukjin Kim wrote:
>> On 05/31/14 03:19, Andreas F?rber wrote:
>>> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>>>> Almost all Exynos-series of SoCs that run in secure mode don't need
>>>> additional offset for every CPU, with Exynos4412 being the only
>>>> exception.
>>>>
>>>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>>>
>>>> While at it, fix the coding style (space around *).
>>>>
>>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>>>> ---
>>>>   arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>>> applying the 5410 patches...
>>>
>>> Tested-by: Andreas F?rber<afaerber@suse.de>
>>>
>> Andreas, thanks for your test :-)
>>
>> Sachin, How about exynos4210, 5250, 5260 and 5440?...
>> I need to check again, honestly I don't remember all of Exynos SoCs'
>> different things ;-) Then will apply into fixes for 3.16.
> 
> Exynos4210 doesn't use secure firmware, at least on any board supported
> in mainline. Not sure about those Exynos5 models, but the only boards
> supported in mainline with firmware node in DT are based on Exynos4412
> or Exynos5410.
> 
> Best regards,
> Tomasz
> 

Kukjin,

Would you please pick this patch as a fix for 3.16?

-- 
Tushar Behera

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Sachin Kamat]

Kukjin,

On Sat, May 31, 2014 at 12:12 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 05/31/14 03:19, Andreas F?rber wrote:
>>
>> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>>>
>>> Almost all Exynos-series of SoCs that run in secure mode don't need
>>> additional offset for every CPU, with Exynos4412 being the only
>>> exception.
>>>
>>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>>
>>> While at it, fix the coding style (space around *).
>>>
>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>>> ---
>>>   arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>
>>
>> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>> applying the 5410 patches...
>>
>> Tested-by: Andreas F?rber<afaerber@suse.de>
>>
> Andreas, thanks for your test :-)
>
> Sachin, How about exynos4210, 5250, 5260 and 5440?...
> I need to check again, honestly I don't remember all of Exynos SoCs'
> different things ;-) Then will apply into fixes for 3.16.

ping..

 --
Regards,
Sachin.

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Sachin Kamat]

On Fri, May 30, 2014 at 11:49 PM, Andreas F?rber <afaerber@suse.de> wrote:
> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>> Almost all Exynos-series of SoCs that run in secure mode don't need
>> additional offset for every CPU, with Exynos4412 being the only
>> exception.
>>
>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>
>> While at it, fix the coding style (space around *).
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> ---
>>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
> applying the 5410 patches...
>
> Tested-by: Andreas F?rber <afaerber@suse.de>
>

Kukjin, this patch is required to bring up 4 A15 cores on some 5410
and 5420 based
boards. Can you please queue this up for the upcoming rc as fixes?

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Kukjin Kim]

Sachin Kamat wrote:
> 
> On Fri, May 30, 2014 at 11:49 PM, Andreas F?rber <afaerber@suse.de> wrote:
> > Am 28.05.2014 06:13, schrieb Sachin Kamat:
> >> Almost all Exynos-series of SoCs that run in secure mode don't need
> >> additional offset for every CPU, with Exynos4412 being the only
> >> exception.
> >>
> >> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
> >>
> >> While at it, fix the coding style (space around *).
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> >> ---
> >>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
> >>  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
> > applying the 5410 patches...
> >
> > Tested-by: Andreas F?rber <afaerber@suse.de>
> >
> 
> Kukjin, this patch is required to bring up 4 A15 cores on some 5410
> and 5420 based
> boards. Can you please queue this up for the upcoming rc as fixes?

Sure, I will take this into fixes.

Thanks,
Kukjin

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Andreas Färber]

Am 25.06.2014 13:43, schrieb Kukjin Kim:
> Sachin Kamat wrote:
>>
>> On Fri, May 30, 2014 at 11:49 PM, Andreas F?rber <afaerber@suse.de> wrote:
>>> Am 28.05.2014 06:13, schrieb Sachin Kamat:
>>>> Almost all Exynos-series of SoCs that run in secure mode don't need
>>>> additional offset for every CPU, with Exynos4412 being the only
>>>> exception.
>>>>
>>>> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>>>>
>>>> While at it, fix the coding style (space around *).
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>>> ---
>>>>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
>>>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>>> applying the 5410 patches...
>>>
>>> Tested-by: Andreas F?rber <afaerber@suse.de>

FWIW meanwhile I also successfully tested it on 5420 based Arndale Octa.

I can also check on 5250 based Spring, now that it's working, if that
helps build confidence in the patch.

Cheers,
Andreas

>> Kukjin, this patch is required to bring up 4 A15 cores on some 5410
>> and 5420 based
>> boards. Can you please queue this up for the upcoming rc as fixes?
> 
> Sure, I will take this into fixes.
> 
> Thanks,
> Kukjin

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

[PATCH v2 Resend 1/2] ARM: EXYNOS: Update secondary boot addr for secure mode

[Sachin Kamat]

On Wed, Jun 25, 2014 at 5:13 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Sachin Kamat wrote:
>>
>> On Fri, May 30, 2014 at 11:49 PM, Andreas F?rber <afaerber@suse.de> wrote:
>> > Am 28.05.2014 06:13, schrieb Sachin Kamat:
>> >> Almost all Exynos-series of SoCs that run in secure mode don't need
>> >> additional offset for every CPU, with Exynos4412 being the only
>> >> exception.
>> >>
>> >> Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
>> >>
>> >> While at it, fix the coding style (space around *).
>> >>
>> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> >> ---
>> >>  arch/arm/mach-exynos/firmware.c |    9 +++++++--
>> >>  1 file changed, 7 insertions(+), 2 deletions(-)
>> >
>> > Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to
>> > applying the 5410 patches...
>> >
>> > Tested-by: Andreas F?rber <afaerber@suse.de>
>> >
>>
>> Kukjin, this patch is required to bring up 4 A15 cores on some 5410
>> and 5420 based
>> boards. Can you please queue this up for the upcoming rc as fixes?
>
> Sure, I will take this into fixes.

Kukjin,

I don't see this patch in your fixes-2 branch yet.


>
> Thanks,
> Kukjin
>

Regards,
Sachin.