From mboxrd@z Thu Jan 1 00:00:00 1970 From: James.Bottomley@HansenPartnership.com (James Bottomley) Date: Wed, 28 May 2014 18:26:44 +0400 Subject: [PATCH] acornscsi: remove linked command support In-Reply-To: <20140528104114.GE13542@infradead.org> References: <1400926433.31526.89.camel@x220> <20140528104114.GE13542@infradead.org> Message-ID: <1401287204.2288.28.camel@dabdike> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: > On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: > > The acornscsi driver was added in v2.1.88. It has always #undef-ed > > CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be > > sure, it has also always triggered a preprocessor error if > > CONFIG_SCSI_ACORNSCSI_LINK was still defined. But, as far as I can see, > > it has never even been possible to set SCSI_ACORNSCSI_LINK through > > kconfig, or its predecessors, in the first place. > > > > Let's remove the code involved. > > > > Signed-off-by: Paul Bolle > > Looks good, > > Reviewed-by: Christoph Hellwig > > And I have to disagree with James here, removing code that isn't even > compiled always is an improvement, especially for an unmaintained > driver. Well, as I said, this is in theory a maintained driver, so just get an ack from Russell and this debate is moot. James