From mboxrd@z Thu Jan 1 00:00:00 1970 From: r.sricharan@ti.com (Sricharan R) Date: Tue, 3 Jun 2014 13:12:54 +0530 Subject: [PATCH 02/14] irqchip: crossbar: fix sparse warnings In-Reply-To: <1401781386-4982-1-git-send-email-r.sricharan@ti.com> References: <1401781386-4982-1-git-send-email-r.sricharan@ti.com> Message-ID: <1401781386-4982-3-git-send-email-r.sricharan@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Nishanth Menon There is absolutely no need for crossbar driver to expose functions and variables into global namespace. So make them all static Fixes sparse warnings: drivers/irqchip/irq-crossbar.c:129:29: warning: symbol 'routable_irq_domain_ops' was not declared. Should it be static? drivers/irqchip/irq-crossbar.c:252:5: warning: symbol 'dra_irqs_unused' was not declared. Should it be static? drivers/irqchip/irq-crossbar.c:253:22: warning: symbol 'cb_dra_data' was not declared. Should it be static? drivers/irqchip/irq-crossbar.c:261:12: warning: symbol 'irqcrossbar_init' was not declared. Should it be static? Signed-off-by: Nishanth Menon --- drivers/irqchip/irq-crossbar.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index c5415ae..5da9d36 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -16,6 +16,7 @@ #include #include #include +#include #define IRQ_FREE -1 #define IRQ_RESERVED -2 @@ -126,7 +127,7 @@ found: return 0; } -const struct irq_domain_ops routable_irq_domain_ops = { +static const struct irq_domain_ops routable_irq_domain_ops = { .map = crossbar_domain_map, .unmap = crossbar_domain_unmap, .xlate = crossbar_domain_xlate @@ -249,8 +250,8 @@ err1: } /* irq number 10 cannot be used because of hw bug */ -int dra_irqs_unused[] = { 10 }; -struct crossbar_data cb_dra_data = { dra_irqs_unused, +static int dra_irqs_unused[] = { 10 }; +static struct crossbar_data cb_dra_data = { dra_irqs_unused, ARRAY_SIZE(dra_irqs_unused), 0 }; static const struct of_device_id crossbar_match[] __initconst = { -- 1.7.9.5