From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] clocksource: exynos_mct: Optimize register reads with ldmia
Date: Wed, 4 Jun 2014 10:30:34 -0700 [thread overview]
Message-ID: <1401903034-20074-3-git-send-email-dianders@chromium.org> (raw)
In-Reply-To: <1401903034-20074-1-git-send-email-dianders@chromium.org>
As we saw in (clocksource: exynos_mct: cache mct upper count), the
time spent reading the MCT shows up fairly high in real-world
profiles. That means that it's worth some optimization.
We get a roughly 10% speedup in userspace gettimeofday() by using an
ldmia to read the two halfs of the MCT. That seems like a worthwhile
thing to do.
Before: 1173084 us for 1000000 gettimeofday in userspace
After: 1045674 us for 1000000 gettimeofday in userspace
NOTE: we could actually do better than this if we really wanted to.
Technically we could register the clocksource as a 32-bit timer and
only use the "lower" half. Doing so brings us down to 1014429 us for
1000000 gettimeofday in userspace (and doesn't even require assembly
code). That would be an alternative to this change.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
drivers/clocksource/exynos_mct.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 7cbe4aa..6e3017b 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -172,8 +172,9 @@ static inline cycle_t notrace _exynos4_frc_read(void)
do {
hi = hi2;
- lo = __raw_readl(reg_base + EXYNOS4_MCT_G_CNT_L);
- hi2 = __raw_readl(reg_base + EXYNOS4_MCT_G_CNT_U);
+ asm volatile("ldmia %2, {%0, %1}"
+ : "=r" (lo), "=r" (hi2)
+ : "r" (reg_base + EXYNOS4_MCT_G_CNT_L));
} while (hi != hi2);
return ((cycle_t)hi << 32) | lo;
--
2.0.0.526.g5318336
next prev parent reply other threads:[~2014-06-04 17:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 17:30 [PATCH 1/3] clocksource: exynos_mct: Fix ftrace Doug Anderson
2014-06-04 17:30 ` [PATCH 2/3] clocksource: exynos_mct: cache mct upper count Doug Anderson
2014-06-05 7:55 ` Vincent Guittot
2014-06-05 17:14 ` Doug Anderson
2014-06-04 17:30 ` Doug Anderson [this message]
2014-06-04 18:05 ` [PATCH 3/3] clocksource: exynos_mct: Optimize register reads with ldmia Thomas Gleixner
2014-06-04 18:49 ` Doug Anderson
2014-06-05 11:18 ` Tomasz Figa
2014-06-05 18:21 ` Doug Anderson
2014-06-12 16:53 ` Doug Anderson
2014-06-15 21:18 ` [PATCH 1/3] clocksource: exynos_mct: Fix ftrace Daniel Lezcano
2014-06-16 4:40 ` Doug Anderson
2014-06-16 8:52 ` Daniel Lezcano
2014-06-16 16:35 ` Doug Anderson
2014-06-17 12:13 ` Daniel Lezcano
2014-06-19 17:07 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401903034-20074-3-git-send-email-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).