From: denis@eukrea.com (Denis Carikli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 03/10] imx-drm: Correct BGR666 and the board's dts that use them.
Date: Mon, 16 Jun 2014 12:11:17 +0200 [thread overview]
Message-ID: <1402913484-25910-3-git-send-email-denis@eukrea.com> (raw)
In-Reply-To: <1402913484-25910-1-git-send-email-denis@eukrea.com>
The current BGR666 is not consistent with the other color mapings like BGR24.
BGR666 should be in the same byte order than BGR24.
Signed-off-by: Denis Carikli <denis@eukrea.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
---
ChangeLog v13->v14:
- Rebased
ChangeLog v10->v13:
- Rebased
ChangeLog v9->v10:
- Rebased.
- Added Philipp Zabel's Ack.
- Included Lothar Wa?mann's suggestion about imx-ldb.c.
- Shortened the patch title
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
ChangeLog v7->v8:
- Shrinked even more the Cc list.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
- Remove people not concerned by this patch from the Cc list.
- Added a better explanation of the change.
ChangeLog v5:
- New patch.
---
arch/arm/boot/dts/imx51-apf51dev.dts | 2 +-
arch/arm/boot/dts/imx53-m53evk.dts | 2 +-
drivers/gpu/ipu-v3/ipu-dc.c | 4 ++--
drivers/staging/imx-drm/imx-ldb.c | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/imx51-apf51dev.dts b/arch/arm/boot/dts/imx51-apf51dev.dts
index c5a9a24..7b3851d 100644
--- a/arch/arm/boot/dts/imx51-apf51dev.dts
+++ b/arch/arm/boot/dts/imx51-apf51dev.dts
@@ -18,7 +18,7 @@
display at di1 {
compatible = "fsl,imx-parallel-display";
- interface-pix-fmt = "bgr666";
+ interface-pix-fmt = "rgb666";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ipu_disp1>;
diff --git a/arch/arm/boot/dts/imx53-m53evk.dts b/arch/arm/boot/dts/imx53-m53evk.dts
index d5d146a..4b036b4 100644
--- a/arch/arm/boot/dts/imx53-m53evk.dts
+++ b/arch/arm/boot/dts/imx53-m53evk.dts
@@ -24,7 +24,7 @@
soc {
display1: display at di1 {
compatible = "fsl,imx-parallel-display";
- interface-pix-fmt = "bgr666";
+ interface-pix-fmt = "rgb666";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ipu_disp1>;
diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c
index 100d410..9974d41 100644
--- a/drivers/gpu/ipu-v3/ipu-dc.c
+++ b/drivers/gpu/ipu-v3/ipu-dc.c
@@ -439,9 +439,9 @@ int ipu_dc_init(struct ipu_soc *ipu, struct device *dev,
/* bgr666 */
ipu_dc_map_clear(priv, IPU_DC_MAP_BGR666);
- ipu_dc_map_config(priv, IPU_DC_MAP_BGR666, 0, 5, 0xfc); /* blue */
+ ipu_dc_map_config(priv, IPU_DC_MAP_BGR666, 0, 17, 0xfc); /* blue */
ipu_dc_map_config(priv, IPU_DC_MAP_BGR666, 1, 11, 0xfc); /* green */
- ipu_dc_map_config(priv, IPU_DC_MAP_BGR666, 2, 17, 0xfc); /* red */
+ ipu_dc_map_config(priv, IPU_DC_MAP_BGR666, 2, 5, 0xfc); /* red */
/* lvds666 */
ipu_dc_map_clear(priv, IPU_DC_MAP_LVDS666);
diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c
index 7e3f019..5d22e40 100644
--- a/drivers/staging/imx-drm/imx-ldb.c
+++ b/drivers/staging/imx-drm/imx-ldb.c
@@ -188,11 +188,11 @@ static void imx_ldb_encoder_prepare(struct drm_encoder *encoder)
switch (imx_ldb_ch->chno) {
case 0:
pixel_fmt = (ldb->ldb_ctrl & LDB_DATA_WIDTH_CH0_24) ?
- V4L2_PIX_FMT_RGB24 : V4L2_PIX_FMT_BGR666;
+ V4L2_PIX_FMT_RGB24 : V4L2_PIX_FMT_RGB666;
break;
case 1:
pixel_fmt = (ldb->ldb_ctrl & LDB_DATA_WIDTH_CH1_24) ?
- V4L2_PIX_FMT_RGB24 : V4L2_PIX_FMT_BGR666;
+ V4L2_PIX_FMT_RGB24 : V4L2_PIX_FMT_RGB666;
break;
default:
dev_err(ldb->dev, "unable to config di%d panel format\n",
--
1.7.9.5
next prev parent reply other threads:[~2014-06-16 10:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 10:11 [PATCH v14 01/10] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format Denis Carikli
2014-06-16 10:11 ` [PATCH v14 02/10] imx-drm: Add RGB666 support for parallel display Denis Carikli
2014-06-16 10:15 ` Russell King - ARM Linux
2014-06-16 10:11 ` Denis Carikli [this message]
2014-06-16 10:15 ` [PATCH v14 03/10] imx-drm: Correct BGR666 and the board's dts that use them Russell King - ARM Linux
2014-06-16 10:11 ` [PATCH v14 04/10] imx-drm: use defines for clock polarity settings Denis Carikli
2014-06-24 15:13 ` Russell King - ARM Linux
2014-06-24 16:25 ` Denis Carikli
2014-06-24 16:35 ` Russell King - ARM Linux
2014-06-25 4:48 ` Sascha Hauer
2014-06-25 8:43 ` Russell King - ARM Linux
2014-06-25 9:46 ` Sascha Hauer
2014-06-25 9:44 ` Denis Carikli
2014-06-26 20:56 ` Russell King - ARM Linux
2014-06-27 14:17 ` [PATCH v14 updated] " Denis Carikli
2014-06-16 10:11 ` [PATCH v14 05/10] ARM: dts: imx5*, imx6*: correct display-timings nodes Denis Carikli
2014-06-24 15:01 ` Russell King - ARM Linux
2014-06-25 2:29 ` Shawn Guo
2014-06-16 10:11 ` [PATCH v14 06/10] drm: drm_display_mode: add signal polarity flags Denis Carikli
2014-06-24 14:57 ` Russell King - ARM Linux
2014-06-24 22:13 ` Thierry Reding
2014-06-16 10:11 ` [PATCH v14 07/10] imx-drm: Use drm_display_mode timings flags Denis Carikli
2014-06-25 9:20 ` Russell King - ARM Linux
2014-06-16 10:11 ` [PATCH v14 08/10] drm/panel: Add Eukrea mbimxsd51 displays Denis Carikli
2014-06-24 15:06 ` Russell King - ARM Linux
2014-06-24 19:52 ` Rob Herring
2014-06-24 21:56 ` Thierry Reding
2014-06-25 9:42 ` Denis Carikli
2014-06-24 21:49 ` Thierry Reding
2014-06-24 21:56 ` Eric Bénard
2014-06-24 22:04 ` Thierry Reding
2014-06-25 8:27 ` Denis Carikli
2014-06-16 10:11 ` [PATCH v14 09/10] ARM: dts: mbimx51sd: Add display support Denis Carikli
2014-06-16 12:29 ` Denis Carikli
2014-06-17 13:46 ` Denis Carikli
2014-06-16 10:11 ` [PATCH v14 10/10] ARM: dts: mbimx51sd: Add CMO-QVGA backlight support Denis Carikli
2014-06-16 10:14 ` [PATCH v14 01/10] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402913484-25910-3-git-send-email-denis@eukrea.com \
--to=denis@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).