From: zhangfei.gao@linaro.org (Zhangfei Gao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 2/2] ahci: remove AHCI_HFLAG_NO_FBS setting
Date: Wed, 18 Jun 2014 15:15:37 +0800 [thread overview]
Message-ID: <1403075737-19853-1-git-send-email-zhangfei.gao@linaro.org> (raw)
In-Reply-To: <1403067249-8021-3-git-send-email-zhangfei.gao@linaro.org>
AHCI_HFLAG can be set directly in dts.
For example
ahci:sata at f9900000 {
no-fbs;
no-ncq;
};
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
drivers/ata/ahci_platform.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index ebe505c17763..c29fa4a553f4 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -34,7 +34,6 @@ static int ahci_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct ahci_platform_data *pdata = dev_get_platdata(dev);
struct ahci_host_priv *hpriv;
- unsigned long hflags = 0;
int rc;
hpriv = ahci_platform_get_resources(pdev);
@@ -57,11 +56,7 @@ static int ahci_probe(struct platform_device *pdev)
goto disable_resources;
}
- if (of_device_is_compatible(dev->of_node, "hisilicon,hisi-ahci"))
- hflags |= AHCI_HFLAG_NO_FBS;
-
- rc = ahci_platform_init_host(pdev, hpriv, &ahci_port_info,
- hflags, 0, 0);
+ rc = ahci_platform_init_host(pdev, hpriv, &ahci_port_info, 0, 0, 0);
if (rc)
goto pdata_exit;
--
1.7.9.5
prev parent reply other threads:[~2014-06-18 7:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <xuwei5@hisilicon.com, kefeng.wang@linaro.org,>
2014-06-18 4:54 ` [PATCH 0/2] add ahci_platform_get_of_property Zhangfei Gao
2014-06-18 4:54 ` [PATCH RFC 1/2] libahci_platform: " Zhangfei Gao
2014-06-18 7:37 ` Lothar Waßmann
2014-06-19 2:23 ` zhangfei
2014-06-18 14:03 ` Mark Rutland
2014-06-19 2:22 ` zhangfei
2014-06-19 7:39 ` Hans de Goede
2014-06-20 5:56 ` zhangfei
2014-06-20 7:38 ` Hans de Goede
2014-06-18 4:54 ` [PATCH RFC 2/2] ahci: remove AHCI_HFLAG_NO_FBS setting Zhangfei Gao
2014-06-18 7:15 ` Zhangfei Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403075737-19853-1-git-send-email-zhangfei.gao@linaro.org \
--to=zhangfei.gao@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).