* [PATCH] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: unbreak esdhc.
@ 2014-06-18 12:56 Denis Carikli
2014-06-21 4:59 ` Shawn Guo
2014-06-21 7:12 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Denis Carikli @ 2014-06-18 12:56 UTC (permalink / raw)
To: linux-arm-kernel
The following commit:
89d7e5c mmc: sdhci-esdhc-imx: add runtime pm support
has the effect of also disabling the hardware card detect
in runtime pm.
We switch to GPIO based detection to avoid this issue.
This patch is based on:
ARM: dts: imx51-babbage: Fix esdhc setup
Signed-off-by: Denis Carikli <denis@eukrea.com>
---
.../boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
index 75e66c9..1d77381 100644
--- a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
+++ b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
@@ -108,6 +108,8 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_esdhc1 &pinctrl_esdhc1_cd>;
fsl,cd-controller;
+ cd-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
+
status = "okay";
};
@@ -206,7 +208,7 @@
pinctrl_esdhc1_cd: esdhc1_cd {
fsl,pins = <
- MX51_PAD_GPIO1_0__SD1_CD 0x20d5
+ MX51_PAD_GPIO1_0__GPIO1_0 0xd5
>;
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: unbreak esdhc.
2014-06-18 12:56 [PATCH] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: unbreak esdhc Denis Carikli
@ 2014-06-21 4:59 ` Shawn Guo
2014-06-21 7:12 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2014-06-21 4:59 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 18, 2014 at 02:56:56PM +0200, Denis Carikli wrote:
> The following commit:
> 89d7e5c mmc: sdhci-esdhc-imx: add runtime pm support
> has the effect of also disabling the hardware card detect
> in runtime pm.
>
> We switch to GPIO based detection to avoid this issue.
>
> This patch is based on:
> ARM: dts: imx51-babbage: Fix esdhc setup
>
> Signed-off-by: Denis Carikli <denis@eukrea.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: unbreak esdhc.
2014-06-18 12:56 [PATCH] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: unbreak esdhc Denis Carikli
2014-06-21 4:59 ` Shawn Guo
@ 2014-06-21 7:12 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2014-06-21 7:12 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 18, 2014 at 02:56:56PM +0200, Denis Carikli wrote:
> The following commit:
> 89d7e5c mmc: sdhci-esdhc-imx: add runtime pm support
> has the effect of also disabling the hardware card detect
> in runtime pm.
>
> We switch to GPIO based detection to avoid this issue.
>
> This patch is based on:
> ARM: dts: imx51-babbage: Fix esdhc setup
>
> Signed-off-by: Denis Carikli <denis@eukrea.com>
> ---
> .../boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
> index 75e66c9..1d77381 100644
> --- a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
> +++ b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
> @@ -108,6 +108,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_esdhc1 &pinctrl_esdhc1_cd>;
> fsl,cd-controller;
The property should be dropped now.
> + cd-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
> +
This new line is not really necessary.
I fixed them up when applying.
Shawn
> status = "okay";
> };
>
> @@ -206,7 +208,7 @@
>
> pinctrl_esdhc1_cd: esdhc1_cd {
> fsl,pins = <
> - MX51_PAD_GPIO1_0__SD1_CD 0x20d5
> + MX51_PAD_GPIO1_0__GPIO1_0 0xd5
> >;
> };
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-21 7:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 12:56 [PATCH] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: unbreak esdhc Denis Carikli
2014-06-21 4:59 ` Shawn Guo
2014-06-21 7:12 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).