linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: msalter@redhat.com (Mark Salter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: export __cpu_{clear,copy}_user_page functions
Date: Wed, 18 Jun 2014 09:54:03 -0400	[thread overview]
Message-ID: <1403099643.32688.30.camel@deneb.redhat.com> (raw)
In-Reply-To: <20140618103954.GC14680@arm.com>

On Wed, 2014-06-18 at 11:39 +0100, Catalin Marinas wrote:
> On Tue, Jun 17, 2014 at 06:14:26PM +0100, Mark Salter wrote:
> > The __cpu_clear_user_page() and __cpu_copy_user_page() functions
> > are not currently exported. This prevents modules from using
> > clear_user_page() and opy_user_page().
> > 
> > Signed-off-by: Mark Salter <msalter@redhat.com>
> > ---
> >  arch/arm64/mm/copypage.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/mm/copypage.c b/arch/arm64/mm/copypage.c
> > index 9aecbac..13bbc3be 100644
> > --- a/arch/arm64/mm/copypage.c
> > +++ b/arch/arm64/mm/copypage.c
> > @@ -27,8 +27,10 @@ void __cpu_copy_user_page(void *kto, const void *kfrom, unsigned long vaddr)
> >  	copy_page(kto, kfrom);
> >  	__flush_dcache_area(kto, PAGE_SIZE);
> >  }
> > +EXPORT_SYMBOL_GPL(__cpu_copy_user_page);
> >  
> >  void __cpu_clear_user_page(void *kaddr, unsigned long vaddr)
> >  {
> >  	clear_page(kaddr);
> >  }
> > +EXPORT_SYMBOL_GPL(__cpu_clear_user_page);
> 
> I wonder why we still have these functions. I don't think we need any
> D-cache flushing for copy_user_page(), so we could simply remove this
> code and define copy_user_page() as copy_page() (similarly for
> clear_user_page). I'll post a patch separately removing the copy_page,
> copy_user_page etc. functions (now that we also have optimised memcpy
> and memset).
> 

Even better. I much prefer removing code than adding it. Thanks.

  reply	other threads:[~2014-06-18 13:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 17:14 [PATCH] arm64: export __cpu_{clear,copy}_user_page functions Mark Salter
2014-06-18 10:39 ` Catalin Marinas
2014-06-18 13:54   ` Mark Salter [this message]
2014-06-23 11:31     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403099643.32688.30.camel@deneb.redhat.com \
    --to=msalter@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).