From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: i.MX25: Fix gpt4 timer per clock.
Date: Sat, 21 Jun 2014 10:53:28 +0400 [thread overview]
Message-ID: <1403333608.195368957@f298.i.mail.ru> (raw)
In-Reply-To: <20140621063632.GE6818@dragon>
Sat, 21 Jun 2014 14:36:34 +0800 ?? Shawn Guo <shawn.guo@linaro.org>:
> + Alexander
>
> On Fri, Jun 13, 2014 at 02:55:45PM +0200, Denis Carikli wrote:
> > Without that fix, the board freeze during boot.
> >
> > This appeared after the following commit:
> > 496f065 ARM: i.MX: Use of_clk_get_by_name() for timer clocks for DT case.
> >
> > Signed-off-by: Denis Carikli <denis@eukrea.com>
> > ---
> > arch/arm/boot/dts/imx25.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> > index bb74d95..98783f5 100644
> > --- a/arch/arm/boot/dts/imx25.dtsi
> > +++ b/arch/arm/boot/dts/imx25.dtsi
> > @@ -312,7 +312,7 @@
> > gpt4: timer at 53f84000 {
> > compatible = "fsl,imx25-gpt", "fsl,imx31-gpt";
> > reg = <0x53f84000 0x4000>;
> > - clocks = <&clks 9>, <&clks 45>;
> > + clocks = <&clks 9>, <&clks 47>;
>
> So this changes the clock from esdhc1_ipg_per to gpt_ipg_per. It looks
> to me this is a bug fix on its own. I need some help to understand why
> the bug is only seen after Alexander's of_clk_get_by_name() patch.
Clk45 points to esdhc1_ipg_per.
Both (DT and non-DT cases) define clocks for GPT as:
clk_register_clkdev(clk[ipg], "ipg", "imx-gpt.0");
clk_register_clkdev(clk[gpt_ipg_per], "per", "imx-gpt.0");
ie to valid clocks.
Nevertheless, the definition is still not correct. I think that should be so:
clocks = <&clks 92>, <&clks 47>;
and
clk_register_clkdev(clk[gpt1_ipg], "ipg", "imx-gpt.0");
clk_register_clkdev(clk[gpt_ipg_per], "per", "imx-gpt.0");
---
next prev parent reply other threads:[~2014-06-21 6:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 12:55 [PATCH 1/2] ARM: dts: i.MX25: Fix gpt4 timer per clock Denis Carikli
2014-06-13 12:55 ` [PATCH 2/2] ARM: i.MX25 clk: Use of_clk_init() for DT case Denis Carikli
2014-06-21 6:51 ` Shawn Guo
2014-06-21 6:36 ` [PATCH 1/2] ARM: dts: i.MX25: Fix gpt4 timer per clock Shawn Guo
2014-06-21 6:53 ` Alexander Shiyan [this message]
2014-06-21 6:57 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403333608.195368957@f298.i.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).