From: denis@eukrea.com (Denis Carikli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] video: imxfb: Fix unbalanced regulators
Date: Mon, 23 Jun 2014 15:07:18 +0200 [thread overview]
Message-ID: <1403528839-31901-1-git-send-email-denis@eukrea.com> (raw)
Both regulator_enable and regulator_disable's comments
say that they must be balanced with its counterpart
enable/disable function.
Not doing it result in kernel warnings each time
the lcd is powered off twice, for instance trough sysfs.
Signed-off-by: Denis Carikli <denis@eukrea.com>
---
Changelog v1->v2:
- None
---
drivers/video/fbdev/imxfb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index f6e6216..121cbd7 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -769,9 +769,9 @@ static int imxfb_lcd_set_power(struct lcd_device *lcddev, int power)
struct imxfb_info *fbi = dev_get_drvdata(&lcddev->dev);
if (!IS_ERR(fbi->lcd_pwr)) {
- if (power)
+ if (power && !regulator_is_enabled(fbi->lcd_pwr))
return regulator_enable(fbi->lcd_pwr);
- else
+ else if (regulator_is_enabled(fbi->lcd_pwr))
return regulator_disable(fbi->lcd_pwr);
}
--
1.7.9.5
next reply other threads:[~2014-06-23 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 13:07 Denis Carikli [this message]
2014-06-23 13:07 ` [PATCH v2 2/2] video: imxfb: Fix lcd_ops .set_power and .get_power on/off inversion Denis Carikli
2014-06-25 6:16 ` Sascha Hauer
2014-06-25 12:57 ` Denis Carikli
2014-06-25 6:08 ` [PATCH v2 1/2] video: imxfb: Fix unbalanced regulators Sascha Hauer
2014-06-25 8:51 ` Denis Carikli
2014-06-25 8:58 ` Denis Carikli
2014-06-25 9:33 ` Sascha Hauer
2014-06-25 6:17 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403528839-31901-1-git-send-email-denis@eukrea.com \
--to=denis@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).