From: msalter@redhat.com (Mark Salter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.
Date: Wed, 25 Jun 2014 12:40:45 -0400 [thread overview]
Message-ID: <1403714445.755.112.camel@deneb.redhat.com> (raw)
In-Reply-To: <CALdTtnvHt5mYMC3619E4F3KK0jPOw7mCpKE6bTn0Um6fdZ4rbw@mail.gmail.com>
On Tue, 2014-06-24 at 22:29 -0600, Dann Frazier wrote:
> On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian
> > + ring->desc_addr = dma_zalloc_coherent(dev, size, &ring->dma,
> > + GFP_KERNEL);
>
> Iyappan,
> When testing this driver on a 3.16-rc2 base, I'm finding that
> desc_addr gets assigned to NULL here, which results in an oops later
> on (see below).
>
> I wasn't seeing this before (3.15 base), so I'm guessing something
> changed upstream, or in my config, to change this behavior. But it
> does illuminate a place where we could maybe use some better error
> handling (also see below).
https://lkml.org/lkml/2014/6/23/10
next prev parent reply other threads:[~2014-06-25 16:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 23:18 [PATCH v8 0/4] net: Add APM X-Gene SoC Ethernet driver support Iyappan Subramanian
2014-06-20 23:18 ` [PATCH v8 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver Iyappan Subramanian
2014-06-20 23:18 ` [PATCH v8 2/4] Documentation: dts: Add bindings " Iyappan Subramanian
2014-06-20 23:18 ` [PATCH v8 3/4] " Iyappan Subramanian
2014-06-20 23:18 ` [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support Iyappan Subramanian
2014-06-25 4:29 ` Dann Frazier
2014-06-25 16:40 ` Mark Salter [this message]
2014-06-25 23:04 ` Russell King - ARM Linux
2014-07-09 22:39 ` Iyappan Subramanian
2014-06-25 5:34 ` David Miller
2014-07-09 22:38 ` Iyappan Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403714445.755.112.camel@deneb.redhat.com \
--to=msalter@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).