From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] PCI: pci-imx6: Add delay to workaround kernel hang
Date: Thu, 26 Jun 2014 10:41:25 +0200 [thread overview]
Message-ID: <1403772085.4254.1.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <1403637507-9424-1-git-send-email-festevam@gmail.com>
Hi Fabio,
Am Dienstag, den 24.06.2014, 16:18 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> When the mx6 PCI conctroller is initialized in the bootloader we see a kernel
> hang inside imx6_add_pcie_port().
>
> Adding a 30ms delay allows the kernel to boot.
>
> Suggested-by: David M?ller <d.mueller@elsoft.ch>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> I am happy to get feedback on how to properly fix this.
>
> Thanks
>
> drivers/pci/host/pci-imx6.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index a568efa..669f771 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -507,6 +507,8 @@ static int __init imx6_add_pcie_port(struct pcie_port *pp,
> pp->root_bus_nr = -1;
> pp->ops = &imx6_pcie_host_ops;
>
> + usleep_range(25000, 30000);
> +
> ret = dw_pcie_host_init(pp);
> if (ret) {
> dev_err(&pdev->dev, "failed to initialize host\n");
I would suspect the issue to be somewhere in imx6_pcie_host_init(). Can
you move the delay there (and to different positions in this function)
to narrow down where the hang happens?
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-06-26 8:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 19:18 [RFC] PCI: pci-imx6: Add delay to workaround kernel hang Fabio Estevam
2014-06-25 21:28 ` Marek Vasut
2014-06-26 3:12 ` Shawn Guo
2014-06-26 3:43 ` Fabio Estevam
2014-06-26 5:49 ` Shawn Guo
2014-06-26 9:13 ` Marek Vasut
2014-06-27 0:29 ` Tim Harvey
2014-06-27 10:06 ` Hong-Xing.Zhu at freescale.com
2014-07-17 0:28 ` Tim Harvey
2014-07-18 9:26 ` Lucas Stach
2014-07-18 9:44 ` Marek Vasut
2014-07-18 11:44 ` "David Müller (ELSOFT AG)"
2014-06-26 7:32 ` Juergen Borleis
2014-06-26 9:17 ` Marek Vasut
2014-06-26 9:26 ` Juergen Borleis
2014-06-26 9:50 ` Marek Vasut
2014-06-26 11:43 ` Fabio Estevam
2014-06-26 8:41 ` Lucas Stach [this message]
2014-07-17 6:51 ` Uwe Kleine-König
2014-07-17 8:23 ` Marek Vasut
2014-07-17 15:27 ` Shawn Guo
2014-07-18 20:46 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403772085.4254.1.camel@weser.hi.pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).