* [PATCH 1/1] drivers/mfd/ab8500-debugfs.c: remove unnecessary null test before debugfs_remove_recursive
@ 2014-06-28 11:58 Fabian Frederick
2014-07-02 6:50 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-28 11:58 UTC (permalink / raw)
To: linux-arm-kernel
Fix checkpatch warning:
WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/mfd/ab8500-debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index d1a22aa..7ca8713 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -3192,8 +3192,7 @@ static int ab8500_debug_probe(struct platform_device *plf)
return 0;
err:
- if (ab8500_dir)
- debugfs_remove_recursive(ab8500_dir);
+ debugfs_remove_recursive(ab8500_dir);
dev_err(&plf->dev, "failed to create debugfs entries.\n");
return -ENOMEM;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 1/1] drivers/mfd/ab8500-debugfs.c: remove unnecessary null test before debugfs_remove_recursive
2014-06-28 11:58 [PATCH 1/1] drivers/mfd/ab8500-debugfs.c: remove unnecessary null test before debugfs_remove_recursive Fabian Frederick
@ 2014-07-02 6:50 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2014-07-02 6:50 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 28 Jun 2014, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/mfd/ab8500-debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
> index d1a22aa..7ca8713 100644
> --- a/drivers/mfd/ab8500-debugfs.c
> +++ b/drivers/mfd/ab8500-debugfs.c
> @@ -3192,8 +3192,7 @@ static int ab8500_debug_probe(struct platform_device *plf)
> return 0;
>
> err:
> - if (ab8500_dir)
> - debugfs_remove_recursive(ab8500_dir);
> + debugfs_remove_recursive(ab8500_dir);
> dev_err(&plf->dev, "failed to create debugfs entries.\n");
>
> return -ENOMEM;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-02 6:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-28 11:58 [PATCH 1/1] drivers/mfd/ab8500-debugfs.c: remove unnecessary null test before debugfs_remove_recursive Fabian Frederick
2014-07-02 6:50 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).