[PATCH 1/6] ARM: s3c24xx: Remove S3C24XX_DMA dependency from S3C2410

linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/6] ARM: s3c24xx: Remove S3C24XX_DMA dependency from S3C2410_DMA
@ 2014-06-30 19:20 Vasily Khoruzhick
  2014-06-30 19:20 ` [PATCH 2/6] ARM: s3c24xx: add dma_coherent_mask for DMA devices Vasily Khoruzhick
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Vasily Khoruzhick @ 2014-06-30 19:20 UTC (permalink / raw)
  To: linux-arm-kernel

S3C24XX_DMA enables legacy DMA driver, and since we want to
move to introduced generic dmaengine s3c24xx-dma driver,
it's necessary to remove this redundant dependency.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 arch/arm/mach-s3c24xx/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index 04284de..8c2a7f3 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -133,7 +133,6 @@ config S3C2410_DMA_DEBUG
 
 config S3C2410_DMA
 	bool
-	depends on S3C24XX_DMA && (CPU_S3C2410 || CPU_S3C2442)
 	help
 	  DMA device selection for S3C2410 and compatible CPUs
 
-- 
2.0.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/6] ARM: s3c24xx: add dma_coherent_mask for DMA devices
  2014-06-30 19:20 [PATCH 1/6] ARM: s3c24xx: Remove S3C24XX_DMA dependency from S3C2410_DMA Vasily Khoruzhick
@ 2014-06-30 19:20 ` Vasily Khoruzhick
  2014-06-30 19:20 ` [PATCH 3/6] ARM: s3c24xx: h1940: Add DMA device Vasily Khoruzhick
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Vasily Khoruzhick @ 2014-06-30 19:20 UTC (permalink / raw)
  To: linux-arm-kernel

Otherwise dma_alloc_coherent() fails.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 arch/arm/mach-s3c24xx/common.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
index c0763b8..2fa0a99 100644
--- a/arch/arm/mach-s3c24xx/common.c
+++ b/arch/arm/mach-s3c24xx/common.c
@@ -358,6 +358,7 @@ struct platform_device s3c2410_device_dma = {
 	.resource	= s3c2410_dma_resource,
 	.dev	= {
 		.platform_data	= &s3c2410_dma_platdata,
+		.coherent_dma_mask = ~0,
 	},
 };
 #endif
@@ -455,6 +456,7 @@ struct platform_device s3c2440_device_dma = {
 	.resource	= s3c2410_dma_resource,
 	.dev	= {
 		.platform_data	= &s3c2440_dma_platdata,
+		.coherent_dma_mask = ~0,
 	},
 };
 #endif
-- 
2.0.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/6] ARM: s3c24xx: h1940: Add DMA device
  2014-06-30 19:20 [PATCH 1/6] ARM: s3c24xx: Remove S3C24XX_DMA dependency from S3C2410_DMA Vasily Khoruzhick
  2014-06-30 19:20 ` [PATCH 2/6] ARM: s3c24xx: add dma_coherent_mask for DMA devices Vasily Khoruzhick
@ 2014-06-30 19:20 ` Vasily Khoruzhick
  2014-06-30 19:20 ` [PATCH 4/6] ARM: s3c24xx: DMA: SDI channel requires handshake Vasily Khoruzhick
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Vasily Khoruzhick @ 2014-06-30 19:20 UTC (permalink / raw)
  To: linux-arm-kernel

Add a corresponding device for a new dmaengine driver.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 arch/arm/mach-s3c24xx/mach-h1940.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c
index fbf5487..cf36f26 100644
--- a/arch/arm/mach-s3c24xx/mach-h1940.c
+++ b/arch/arm/mach-s3c24xx/mach-h1940.c
@@ -623,6 +623,7 @@ static struct platform_device h1940_dev_buttons = {
 
 static struct platform_device *h1940_devices[] __initdata = {
 	&h1940_dev_buttons,
+	&s3c2410_device_dma,
 	&s3c_device_ohci,
 	&s3c_device_lcd,
 	&s3c_device_wdt,
-- 
2.0.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/6] ARM: s3c24xx: DMA: SDI channel requires handshake
  2014-06-30 19:20 [PATCH 1/6] ARM: s3c24xx: Remove S3C24XX_DMA dependency from S3C2410_DMA Vasily Khoruzhick
  2014-06-30 19:20 ` [PATCH 2/6] ARM: s3c24xx: add dma_coherent_mask for DMA devices Vasily Khoruzhick
  2014-06-30 19:20 ` [PATCH 3/6] ARM: s3c24xx: h1940: Add DMA device Vasily Khoruzhick
@ 2014-06-30 19:20 ` Vasily Khoruzhick
  2014-06-30 19:20 ` [PATCH 5/6] ARM: s3c24xx: Kconfig: Fix unmet dependency on S3C2440_PLL_* symbols for S3C2442 Vasily Khoruzhick
  2014-06-30 19:20 ` [PATCH 6/6] ARM: s3c24xx: RX1950: Add DMA device Vasily Khoruzhick
  4 siblings, 0 replies; 6+ messages in thread
From: Vasily Khoruzhick @ 2014-06-30 19:20 UTC (permalink / raw)
  To: linux-arm-kernel

At least Windows Mobile driver enables it.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 arch/arm/mach-s3c24xx/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
index 2fa0a99..e505114 100644
--- a/arch/arm/mach-s3c24xx/common.c
+++ b/arch/arm/mach-s3c24xx/common.c
@@ -322,7 +322,7 @@ static struct resource s3c2410_dma_resource[] = {
 static struct s3c24xx_dma_channel s3c2410_dma_channels[DMACH_MAX] = {
 	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 0), },
 	[DMACH_XD1] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 1), },
-	[DMACH_SDI] = { S3C24XX_DMA_APB, false, S3C24XX_DMA_CHANREQ(2, 0) |
+	[DMACH_SDI] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 0) |
 						S3C24XX_DMA_CHANREQ(2, 2) |
 						S3C24XX_DMA_CHANREQ(1, 3),
 	},
-- 
2.0.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 5/6] ARM: s3c24xx: Kconfig: Fix unmet dependency on S3C2440_PLL_* symbols for S3C2442
  2014-06-30 19:20 [PATCH 1/6] ARM: s3c24xx: Remove S3C24XX_DMA dependency from S3C2410_DMA Vasily Khoruzhick
                   ` (2 preceding siblings ...)
  2014-06-30 19:20 ` [PATCH 4/6] ARM: s3c24xx: DMA: SDI channel requires handshake Vasily Khoruzhick
@ 2014-06-30 19:20 ` Vasily Khoruzhick
  2014-06-30 19:20 ` [PATCH 6/6] ARM: s3c24xx: RX1950: Add DMA device Vasily Khoruzhick
  4 siblings, 0 replies; 6+ messages in thread
From: Vasily Khoruzhick @ 2014-06-30 19:20 UTC (permalink / raw)
  To: linux-arm-kernel

It's possible to build kernel with S3C2442, but without S3C2440 support, and
some S3C2442 machines depend on CONFIG_S3C2440_PLL_16934400

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 arch/arm/mach-s3c24xx/Kconfig | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index 8c2a7f3..2305a5f 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -437,12 +437,7 @@ config MACH_S3C2416_DT
 
 endif	# CPU_S3C2416
 
-if CPU_S3C2440
-
-config S3C2440_DMA
-	bool
-	help
-	  Support for S3C2440 specific DMA code5A
+if CPU_S3C2440 || CPU_S3C2442
 
 config S3C2440_XTAL_12000000
 	bool
@@ -469,6 +464,14 @@ config S3C2440_PLL_16934400
 	default y if S3C24XX_PLL
 	help
 	  PLL tables for S3C2440 or S3C2442 CPUs with 16.934MHz crystals.
+endif
+
+if CPU_S3C2440
+
+config S3C2440_DMA
+	bool
+	help
+	  Support for S3C2440 specific DMA code5A
 
 comment "S3C2440 Boards"
 
-- 
2.0.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 6/6] ARM: s3c24xx: RX1950: Add DMA device
  2014-06-30 19:20 [PATCH 1/6] ARM: s3c24xx: Remove S3C24XX_DMA dependency from S3C2410_DMA Vasily Khoruzhick
                   ` (3 preceding siblings ...)
  2014-06-30 19:20 ` [PATCH 5/6] ARM: s3c24xx: Kconfig: Fix unmet dependency on S3C2440_PLL_* symbols for S3C2442 Vasily Khoruzhick
@ 2014-06-30 19:20 ` Vasily Khoruzhick
  4 siblings, 0 replies; 6+ messages in thread
From: Vasily Khoruzhick @ 2014-06-30 19:20 UTC (permalink / raw)
  To: linux-arm-kernel

Add a corresponding device for a new dmaengine driver.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 arch/arm/mach-s3c24xx/mach-rx1950.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-s3c24xx/mach-rx1950.c b/arch/arm/mach-s3c24xx/mach-rx1950.c
index e2c6541..95b88a6 100644
--- a/arch/arm/mach-s3c24xx/mach-rx1950.c
+++ b/arch/arm/mach-s3c24xx/mach-rx1950.c
@@ -710,6 +710,7 @@ static struct i2c_board_info rx1950_i2c_devices[] = {
 
 static struct platform_device *rx1950_devices[] __initdata = {
 	&s3c2410_device_dclk,
+	&s3c2410_device_dma,
 	&s3c_device_lcd,
 	&s3c_device_wdt,
 	&s3c_device_i2c0,
-- 
2.0.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-06-30 19:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-30 19:20 [PATCH 1/6] ARM: s3c24xx: Remove S3C24XX_DMA dependency from S3C2410_DMA Vasily Khoruzhick
2014-06-30 19:20 ` [PATCH 2/6] ARM: s3c24xx: add dma_coherent_mask for DMA devices Vasily Khoruzhick
2014-06-30 19:20 ` [PATCH 3/6] ARM: s3c24xx: h1940: Add DMA device Vasily Khoruzhick
2014-06-30 19:20 ` [PATCH 4/6] ARM: s3c24xx: DMA: SDI channel requires handshake Vasily Khoruzhick
2014-06-30 19:20 ` [PATCH 5/6] ARM: s3c24xx: Kconfig: Fix unmet dependency on S3C2440_PLL_* symbols for S3C2442 Vasily Khoruzhick
2014-06-30 19:20 ` [PATCH 6/6] ARM: s3c24xx: RX1950: Add DMA device Vasily Khoruzhick

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).