From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/12] mfd: 88pm805: msleep(1ms ~ 20ms) may not do what the caller intends
Date: Wed, 2 Jul 2014 16:28:39 +0100 [thread overview]
Message-ID: <1404314924-23564-8-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1404314924-23564-1-git-send-email-lee.jones@linaro.org>
This code has been working since 2012, as limiting the time between
1ms and 3ms is unlikely to do any harm.
Soothes checkpatch warning:
WARNING: msleep < 20ms can sleep for up to 20ms;
see Documentation/timers/timers-howto.txt
#161: FILE: drivers/mfd/88pm805.c:161:
+ msleep(1);
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/88pm805.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/88pm805.c b/drivers/mfd/88pm805.c
index 64751c2..e9d5064 100644
--- a/drivers/mfd/88pm805.c
+++ b/drivers/mfd/88pm805.c
@@ -158,7 +158,7 @@ static int device_irq_init_805(struct pm80x_chip *chip)
* PM805_INT_STATUS is under 32K clock domain, so need to
* add proper delay before the next I2C register access.
*/
- msleep(1);
+ usleep_range(1000, 3000);
if (ret < 0)
goto out;
--
1.8.3.2
next prev parent reply other threads:[~2014-07-02 15:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 15:28 [PATCH 01/12] mfd: Bunch of clean-ups and checkpatch fixes Lee Jones
2014-07-02 15:28 ` [PATCH 01/12] mfd: ab8500-core: Remove pointless else in if statement Lee Jones
2014-07-04 19:54 ` Linus Walleij
2014-07-02 15:28 ` [PATCH 02/12] mfd: ab8500-debugfs: Simplify invalid debugfs data checking Lee Jones
2014-07-04 19:55 ` Linus Walleij
2014-07-02 15:28 ` [PATCH 03/12] mfd: intel_soc_pmic: Rid compiler working for unused ACPI match table Lee Jones
2014-07-02 15:28 ` [PATCH 04/12] mfd: stmpe: Rid data size incompatibility warn when building for 64bit Lee Jones
2014-07-04 19:57 ` Linus Walleij
2014-07-02 15:28 ` [PATCH 05/12] mfd: arizona: " Lee Jones
2014-07-02 15:28 ` [PATCH 06/12] mfd: tps65910: " Lee Jones
2014-07-02 15:28 ` Lee Jones [this message]
2014-07-02 15:28 ` [PATCH 08/12] mfd: 88pm860x-core: Repair formatting issues Lee Jones
2014-07-02 15:28 ` [PATCH 09/12] mfd: 88pm860x-i2c: Repair 'space before tab' warning Lee Jones
2014-07-02 15:28 ` [PATCH 10/12] mfd: aat2870-core: Stop using obsolte simple_strtoul() Lee Jones
2014-07-02 15:28 ` [PATCH 11/12] mfd: ab3100-core: Correct code sytle problems Lee Jones
2014-07-04 19:58 ` Linus Walleij
2014-07-07 12:50 ` Lee Jones
2014-07-02 15:28 ` [PATCH 12/12] mfd: ab8500-core: Resolve code style issues Lee Jones
2014-07-04 19:58 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404314924-23564-8-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).