* [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
@ 2014-07-04 6:46 Shawn Guo
2014-07-04 6:58 ` Yibin Gong
2014-07-04 13:53 ` Fabio Estevam
0 siblings, 2 replies; 6+ messages in thread
From: Shawn Guo @ 2014-07-04 6:46 UTC (permalink / raw)
To: linux-arm-kernel
The SDMA on imx6sl and imx6sx is more compatible with imx6q one than
imx35. Let's use "fsl,imx6q-sdma" instead of "fsl,imx35-sdma", so that
SDMA ROM script on imx6sl and imx6sx can work for audio driver just like
the case of imx6q.
Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
---
Thanks to Robin for finding this out.
arch/arm/boot/dts/imx6sl.dtsi | 2 +-
arch/arm/boot/dts/imx6sx.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index c0ee12f1f171..0467ac064e9d 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -608,7 +608,7 @@
};
sdma: sdma at 020ec000 {
- compatible = "fsl,imx6sl-sdma", "fsl,imx35-sdma";
+ compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma";
reg = <0x020ec000 0x4000>;
interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_SDMA>,
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 92d48becdb45..0c5094adedfa 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -706,7 +706,7 @@
};
sdma: sdma at 020ec000 {
- compatible = "fsl,imx6sx-sdma", "fsl,imx35-sdma";
+ compatible = "fsl,imx6sx-sdma", "fsl,imx6q-sdma";
reg = <0x020ec000 0x4000>;
interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SX_CLK_SDMA>,
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
2014-07-04 6:46 [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx Shawn Guo
@ 2014-07-04 6:58 ` Yibin Gong
2014-07-04 13:53 ` Fabio Estevam
1 sibling, 0 replies; 6+ messages in thread
From: Yibin Gong @ 2014-07-04 6:58 UTC (permalink / raw)
To: linux-arm-kernel
Acked-by: Robin Gong <yibin.gong@freescale.com>
-----Original Message-----
From: Shawn Guo [mailto:shawn.guo at freescale.com]
Sent: Friday, July 04, 2014 2:46 PM
To: linux-arm-kernel at lists.infradead.org
Cc: Gong Yibin-B38343; Estevam Fabio-R49496; Guo Shawn-R65073
Subject: [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
The SDMA on imx6sl and imx6sx is more compatible with imx6q one than imx35. Let's use "fsl,imx6q-sdma" instead of "fsl,imx35-sdma", so that SDMA ROM script on imx6sl and imx6sx can work for audio driver just like the case of imx6q.
Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
---
Thanks to Robin for finding this out.
arch/arm/boot/dts/imx6sl.dtsi | 2 +-
arch/arm/boot/dts/imx6sx.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index c0ee12f1f171..0467ac064e9d 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -608,7 +608,7 @@
};
sdma: sdma at 020ec000 {
- compatible = "fsl,imx6sl-sdma", "fsl,imx35-sdma";
+ compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma";
reg = <0x020ec000 0x4000>;
interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_SDMA>,
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index 92d48becdb45..0c5094adedfa 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -706,7 +706,7 @@
};
sdma: sdma at 020ec000 {
- compatible = "fsl,imx6sx-sdma", "fsl,imx35-sdma";
+ compatible = "fsl,imx6sx-sdma", "fsl,imx6q-sdma";
reg = <0x020ec000 0x4000>;
interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SX_CLK_SDMA>,
--
1.8.3.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
2014-07-04 6:46 [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx Shawn Guo
2014-07-04 6:58 ` Yibin Gong
@ 2014-07-04 13:53 ` Fabio Estevam
2014-07-04 14:55 ` Shawn Guo
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2014-07-04 13:53 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 4, 2014 at 3:46 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
> The SDMA on imx6sl and imx6sx is more compatible with imx6q one than
> imx35. Let's use "fsl,imx6q-sdma" instead of "fsl,imx35-sdma", so that
> SDMA ROM script on imx6sl and imx6sx can work for audio driver just like
> the case of imx6q.
>
> Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> ---
> Thanks to Robin for finding this out.
Very good! Now I can play audio on mx6sl and mx6sx without the need of
loading the external SDMA firmware.
However, I still have a question: wouldn't it be better to describe
the compatible string as:
compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma", "fsl,imx35-sdma"; ?
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
2014-07-04 13:53 ` Fabio Estevam
@ 2014-07-04 14:55 ` Shawn Guo
2014-07-04 15:47 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2014-07-04 14:55 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 04, 2014 at 10:53:39AM -0300, Fabio Estevam wrote:
> On Fri, Jul 4, 2014 at 3:46 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
> > The SDMA on imx6sl and imx6sx is more compatible with imx6q one than
> > imx35. Let's use "fsl,imx6q-sdma" instead of "fsl,imx35-sdma", so that
> > SDMA ROM script on imx6sl and imx6sx can work for audio driver just like
> > the case of imx6q.
> >
> > Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
> > Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> > ---
> > Thanks to Robin for finding this out.
>
> Very good! Now I can play audio on mx6sl and mx6sx without the need of
> loading the external SDMA firmware.
>
> However, I still have a question: wouldn't it be better to describe
> the compatible string as:
> compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma", "fsl,imx35-sdma"; ?
No, it wouldn't be better or necessary.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
2014-07-04 14:55 ` Shawn Guo
@ 2014-07-04 15:47 ` Fabio Estevam
2014-07-07 5:29 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2014-07-04 15:47 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 4, 2014 at 11:55 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
>> However, I still have a question: wouldn't it be better to describe
>> the compatible string as:
>> compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma", "fsl,imx35-sdma"; ?
>
> No, it wouldn't be better or necessary.
I have some trouble understanding when/if the three elements need to
be passed into the compatible string.
For example: on mx6sl ssi node:
ssi1: ssi at 02028000 {
compatible = "fsl,imx6sl-ssi",
"fsl,imx51-ssi",
"fsl,imx21-ssi";
However on mx6sx node we have:
ssi1: ssi at 02028000 {
compatible = "fsl,imx6sx-ssi", "fsl,imx21-ssi";
Which one is correct? Care to explain?
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
2014-07-04 15:47 ` Fabio Estevam
@ 2014-07-07 5:29 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2014-07-07 5:29 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 04, 2014 at 12:47:46PM -0300, Fabio Estevam wrote:
> On Fri, Jul 4, 2014 at 11:55 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
>
> >> However, I still have a question: wouldn't it be better to describe
> >> the compatible string as:
> >> compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma", "fsl,imx35-sdma"; ?
> >
> > No, it wouldn't be better or necessary.
>
> I have some trouble understanding when/if the three elements need to
> be passed into the compatible string.
>
> For example: on mx6sl ssi node:
>
> ssi1: ssi at 02028000 {
> compatible = "fsl,imx6sl-ssi",
> "fsl,imx51-ssi",
> "fsl,imx21-ssi";
I would say either one below is correct.
- compatible = "fsl,imx6sl-ssi", "fsl,imx51-ssi", "fsl,imx21-ssi";
- compatible = "fsl,imx6sl-ssi", "fsl,imx51-ssi";
But when commit 98ea6ad2edd2 (ARM: dts: imx6: use imx51-ssi) updates the
compatible, it might be better to just replace "fsl,imx21-ssi" with
"fsl,imx51-ssi".
>
> However on mx6sx node we have:
>
> ssi1: ssi at 02028000 {
> compatible = "fsl,imx6sx-ssi", "fsl,imx21-ssi";
>
> Which one is correct? Care to explain?
This one is incorrect now. The "fsl,imx21-ssi" should be replaced by
"fsl,imx51-ssi" per commit above. Care to send a patch for it?
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-07 5:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-04 6:46 [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx Shawn Guo
2014-07-04 6:58 ` Yibin Gong
2014-07-04 13:53 ` Fabio Estevam
2014-07-04 14:55 ` Shawn Guo
2014-07-04 15:47 ` Fabio Estevam
2014-07-07 5:29 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).