From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: origen: Add missing USB regulators
Date: Wed, 07 Nov 2012 15:32:30 +0100 [thread overview]
Message-ID: <1404564.Y3Pmvq2f73@amdc1227> (raw)
In-Reply-To: <1706359.z5UOYbqyny@amdc1227>
On Wednesday 07 of November 2012 14:01:19 Tomasz Figa wrote:
> This patch adds missing USB OTG regulators needed for s3c-hsotg driver
> to work on Origen board.
>
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos/mach-origen.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-exynos/mach-origen.c
> b/arch/arm/mach-exynos/mach-origen.c index d8dc6d7..ddf6358 100644
> --- a/arch/arm/mach-exynos/mach-origen.c
> +++ b/arch/arm/mach-exynos/mach-origen.c
> @@ -100,6 +100,8 @@ static struct regulator_consumer_supply __initdata
> ldo3_consumer[] = { REGULATOR_SUPPLY("vddcore", "s5p-mipi-csis.0"), /*
> MIPI */
> REGULATOR_SUPPLY("vdd", "exynos4-hdmi"), /* HDMI */
> REGULATOR_SUPPLY("vdd_pll", "exynos4-hdmi"), /* HDMI */
> + REGULATOR_SUPPLY("vusb_d", "s3c-hsotg"), /* OTG */
> + REGULATOR_SUPPLY("vusb_a", "s3c-hsotg"), /* OTG */
> };
> static struct regulator_consumer_supply __initdata ldo6_consumer[] = {
> REGULATOR_SUPPLY("vddio", "s5p-mipi-csis.0"), /* MIPI */
It's worth noting that this patch is based on board file of Origen in
Linaro tree
http://git.linaro.org/gitweb?p=landingteams/working/samsung/kernel;a=summary
branch samsung-linux-3.6-2012.10
and not confirmed with respective board schematics (although verified
working on an Origen board).
Personally I find these two consumers, which are supposed to provided with
completely different voltages, connected to a single regulator a bit
suspicious, so someone who know details of this board should ack or
correct this patch.
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
prev parent reply other threads:[~2012-11-07 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 13:01 [PATCH] ARM: EXYNOS: origen: Add missing USB regulators Tomasz Figa
2012-11-07 14:32 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404564.Y3Pmvq2f73@amdc1227 \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).