From: keescook@chromium.org (Kees Cook)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 02/11] seccomp: extract check/assign mode helpers
Date: Thu, 10 Jul 2014 11:40:22 -0700 [thread overview]
Message-ID: <1405017631-27346-3-git-send-email-keescook@chromium.org> (raw)
In-Reply-To: <1405017631-27346-1-git-send-email-keescook@chromium.org>
To support splitting mode 1 from mode 2, extract the mode checking and
assignment logic into common functions.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
kernel/seccomp.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/kernel/seccomp.c b/kernel/seccomp.c
index afb916c7e890..03a5959b7930 100644
--- a/kernel/seccomp.c
+++ b/kernel/seccomp.c
@@ -194,7 +194,23 @@ static u32 seccomp_run_filters(int syscall)
}
return ret;
}
+#endif /* CONFIG_SECCOMP_FILTER */
+static inline bool seccomp_check_mode(unsigned long seccomp_mode)
+{
+ if (current->seccomp.mode && current->seccomp.mode != seccomp_mode)
+ return false;
+
+ return true;
+}
+
+static inline void seccomp_assign_mode(unsigned long seccomp_mode)
+{
+ current->seccomp.mode = seccomp_mode;
+ set_tsk_thread_flag(current, TIF_SECCOMP);
+}
+
+#ifdef CONFIG_SECCOMP_FILTER
/**
* seccomp_attach_filter: Attaches a seccomp filter to current.
* @fprog: BPF program to install
@@ -490,8 +506,7 @@ static long seccomp_set_mode(unsigned long seccomp_mode, char __user *filter)
{
long ret = -EINVAL;
- if (current->seccomp.mode &&
- current->seccomp.mode != seccomp_mode)
+ if (!seccomp_check_mode(seccomp_mode))
goto out;
switch (seccomp_mode) {
@@ -512,8 +527,7 @@ static long seccomp_set_mode(unsigned long seccomp_mode, char __user *filter)
goto out;
}
- current->seccomp.mode = seccomp_mode;
- set_thread_flag(TIF_SECCOMP);
+ seccomp_assign_mode(seccomp_mode);
out:
return ret;
}
--
1.7.9.5
next prev parent reply other threads:[~2014-07-10 18:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 18:40 [PATCH v10 0/11] seccomp: add thread sync ability Kees Cook
2014-07-10 18:40 ` [PATCH v10 01/11] seccomp: create internal mode-setting function Kees Cook
2014-07-10 18:40 ` Kees Cook [this message]
2014-07-10 18:40 ` [PATCH v10 03/11] seccomp: split mode setting routines Kees Cook
2014-07-10 18:40 ` [PATCH v10 04/11] seccomp: add "seccomp" syscall Kees Cook
2014-07-10 18:40 ` [PATCH v10 05/11] ARM: add seccomp syscall Kees Cook
2014-07-10 18:40 ` [PATCH v10 06/11] MIPS: " Kees Cook
2014-07-10 18:40 ` [PATCH v10 07/11] sched: move no_new_privs into new atomic flags Kees Cook
2014-07-10 18:40 ` [PATCH v10 08/11] seccomp: split filter prep from check and apply Kees Cook
2014-07-10 18:40 ` [PATCH v10 09/11] seccomp: introduce writer locking Kees Cook
2014-07-10 18:40 ` [PATCH v10 10/11] seccomp: allow mode setting across threads Kees Cook
2014-07-10 18:40 ` [PATCH v10 11/11] seccomp: implement SECCOMP_FILTER_FLAG_TSYNC Kees Cook
2014-07-11 16:49 ` [PATCH v10 0/11] seccomp: add thread sync ability Oleg Nesterov
2014-07-11 17:55 ` Kees Cook
2014-07-14 18:59 ` Kees Cook
2014-07-15 1:53 ` James Morris
2014-07-17 21:39 ` Andy Lutomirski
2014-07-14 19:04 ` Andy Lutomirski
2014-07-14 20:34 ` Kees Cook
2014-07-16 17:54 ` Kees Cook
2014-07-16 19:45 ` Andy Lutomirski
2014-07-16 21:23 ` Kees Cook
2014-07-16 21:27 ` Andy Lutomirski
2014-07-16 16:44 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405017631-27346-3-git-send-email-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).