From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: Fix MCPM build with SUSPEND=n
Date: Mon, 14 Jul 2014 14:55:16 +0200 [thread overview]
Message-ID: <1405342516.13970.0.camel@AMDC1943> (raw)
In-Reply-To: <alpine.LFD.2.11.1407140730080.3647@knanqh.ubzr>
On pon, 2014-07-14 at 07:35 -0400, Nicolas Pitre wrote:
> On Mon, 14 Jul 2014, Krzysztof Kozlowski wrote:
>
> > Building of EXYNOS5420_MCPM with disabled SUSPEND fails:
> > arch/arm/mach-exynos/built-in.o: In function `exynos_mcpm_init':
> > arch/arm/mach-exynos/mcpm-exynos.c:361: undefined reference to `mcpm_loopback'
> >
> > The exynos_mcpm_init() in mcp-exynos.c calls mcpm_loopback() which
> > depends on cpu_suspend function (ARM_CPU_SUSPEND).
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Cc: <stable@vger.kernel.org>
>
> No need to CC stable here as this code has not reached a released kernel
> yet.
>
> > Fixes: a6a4d3152e3cbb6 ("ARM: 8083/1: exynos: activate the CCI on boot CPU/cluster using the MCPM loopback")
>
> And this is not clear yet if this commit ID is stable.
>
> Other than that:
>
> Acked-by: Nicolas Pitre <nico@linaro.org>
>
> Please send to RMK's patch system.
Sure, I'll remove the cc-stable tag, add your ack and send to the patch
system.
Thanks,
Krzysztof
>
>
> > ---
> > arch/arm/mach-exynos/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> > index 8f9b66c4ac78..5d4ff6571dcd 100644
> > --- a/arch/arm/mach-exynos/Kconfig
> > +++ b/arch/arm/mach-exynos/Kconfig
> > @@ -119,6 +119,7 @@ config EXYNOS5420_MCPM
> > bool "Exynos5420 Multi-Cluster PM support"
> > depends on MCPM && SOC_EXYNOS5420
> > select ARM_CCI
> > + select ARM_CPU_SUSPEND
> > help
> > This is needed to provide CPU and cluster power management
> > on Exynos5420 implementing big.LITTLE.
> > --
> > 1.9.1
> >
> >
prev parent reply other threads:[~2014-07-14 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 11:24 [PATCH] ARM: EXYNOS: Fix MCPM build with SUSPEND=n Krzysztof Kozlowski
2014-07-14 11:35 ` Nicolas Pitre
2014-07-14 12:55 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405342516.13970.0.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).