* [PATCH] ARM: EXYNOS: Fix MCPM build with SUSPEND=n
@ 2014-07-14 11:24 Krzysztof Kozlowski
2014-07-14 11:35 ` Nicolas Pitre
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2014-07-14 11:24 UTC (permalink / raw)
To: linux-arm-kernel
Building of EXYNOS5420_MCPM with disabled SUSPEND fails:
arch/arm/mach-exynos/built-in.o: In function `exynos_mcpm_init':
arch/arm/mach-exynos/mcpm-exynos.c:361: undefined reference to `mcpm_loopback'
The exynos_mcpm_init() in mcp-exynos.c calls mcpm_loopback() which
depends on cpu_suspend function (ARM_CPU_SUSPEND).
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: <stable@vger.kernel.org>
Fixes: a6a4d3152e3cbb6 ("ARM: 8083/1: exynos: activate the CCI on boot CPU/cluster using the MCPM loopback")
---
arch/arm/mach-exynos/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 8f9b66c4ac78..5d4ff6571dcd 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -119,6 +119,7 @@ config EXYNOS5420_MCPM
bool "Exynos5420 Multi-Cluster PM support"
depends on MCPM && SOC_EXYNOS5420
select ARM_CCI
+ select ARM_CPU_SUSPEND
help
This is needed to provide CPU and cluster power management
on Exynos5420 implementing big.LITTLE.
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: EXYNOS: Fix MCPM build with SUSPEND=n
2014-07-14 11:24 [PATCH] ARM: EXYNOS: Fix MCPM build with SUSPEND=n Krzysztof Kozlowski
@ 2014-07-14 11:35 ` Nicolas Pitre
2014-07-14 12:55 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Pitre @ 2014-07-14 11:35 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 14 Jul 2014, Krzysztof Kozlowski wrote:
> Building of EXYNOS5420_MCPM with disabled SUSPEND fails:
> arch/arm/mach-exynos/built-in.o: In function `exynos_mcpm_init':
> arch/arm/mach-exynos/mcpm-exynos.c:361: undefined reference to `mcpm_loopback'
>
> The exynos_mcpm_init() in mcp-exynos.c calls mcpm_loopback() which
> depends on cpu_suspend function (ARM_CPU_SUSPEND).
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: <stable@vger.kernel.org>
No need to CC stable here as this code has not reached a released kernel
yet.
> Fixes: a6a4d3152e3cbb6 ("ARM: 8083/1: exynos: activate the CCI on boot CPU/cluster using the MCPM loopback")
And this is not clear yet if this commit ID is stable.
Other than that:
Acked-by: Nicolas Pitre <nico@linaro.org>
Please send to RMK's patch system.
> ---
> arch/arm/mach-exynos/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 8f9b66c4ac78..5d4ff6571dcd 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -119,6 +119,7 @@ config EXYNOS5420_MCPM
> bool "Exynos5420 Multi-Cluster PM support"
> depends on MCPM && SOC_EXYNOS5420
> select ARM_CCI
> + select ARM_CPU_SUSPEND
> help
> This is needed to provide CPU and cluster power management
> on Exynos5420 implementing big.LITTLE.
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: EXYNOS: Fix MCPM build with SUSPEND=n
2014-07-14 11:35 ` Nicolas Pitre
@ 2014-07-14 12:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2014-07-14 12:55 UTC (permalink / raw)
To: linux-arm-kernel
On pon, 2014-07-14 at 07:35 -0400, Nicolas Pitre wrote:
> On Mon, 14 Jul 2014, Krzysztof Kozlowski wrote:
>
> > Building of EXYNOS5420_MCPM with disabled SUSPEND fails:
> > arch/arm/mach-exynos/built-in.o: In function `exynos_mcpm_init':
> > arch/arm/mach-exynos/mcpm-exynos.c:361: undefined reference to `mcpm_loopback'
> >
> > The exynos_mcpm_init() in mcp-exynos.c calls mcpm_loopback() which
> > depends on cpu_suspend function (ARM_CPU_SUSPEND).
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Cc: <stable@vger.kernel.org>
>
> No need to CC stable here as this code has not reached a released kernel
> yet.
>
> > Fixes: a6a4d3152e3cbb6 ("ARM: 8083/1: exynos: activate the CCI on boot CPU/cluster using the MCPM loopback")
>
> And this is not clear yet if this commit ID is stable.
>
> Other than that:
>
> Acked-by: Nicolas Pitre <nico@linaro.org>
>
> Please send to RMK's patch system.
Sure, I'll remove the cc-stable tag, add your ack and send to the patch
system.
Thanks,
Krzysztof
>
>
> > ---
> > arch/arm/mach-exynos/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> > index 8f9b66c4ac78..5d4ff6571dcd 100644
> > --- a/arch/arm/mach-exynos/Kconfig
> > +++ b/arch/arm/mach-exynos/Kconfig
> > @@ -119,6 +119,7 @@ config EXYNOS5420_MCPM
> > bool "Exynos5420 Multi-Cluster PM support"
> > depends on MCPM && SOC_EXYNOS5420
> > select ARM_CCI
> > + select ARM_CPU_SUSPEND
> > help
> > This is needed to provide CPU and cluster power management
> > on Exynos5420 implementing big.LITTLE.
> > --
> > 1.9.1
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-14 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-14 11:24 [PATCH] ARM: EXYNOS: Fix MCPM build with SUSPEND=n Krzysztof Kozlowski
2014-07-14 11:35 ` Nicolas Pitre
2014-07-14 12:55 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).