* [PATCH] ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes
@ 2014-07-21 14:54 Chen-Yu Tsai
2014-07-28 9:35 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Chen-Yu Tsai @ 2014-07-21 14:54 UTC (permalink / raw)
To: linux-arm-kernel
dtc was giving warnings for missing #address-cells and #size-cells for
the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device.
This patch adds the properties for all i2c controller nodes for sun6i.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Hi Maxime,
This is a fix to get rid of warnings from dtc when building sun6i dts.
Sorry for now catching it earlier.
Cheers
ChenYu
---
arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
index 44b07e5..e06fbfc 100644
--- a/arch/arm/boot/dts/sun6i-a31.dtsi
+++ b/arch/arm/boot/dts/sun6i-a31.dtsi
@@ -660,6 +660,8 @@
clock-frequency = <100000>;
resets = <&apb2_rst 0>;
status = "disabled";
+ #address-cells = <1>;
+ #size-cells = <0>;
};
i2c1: i2c at 01c2b000 {
@@ -670,6 +672,8 @@
clock-frequency = <100000>;
resets = <&apb2_rst 1>;
status = "disabled";
+ #address-cells = <1>;
+ #size-cells = <0>;
};
i2c2: i2c at 01c2b400 {
@@ -680,6 +684,8 @@
clock-frequency = <100000>;
resets = <&apb2_rst 2>;
status = "disabled";
+ #address-cells = <1>;
+ #size-cells = <0>;
};
i2c3: i2c at 01c2b800 {
@@ -690,6 +696,8 @@
clock-frequency = <100000>;
resets = <&apb2_rst 3>;
status = "disabled";
+ #address-cells = <1>;
+ #size-cells = <0>;
};
gmac: ethernet at 01c30000 {
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes
2014-07-21 14:54 [PATCH] ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes Chen-Yu Tsai
@ 2014-07-28 9:35 ` Maxime Ripard
2014-07-28 10:21 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2014-07-28 9:35 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 21, 2014 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> dtc was giving warnings for missing #address-cells and #size-cells for
> the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device.
>
> This patch adds the properties for all i2c controller nodes for sun6i.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Applied, thanks.
I don't plan on sending more DT pull-request unless something big
shows up, so it's probably queued for 3.18.
It's not like it's urgent anyway...
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140728/92cced1f/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes
2014-07-28 9:35 ` Maxime Ripard
@ 2014-07-28 10:21 ` Arnd Bergmann
2014-07-28 11:14 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2014-07-28 10:21 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 28 July 2014 11:35:32 Maxime Ripard wrote:
> On Mon, Jul 21, 2014 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> > dtc was giving warnings for missing #address-cells and #size-cells for
> > the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device.
> >
> > This patch adds the properties for all i2c controller nodes for sun6i.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> Applied, thanks.
>
> I don't plan on sending more DT pull-request unless something big
> shows up, so it's probably queued for 3.18.
>
> It's not like it's urgent anyway...
>
No, please send this one, I don't want to introduce new warnings
in 3.17.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes
2014-07-28 10:21 ` Arnd Bergmann
@ 2014-07-28 11:14 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2014-07-28 11:14 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 28, 2014 at 12:21:34PM +0200, Arnd Bergmann wrote:
> On Monday 28 July 2014 11:35:32 Maxime Ripard wrote:
> > On Mon, Jul 21, 2014 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> > > dtc was giving warnings for missing #address-cells and #size-cells for
> > > the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device.
> > >
> > > This patch adds the properties for all i2c controller nodes for sun6i.
> > >
> > > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >
> > Applied, thanks.
> >
> > I don't plan on sending more DT pull-request unless something big
> > shows up, so it's probably queued for 3.18.
> >
> > It's not like it's urgent anyway...
> >
>
> No, please send this one, I don't want to introduce new warnings
> in 3.17.
I didn't think we had a user for i2c yet, but yeah, we just got
one. I'll send it for 3.17 then.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140728/4790726f/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-28 11:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-21 14:54 [PATCH] ARM: dt: sun6i: Add #address-cells and #size-cells to i2c controller nodes Chen-Yu Tsai
2014-07-28 9:35 ` Maxime Ripard
2014-07-28 10:21 ` Arnd Bergmann
2014-07-28 11:14 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).