linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/19] mfd: twl4030-irq: Fix style warnings relating to pr_warn() and sizeof()
Date: Tue, 22 Jul 2014 12:11:17 +0100	[thread overview]
Message-ID: <1406027485-15657-12-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1406027485-15657-1-git-send-email-lee.jones@linaro.org>

This is part of an effort to clean-up the MFD subsystem.

WARNING: Prefer pr_warn(... to pr_warning(...
+               pr_warning("twl4030: I2C error %d reading PIH ISR\n", ret);

WARNING: sizeof buf should be sizeof(buf)
+       memset(buf, 0xff, sizeof buf);

WARNING: sizeof *agent should be sizeof(*agent)
+       agent = kzalloc(sizeof *agent, GFP_KERNEL);

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/twl4030-irq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 596b1f6..b1dabba 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -297,7 +297,7 @@ static irqreturn_t handle_twl4030_pih(int irq, void *devid)
 	ret = twl_i2c_read_u8(TWL_MODULE_PIH, &pih_isr,
 			      REG_PIH_ISR_P1);
 	if (ret) {
-		pr_warning("twl4030: I2C error %d reading PIH ISR\n", ret);
+		pr_warn("twl4030: I2C error %d reading PIH ISR\n", ret);
 		return IRQ_NONE;
 	}
 
@@ -338,7 +338,7 @@ static int twl4030_init_sih_modules(unsigned line)
 	irq_line = line;
 
 	/* disable all interrupts on our line */
-	memset(buf, 0xff, sizeof buf);
+	memset(buf, 0xff, sizeof(buf));
 	sih = sih_modules;
 	for (i = 0; i < nr_sih_modules; i++, sih++) {
 		/* skip USB -- it's funky */
@@ -646,7 +646,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
 	if (status < 0)
 		return status;
 
-	agent = kzalloc(sizeof *agent, GFP_KERNEL);
+	agent = kzalloc(sizeof(*agent), GFP_KERNEL);
 	if (!agent)
 		return -ENOMEM;
 
-- 
1.8.3.2

  parent reply	other threads:[~2014-07-22 11:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 11:11 [PATCH 00/19] mfd: Fix checkpatch errors Lee Jones
2014-07-22 11:11 ` [PATCH 01/19] mfd: max77686: Fix 'line over 80 chars' warning Lee Jones
2014-07-22 11:45   ` pramod gurav
2014-07-22 12:13     ` Lee Jones
2014-07-22 12:27       ` pramod gurav
2014-07-22 11:11 ` [PATCH 02/19] mfd: max8925-i2c: Fix 'blank line after declarations' warning Lee Jones
2014-07-22 11:50   ` pramod gurav
2014-07-22 12:15     ` Lee Jones
2014-07-22 11:11 ` [PATCH 03/19] mfd: tps80031: Fix 'missing break or fall-through comment' warning Lee Jones
2014-07-22 11:33   ` Arnd Bergmann
2014-07-22 12:08     ` Lee Jones
2014-07-22 11:11 ` [PATCH 04/19] mfd: mcp-core: Fix 'blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 05/19] mfd: wm8350-irq: Fix 'line over 80 chars' warning Lee Jones
2014-07-22 11:11 ` [PATCH 06/19] mfd: dm355evm_msp: Fix checkpatch error: insert space after ', ' Lee Jones
2014-07-22 11:11 ` [PATCH 07/19] mfd: sec-core: Fix 'missing blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 08/19] mfd: twl6040: Fix 'insert space after ','', error Lee Jones
2014-07-22 11:11 ` [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch Lee Jones
2014-07-22 13:33   ` Joe Perches
2014-07-22 13:48     ` Lee Jones
2014-07-22 11:11 ` [PATCH 10/19] mfd: lp8788-irq: Fix 'missing blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` Lee Jones [this message]
2014-07-22 11:11 ` [PATCH 12/19] mfd: max8925-core: " Lee Jones
2014-07-22 11:11 ` [PATCH 13/19] mfd: wm8350-i2c: Replace spaces with tabs Lee Jones
2014-07-22 11:11 ` [PATCH 14/19] mfd: twl6030-irq: Extinguish coding style warnings Lee Jones
2014-07-22 11:11 ` [PATCH 15/19] mfd: tc6387xb: Remove unnecessary braces and correct " Lee Jones
2014-07-22 11:11 ` [PATCH 16/19] mfd: si476x-cmd: Remedy checkpatch style complains Lee Jones
2014-07-22 11:11 ` [PATCH 17/19] mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch Lee Jones
2014-07-22 11:11 ` [PATCH 18/19] mfd: kempld-core: Correct a variety of checkpatch warnings Lee Jones
2014-07-22 11:11 ` [PATCH 19/19] mfd: wm8997-tables: Suppress 'line over 80 chars' warnings Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406027485-15657-12-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).