From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] platform: Make platform_bus device a platform device
Date: Wed, 23 Jul 2014 15:26:53 +0100 [thread overview]
Message-ID: <1406125613.25343.140.camel@hornet> (raw)
In-Reply-To: <CAOesGMgya9i=zc_AVO_mgrC_FjYz-RWxwXguNueVA=7gpq=5sA@mail.gmail.com>
On Tue, 2014-07-22 at 20:46 +0100, Olof Johansson wrote:
> > @@ -946,12 +946,18 @@ int __init platform_bus_init(void)
> >
> > early_platform_cleanup();
> >
> > - error = device_register(&platform_bus);
> > + dev_set_name(&platform_bus.dev, "%s", platform_bus.name);
> > + error = device_register(&platform_bus.dev);
> > if (error)
> > return error;
> > error = bus_register(&platform_bus_type);
> > - if (error)
> > - device_unregister(&platform_bus);
> > + if (!error) {
> > + platform_bus.dev.of_node = of_allnodes;
>
> This breaks all non-OF platforms:
>
> drivers/base/platform.c: In function 'platform_bus_init':
> drivers/base/platform.c:955:30: error: 'of_allnodes' undeclared (first
> use in this function)
> platform_bus.dev.of_node = of_allnodes;
Right, of course, my bad. I can't see any other way of getting the tree
root, so an #ifdef it will be...
Thanks for pointing this out!
Pawe?
next prev parent reply other threads:[~2014-07-23 14:26 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 21:23 [GIT PULL 1/3] ARM: tegra: rework PCIe regulators Stephen Warren
2014-06-23 21:23 ` [GIT PULL 2/3] ARM: tegra: move fuse code out of arch/arm Stephen Warren
2014-07-07 0:44 ` Olof Johansson
2014-07-08 13:43 ` Peter De Schrijver
2014-07-08 17:47 ` Olof Johansson
2014-07-09 11:16 ` Peter De Schrijver
2014-07-09 12:50 ` Arnd Bergmann
2014-07-11 12:56 ` Thierry Reding
2014-07-18 2:45 ` Stephen Warren
2014-07-18 5:33 ` Olof Johansson
2014-07-21 15:06 ` Stephen Warren
2014-07-21 15:54 ` Catalin Marinas
2014-07-21 16:14 ` Pawel Moll
2014-07-21 16:38 ` Stephen Warren
2014-07-21 16:46 ` Olof Johansson
2014-07-21 17:00 ` [PATCH] platform: Make platform_bus device a platform device Pawel Moll
2014-07-21 18:40 ` Greg Kroah-Hartman
2014-07-22 10:02 ` [PATCH v2] " Pawel Moll
2014-07-22 17:10 ` Greg Kroah-Hartman
2014-07-22 17:30 ` Pawel Moll
2014-07-22 17:37 ` Greg Kroah-Hartman
2014-07-22 17:55 ` [PATCH v3] " Pawel Moll
2014-07-22 18:01 ` Pawel Moll
2014-07-22 18:15 ` Greg Kroah-Hartman
2014-07-23 17:16 ` Pawel Moll
2014-07-23 19:34 ` Greg Kroah-Hartman
2014-07-24 17:12 ` Pawel Moll
2014-07-22 19:46 ` Olof Johansson
2014-07-23 14:26 ` Pawel Moll [this message]
2014-07-22 22:16 ` Greg Kroah-Hartman
2014-07-23 14:27 ` Pawel Moll
2014-07-22 10:27 ` [GIT PULL 2/3] ARM: tegra: move fuse code out of arch/arm Catalin Marinas
2014-07-22 16:27 ` Stephen Warren
2014-07-22 16:54 ` Catalin Marinas
2014-07-22 11:26 ` Catalin Marinas
2014-07-22 16:22 ` Stephen Warren
2014-07-22 17:04 ` Catalin Marinas
2014-07-18 2:44 ` Stephen Warren
2014-07-18 5:33 ` Olof Johansson
2014-06-23 21:23 ` [GIT PULL 3/3] ARM: tegra: use us counter as delay timer Stephen Warren
2014-07-07 0:49 ` Olof Johansson
2014-07-07 0:38 ` [GIT PULL 1/3] ARM: tegra: rework PCIe regulators Olof Johansson
2014-07-07 5:52 ` Thierry Reding
2014-07-08 4:45 ` Olof Johansson
2014-07-10 10:15 ` Thierry Reding
2014-07-17 14:20 ` Thierry Reding
2014-07-17 17:52 ` Olof Johansson
2014-07-18 2:47 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406125613.25343.140.camel@hornet \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox