From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] [SCSI] Do not use platform_bus as a parent
Date: Fri, 25 Jul 2014 15:23:52 +0100 [thread overview]
Message-ID: <1406298233-27876-4-git-send-email-pawel.moll@arm.com> (raw)
In-Reply-To: <1406298233-27876-1-git-send-email-pawel.moll@arm.com>
The host devices without a parent were "forcefully adopted"
by platform bus. This patch removes this assignment. In
effect the dev_dev may be NULL now, which means ISA.
Cc: James E.J. Bottomley <JBottomley@parallels.com>
Cc: linux-scsi at vger.kernel.org
Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---
This patch is a part of effort to remove references to platform_bus
and make it static.
James, could you please have a look and advice if the change is
correct? Would you happen to know the "real reasons" behind
using the root platform_bus device a parent?
drivers/scsi/hosts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 3cbb57a..0c7389f 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -218,7 +218,7 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev,
goto fail;
if (!shost->shost_gendev.parent)
- shost->shost_gendev.parent = dev ? dev : &platform_bus;
+ shost->shost_gendev.parent = dev;
if (!dma_dev)
dma_dev = shost->shost_gendev.parent;
--
1.9.1
next prev parent reply other threads:[~2014-07-25 14:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 14:23 [PATCH 1/5] ARM: imx: Remove references to platform_bus in mxc code Pawel Moll
2014-07-25 14:23 ` [PATCH 2/5] char: tile-srom: Remove reference to platform_bus Pawel Moll
2014-07-31 20:24 ` Chris Metcalf
2014-07-31 21:32 ` Greg Kroah-Hartman
2014-08-01 17:21 ` Pawel Moll
2014-08-05 20:08 ` Chris Metcalf
2014-08-05 23:06 ` Greg Kroah-Hartman
2014-08-08 16:34 ` Pawel Moll
2014-08-08 16:39 ` Pawel Moll
2014-08-11 2:38 ` Chris Metcalf
2014-08-29 18:43 ` Chris Metcalf
2014-09-01 12:27 ` Pawel Moll
2014-09-01 13:53 ` Chris Metcalf
2014-07-25 14:23 ` [PATCH 3/5] mmc: sdhci-pltfm: Do not use parent as the host's device Pawel Moll
2014-08-08 16:36 ` Pawel Moll
2014-08-11 9:07 ` Ulf Hansson
2014-08-11 9:15 ` Pawel Moll
2014-08-11 9:32 ` Ulf Hansson
2014-08-12 8:58 ` Ulf Hansson
2014-08-11 10:02 ` Russell King - ARM Linux
2014-07-25 14:23 ` Pawel Moll [this message]
2014-07-25 14:46 ` [PATCH 4/5] [SCSI] Do not use platform_bus as a parent James Bottomley
2014-07-25 15:40 ` Pawel Moll
2014-07-26 20:11 ` Greg Kroah-Hartman
2014-07-27 3:52 ` James Bottomley
2014-07-27 15:07 ` Greg Kroah-Hartman
2014-08-01 17:25 ` Pawel Moll
2014-07-25 14:23 ` [PATCH 5/5] platform: Make platform_bus device a platform device Pawel Moll
2014-07-26 20:12 ` Greg Kroah-Hartman
2014-08-01 17:21 ` Pawel Moll
2014-07-26 20:13 ` Greg Kroah-Hartman
2014-08-01 17:21 ` Pawel Moll
2014-07-28 1:45 ` [PATCH 1/5] ARM: imx: Remove references to platform_bus in mxc code Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406298233-27876-4-git-send-email-pawel.moll@arm.com \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).