* [PATCH v3] Documentation: devicetree: Fix tps65090 typos in example
@ 2014-07-30 21:29 Andreas Färber
2014-07-31 23:51 ` Javier Martinez Canillas
2014-08-06 21:10 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Färber @ 2014-07-30 21:29 UTC (permalink / raw)
To: linux-arm-kernel
Specification and existing device trees use vsys-l{1,2}-supply,
not vsys_l{1,2}-supply. Fix the example to match the specification.
Reviewed-by: Doug Anderson <dianders@chromium.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Fixes: 21d2202158e9 ("mfd: tps65090: add DT support for tps65090")
Signed-off-by: Andreas F?rber <afaerber@suse.de>
---
v2 -> v3:
* Added Fixes header
* + regulator and mfd maintainers
v1 -> v2:
* More verbose commit message (requested by Mark Rutland)
Documentation/devicetree/bindings/regulator/tps65090.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/tps65090.txt b/Documentation/devicetree/bindings/regulator/tps65090.txt
index 340980239ea9..ca69f5e3040c 100644
--- a/Documentation/devicetree/bindings/regulator/tps65090.txt
+++ b/Documentation/devicetree/bindings/regulator/tps65090.txt
@@ -45,8 +45,8 @@ Example:
infet5-supply = <&some_reg>;
infet6-supply = <&some_reg>;
infet7-supply = <&some_reg>;
- vsys_l1-supply = <&some_reg>;
- vsys_l2-supply = <&some_reg>;
+ vsys-l1-supply = <&some_reg>;
+ vsys-l2-supply = <&some_reg>;
regulators {
dcdc1 {
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3] Documentation: devicetree: Fix tps65090 typos in example
2014-07-30 21:29 [PATCH v3] Documentation: devicetree: Fix tps65090 typos in example Andreas Färber
@ 2014-07-31 23:51 ` Javier Martinez Canillas
2014-08-06 21:10 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2014-07-31 23:51 UTC (permalink / raw)
To: linux-arm-kernel
Hello Andreas,
On Wed, Jul 30, 2014 at 11:29 PM, Andreas F?rber <afaerber@suse.de> wrote:
> Specification and existing device trees use vsys-l{1,2}-supply,
> not vsys_l{1,2}-supply. Fix the example to match the specification.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Fixes: 21d2202158e9 ("mfd: tps65090: add DT support for tps65090")
> Signed-off-by: Andreas F?rber <afaerber@suse.de>
> ---
> v2 -> v3:
> * Added Fixes header
> * + regulator and mfd maintainers
>
> v1 -> v2:
> * More verbose commit message (requested by Mark Rutland)
>
> Documentation/devicetree/bindings/regulator/tps65090.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/tps65090.txt b/Documentation/devicetree/bindings/regulator/tps65090.txt
> index 340980239ea9..ca69f5e3040c 100644
> --- a/Documentation/devicetree/bindings/regulator/tps65090.txt
> +++ b/Documentation/devicetree/bindings/regulator/tps65090.txt
> @@ -45,8 +45,8 @@ Example:
> infet5-supply = <&some_reg>;
> infet6-supply = <&some_reg>;
> infet7-supply = <&some_reg>;
> - vsys_l1-supply = <&some_reg>;
> - vsys_l2-supply = <&some_reg>;
> + vsys-l1-supply = <&some_reg>;
> + vsys-l2-supply = <&some_reg>;
>
True, these also matches the .supply_name used when registering the
LDO[1-2] regulators in the tps65090 driver. So clearly the example was
wrong while the property specification is correct.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3] Documentation: devicetree: Fix tps65090 typos in example
2014-07-30 21:29 [PATCH v3] Documentation: devicetree: Fix tps65090 typos in example Andreas Färber
2014-07-31 23:51 ` Javier Martinez Canillas
@ 2014-08-06 21:10 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-08-06 21:10 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 30, 2014 at 11:29:27PM +0200, Andreas F?rber wrote:
> Specification and existing device trees use vsys-l{1,2}-supply,
> not vsys_l{1,2}-supply. Fix the example to match the specification.
Applied. I've previously reminded you to use subject lines appropraite
for the subsystem, please do so - this is important for telling people
what the patch is for.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140806/f5490ac1/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-06 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-30 21:29 [PATCH v3] Documentation: devicetree: Fix tps65090 typos in example Andreas Färber
2014-07-31 23:51 ` Javier Martinez Canillas
2014-08-06 21:10 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).