From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] arm64: don't flag non-aliasing VIPT I-caches as aliasing
Date: Mon, 4 Aug 2014 10:16:56 +0200 [thread overview]
Message-ID: <1407140216-22747-3-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1407140216-22747-1-git-send-email-ard.biesheuvel@linaro.org>
VIPT caches are non-aliasing if the index is derived from address bits that
are always equal between VA and PA. Classifying these as aliasing results in
unnecessary flushing which may hurt performance.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
arch/arm64/kernel/cpuinfo.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
index 744fad2ff418..b780acc201ad 100644
--- a/arch/arm64/kernel/cpuinfo.c
+++ b/arch/arm64/kernel/cpuinfo.c
@@ -47,7 +47,13 @@ static void cpuinfo_detect_icache_policy(struct cpuinfo_arm64 *info)
unsigned int cpu = smp_processor_id();
u32 l1ip = CTR_L1IP(info->reg_ctr);
- if (l1ip != ICACHE_POLICY_PIPT)
+ /*
+ * VIPT caches are non-aliasing if the VA always equals the PA in all
+ * bit positions that are covered by the index, i.e., if num_sets_shift
+ * is less than or equal to PAGE_SHIFT minus line_size_shift.
+ */
+ if (l1ip != ICACHE_POLICY_PIPT && !(l1ip == ICACHE_POLICY_VIPT &&
+ icache_get_linesize() * icache_get_numsets() <= PAGE_SIZE))
set_bit(ICACHEF_ALIASING, &__icache_flags);
if (l1ip == ICACHE_POLICY_AIVIVT)
set_bit(ICACHEF_AIVIVT, &__icache_flags);
--
1.8.3.2
next prev parent reply other threads:[~2014-08-04 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 8:16 [PATCH 1/3] arm64: fix typo in I-cache policy detection Ard Biesheuvel
2014-08-04 8:16 ` [PATCH 2/3] arm64: add helper functions to read I-cache attributes Ard Biesheuvel
2014-08-04 9:58 ` Mark Rutland
2014-08-04 10:38 ` Ard Biesheuvel
2014-08-04 8:16 ` Ard Biesheuvel [this message]
2014-08-04 9:06 ` [PATCH 1/3] arm64: fix typo in I-cache policy detection Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407140216-22747-3-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).