* [PATCH] ARM: OMAP2+: omap_device: remove warning that clk alias already exists
@ 2014-08-04 12:54 Markus Pargmann
2014-08-22 23:07 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Markus Pargmann @ 2014-08-04 12:54 UTC (permalink / raw)
To: linux-arm-kernel
When an alias for a clock already exists the warning is printed. For
every module with a main_clk defined, a clk alias for fck is added.
There are some components that have the same main_clk defined, so this
is a really normal situation.
For example the am33xx edma device has 4 components using the same main
clock. So there are three warnings in the boot log for this already
existing clock alias:
platform 49000000.edma: alias fck already exists
platform 49000000.edma: alias fck already exists
platform 49000000.edma: alias fck already exists
As this is only interesting for developers, this patch changes the
message to a debug message.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
arch/arm/mach-omap2/omap_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
index 01ef59def44b..d22c30d3ccfa 100644
--- a/arch/arm/mach-omap2/omap_device.c
+++ b/arch/arm/mach-omap2/omap_device.c
@@ -56,7 +56,7 @@ static void _add_clkdev(struct omap_device *od, const char *clk_alias,
r = clk_get_sys(dev_name(&od->pdev->dev), clk_alias);
if (!IS_ERR(r)) {
- dev_warn(&od->pdev->dev,
+ dev_dbg(&od->pdev->dev,
"alias %s already exists\n", clk_alias);
clk_put(r);
return;
--
2.0.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: OMAP2+: omap_device: remove warning that clk alias already exists
2014-08-04 12:54 [PATCH] ARM: OMAP2+: omap_device: remove warning that clk alias already exists Markus Pargmann
@ 2014-08-22 23:07 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2014-08-22 23:07 UTC (permalink / raw)
To: linux-arm-kernel
* Markus Pargmann <mpa@pengutronix.de> [140804 05:56]:
> When an alias for a clock already exists the warning is printed. For
> every module with a main_clk defined, a clk alias for fck is added.
> There are some components that have the same main_clk defined, so this
> is a really normal situation.
>
> For example the am33xx edma device has 4 components using the same main
> clock. So there are three warnings in the boot log for this already
> existing clock alias:
> platform 49000000.edma: alias fck already exists
> platform 49000000.edma: alias fck already exists
> platform 49000000.edma: alias fck already exists
>
> As this is only interesting for developers, this patch changes the
> message to a debug message.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> arch/arm/mach-omap2/omap_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> index 01ef59def44b..d22c30d3ccfa 100644
> --- a/arch/arm/mach-omap2/omap_device.c
> +++ b/arch/arm/mach-omap2/omap_device.c
> @@ -56,7 +56,7 @@ static void _add_clkdev(struct omap_device *od, const char *clk_alias,
>
> r = clk_get_sys(dev_name(&od->pdev->dev), clk_alias);
> if (!IS_ERR(r)) {
> - dev_warn(&od->pdev->dev,
> + dev_dbg(&od->pdev->dev,
> "alias %s already exists\n", clk_alias);
> clk_put(r);
> return;
Thanks applying into omap-for-v3.17/fixes.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-22 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 12:54 [PATCH] ARM: OMAP2+: omap_device: remove warning that clk alias already exists Markus Pargmann
2014-08-22 23:07 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).