From: dyoung@redhat.com (Dave Young)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] efi_rtc: probe function error out in case no efi runtime enabled
Date: Tue, 12 Aug 2014 14:10:22 +0800 [thread overview]
Message-ID: <1407823822-23829-5-git-send-email-dyoung@redhat.com> (raw)
In-Reply-To: <1407823822-23829-1-git-send-email-dyoung@redhat.com>
efi rtc depends on efi runtime services, so if efi runtime services are not
usable it should error out.
Without this patch rtc-efi will panic with 'noefi' boot
Signed-off-by: Dave Young <dyoung@redhat.com>
---
drivers/rtc/rtc-efi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c
index 8225b89..8c02ed8 100644
--- a/drivers/rtc/rtc-efi.c
+++ b/drivers/rtc/rtc-efi.c
@@ -213,6 +213,9 @@ static int __init efi_rtc_probe(struct platform_device *dev)
{
struct rtc_device *rtc;
+ if (!efi_enabled(EFI_RUNTIME_SERVICES))
+ return -ENODEV;
+
rtc = devm_rtc_device_register(&dev->dev, "rtc-efi", &efi_rtc_ops,
THIS_MODULE);
if (IS_ERR(rtc))
--
1.8.3.1
next prev parent reply other threads:[~2014-08-12 6:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 6:10 [PATCH 1/5] efi: move noefi early param code out of x86 arch code Dave Young
2014-08-12 6:10 ` [PATCH 2/5] efi: add kernel param efi=noruntime Dave Young
2014-08-13 8:13 ` Dave Young
2014-08-13 14:22 ` Matt Fleming
2014-08-12 6:10 ` [PATCH 3/5] efi arm64: do not enter virtual mode in case booting with efi=noruntime or noefi Dave Young
2014-08-12 10:46 ` Will Deacon
2014-08-13 1:29 ` Dave Young
2014-08-12 6:10 ` [PATCH 4/5] efi x86: clear EFI_RUNTIME_SERVICES bit in case failures other than SetVirtualAddressMap Dave Young
2014-08-13 14:27 ` Matt Fleming
2014-08-12 6:10 ` Dave Young [this message]
2014-08-12 6:52 ` [PATCH 1/5] efi: move noefi early param code out of x86 arch code Randy Dunlap
2014-08-12 7:14 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407823822-23829-5-git-send-email-dyoung@redhat.com \
--to=dyoung@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).