From: dyoung@redhat.com (Dave Young)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] efi_rtc: probe function error out in case no efi runtime enabled
Date: Thu, 14 Aug 2014 17:19:13 +0800 [thread overview]
Message-ID: <1408007953-15151-1-git-send-email-dyoung@redhat.com> (raw)
In-Reply-To: <1408007731-15081-1-git-send-email-dyoung@redhat.com>
efi rtc depends on efi runtime services, so if efi runtime services are not
usable it should error out.
Without this patch rtc-efi will panic with 'noefi' boot
Signed-off-by: Dave Young <dyoung@redhat.com>
---
drivers/rtc/rtc-efi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c
index c4c3843..ca2487b 100644
--- a/drivers/rtc/rtc-efi.c
+++ b/drivers/rtc/rtc-efi.c
@@ -191,6 +191,9 @@ static int __init efi_rtc_probe(struct platform_device *dev)
{
struct rtc_device *rtc;
+ if (!efi_enabled(EFI_RUNTIME_SERVICES))
+ return -ENODEV;
+
rtc = devm_rtc_device_register(&dev->dev, "rtc-efi", &efi_rtc_ops,
THIS_MODULE);
if (IS_ERR(rtc))
--
1.8.3.1
next prev parent reply other threads:[~2014-08-14 9:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 9:15 [PATCH 1/7] efi: move noefi early param code out of x86 arch code Dave Young
2014-08-14 9:15 ` [PATCH 2/7] Add a generic cmdline parse function parse_option_str Dave Young
2014-08-14 9:15 ` [PATCH 3/7] efi: add kernel param efi=noruntime Dave Young
2014-08-14 9:15 ` [PATCH 4/7] arm64/efi: uefi_init error handling fix Dave Young
2014-08-14 13:55 ` Mark Salter
2014-08-15 15:05 ` Will Deacon
2014-08-14 9:15 ` [PATCH 5/7] arm64/efi: do not enter virtual mode in case booting with efi=noruntime or noefi Dave Young
2014-08-15 15:09 ` Will Deacon
2014-08-18 1:24 ` Dave Young
2014-08-18 1:30 ` [PATCH 5/7 update] " Dave Young
2014-08-22 15:10 ` Will Deacon
2014-08-22 15:47 ` Matt Fleming
2014-08-22 16:25 ` Will Deacon
2014-08-14 9:15 ` [PATCH 6/7] x86/efi: clear EFI_RUNTIME_SERVICES bit in case failures while entering virtual mode Dave Young
2014-08-14 9:19 ` Dave Young [this message]
2014-09-22 16:33 ` [PATCH 7/7] efi_rtc: probe function error out in case no efi runtime enabled Mark Salter
2014-09-23 7:24 ` Dave Young
2014-09-28 16:41 ` Matt Fleming
2014-09-25 21:18 ` Matt Fleming
2014-09-25 21:38 ` Mark Salter
2014-10-03 12:11 ` Matt Fleming
2014-08-14 9:26 ` [PATCH 1/7] efi: move noefi early param code out of x86 arch code Dave Young
2014-08-25 10:24 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408007953-15151-1-git-send-email-dyoung@redhat.com \
--to=dyoung@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).