From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] PWM changes for rk3288-evb
Date: Mon, 18 Aug 2014 10:09:05 -0700 [thread overview]
Message-ID: <1408381749-14156-1-git-send-email-dianders@chromium.org> (raw)
These patches enable the pwm backlight for the rk3288-evb board.
There were tested by watching the backlight grow from off to max with
the following instructions:
cd /sys/class/backlight/backlight*/
for i in $(seq 255); do echo $i > brightness; sleep .01; done
The first patch enables the proper IP. I think it could land in
Heiko's tree.
The second patch switches PWM cells from 2 to 3 on rk3288. I think it
could land in Thierry's tree. With the PWM subsystem as currently
structured, I believe this will break backward compatibility. However
the rk3288 PWM driver was added so recently (and the rk3288 is so new)
that this seems OK. In the worst case if someone yells that they are
broken, I believe we could fix this in Linux by saying that if a PWM
driver specifies 3 cells and the DTS definition of the PWM says 2
cells that we'll just pretend that we have no flags.
The 3rd and 4th patches are DTS ones. They could land in Heiko's tree
after the second patch has landed. They are based atop his current
WIP 3.18 dts tree. Note that instantiating the PWM backlight will
cause the system to hang unless Heiko's (clk: rockchip: protect
critical clocks from getting disabled)
<patchwork.kernel.org/patch/4725391> is landed.
There are no compile time or runtime dependencies between these
patches except that patch #3 needs to come before patch #4. ...and of
course the PWM won't work without all 4 patches.
Doug Anderson (4):
ARM: rockchip: rk3288: Switch to use the proper PWM IP
pwm: rockchip: Allow polarity invert on rk3288
ARM: dts: Add main PWM info to rk3288
ARM: dts: Enable pwm backlight on rk3288-EVB
.../devicetree/bindings/pwm/pwm-rockchip.txt | 4 +-
arch/arm/boot/dts/rk3288-evb.dtsi | 53 +++++++++++++++++
arch/arm/boot/dts/rk3288.dtsi | 68 ++++++++++++++++++++++
arch/arm/mach-rockchip/rockchip.c | 19 ++++++
drivers/pwm/pwm-rockchip.c | 32 +++++++++-
5 files changed, 172 insertions(+), 4 deletions(-)
--
2.1.0.rc2.206.gedb03e5
next reply other threads:[~2014-08-18 17:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 17:09 Doug Anderson [this message]
2014-08-18 17:09 ` [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP Doug Anderson
2014-08-18 17:11 ` Sonny Rao
2014-08-18 17:19 ` Doug Anderson
2014-08-19 7:10 ` Thierry Reding
2014-08-19 15:18 ` Doug Anderson
2014-08-20 6:08 ` Thierry Reding
2014-08-20 15:20 ` Doug Anderson
2014-08-20 15:38 ` Thierry Reding
2014-08-20 15:55 ` Doug Anderson
2014-08-20 16:20 ` Heiko Stübner
2014-08-20 16:27 ` Doug Anderson
2014-08-20 18:03 ` Heiko Stübner
2014-08-20 20:49 ` Doug Anderson
2014-08-21 6:36 ` Thierry Reding
2014-08-21 15:38 ` Doug Anderson
2014-08-21 15:49 ` Tomasz Figa
2014-08-21 16:49 ` Thierry Reding
2014-08-21 16:47 ` Thierry Reding
2014-08-25 23:40 ` Doug Anderson
2014-08-26 7:31 ` Thierry Reding
2014-08-21 6:24 ` Thierry Reding
2014-08-21 15:39 ` Doug Anderson
2014-08-21 15:53 ` Heiko Stübner
2014-08-18 17:09 ` [PATCH 2/4] pwm: rockchip: Allow polarity invert on rk3288 Doug Anderson
2014-08-19 7:18 ` Thierry Reding
2014-08-19 16:05 ` Doug Anderson
2014-08-20 6:09 ` Thierry Reding
2014-08-18 17:09 ` [PATCH 3/4] ARM: dts: Add main PWM info to rk3288 Doug Anderson
2014-08-18 17:09 ` [PATCH 4/4] ARM: dts: Enable pwm backlight on rk3288-EVB Doug Anderson
2014-08-19 7:22 ` Thierry Reding
2014-08-19 16:05 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408381749-14156-1-git-send-email-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).