[PATCH] ARM: dts: imx28-evk: Fix display duplicate name warning

[PATCH] ARM: dts: imx28-evk: Fix display duplicate name warning

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Provide the display unit address in order to fix the following warning:

[    0.114765] regulator-dummy: no parameters
[    0.152091] device-tree: Duplicate name in lcdif at 80030000, renamed to "display#1"

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx28-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts
index e4cc44c..c258b2c 100644
--- a/arch/arm/boot/dts/imx28-evk.dts
+++ b/arch/arm/boot/dts/imx28-evk.dts
@@ -127,7 +127,7 @@
 				display = <&display>;
 				status = "okay";
 
-				display: display {
+				display: display at 0 {
 					bits-per-pixel = <32>;
 					bus-width = <24>;
 
-- 
1.9.1

[PATCH] ARM: dts: imx28-evk: Fix display duplicate name warning

[Shawn Guo]

On Thu, Aug 21, 2014 at 10:59:32PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Provide the display unit address in order to fix the following warning:
> 
> [    0.114765] regulator-dummy: no parameters
> [    0.152091] device-tree: Duplicate name in lcdif at 80030000, renamed to "display#1"
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/boot/dts/imx28-evk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts
> index e4cc44c..c258b2c 100644
> --- a/arch/arm/boot/dts/imx28-evk.dts
> +++ b/arch/arm/boot/dts/imx28-evk.dts
> @@ -127,7 +127,7 @@
>  				display = <&display>;
>  				status = "okay";
>  
> -				display: display {
> +				display: display at 0 {

Unit address only makes sense where parent has #address-cells and
#size-cells and the node itself has 'reg' property.

I guess it's more appropriate to name the node in particular display
device model that the node is defining?

Shawn

>  					bits-per-pixel = <32>;
>  					bus-width = <24>;
>  
> -- 
> 1.9.1
> 

[PATCH] ARM: dts: imx28-evk: Fix display duplicate name warning

[Fabio Estevam]

On Sun, Aug 24, 2014 at 11:27 PM, Shawn Guo <shawn.guo@freescale.com> wrote:

> Unit address only makes sense where parent has #address-cells and
> #size-cells and the node itself has 'reg' property.

Ok, I followed the way arch/arm/boot/dts/imx28-tx28.dts implemented
the display node.

> I guess it's more appropriate to name the node in particular display
> device model that the node is defining?

Sorry, I did not understand. Could you please provide an example for
clarification?

Thanks,

Fabio Estevam

[PATCH] ARM: dts: imx28-evk: Fix display duplicate name warning

[Shawn Guo]

On Sun, Aug 24, 2014 at 11:34:31PM -0300, Fabio Estevam wrote:
> On Sun, Aug 24, 2014 at 11:27 PM, Shawn Guo <shawn.guo@freescale.com> wrote:
> 
> > Unit address only makes sense where parent has #address-cells and
> > #size-cells and the node itself has 'reg' property.
> 
> Ok, I followed the way arch/arm/boot/dts/imx28-tx28.dts implemented
> the display node.
> 
> > I guess it's more appropriate to name the node in particular display
> > device model that the node is defining?
> 
> Sorry, I did not understand. Could you please provide an example for
> clarification?

See LVDS panel example in arch/arm/boot/dts/imx6qdl-sabresd.dtsi

Shawn