From: addy.ke@rock-chips.com (Addy Ke)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master receive mode
Date: Sat, 23 Aug 2014 02:00:52 +0800 [thread overview]
Message-ID: <1408730452-3552-1-git-send-email-addy.ke@rock-chips.com> (raw)
In-Reply-To: <1408669991-9703-1-git-send-email-addy.ke@rock-chips.com>
In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data
in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx
must be less than or equal 32 bytes at a time.
Tested on rk3288-pinky board, elan receive 158 bytes data.
Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
Acked-by: Max Schwarz <max.schwarz@online.de>
---
Changes in v2:
- Use cleaner syntax as suggested by Sergei.
- Update commit message as suggested by Wolfram.
Changes in v3:
- fix typo: maste --> master and double spaces after 'len'
drivers/i2c/busses/i2c-rk3x.c | 4 ++++
Changes in v4:
- remove unlikely() annotations, suggested by Dmitry Torokhov
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index b8b2b89..31de730 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -323,6 +323,10 @@ static void rk3x_i2c_handle_read(struct rk3x_i2c *i2c, unsigned int ipd)
/* ack interrupt */
i2c_writel(i2c, REG_INT_MBRF, REG_IPD);
+ /* Can only handle a maximum of 32 bytes at a time */
+ if (len > 32)
+ len = 32;
+
/* read the data from receive buffer */
for (i = 0; i < len; ++i) {
if (i % 4 == 0)
--
1.8.3.2
next prev parent reply other threads:[~2014-08-22 18:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0001-i2c-rk3x-fix-bug-that-cause-transfer-fails-in-master.patch>
2014-08-21 21:38 ` [PATCH v2] i2c: rk3x: fix bug that cause transfer fails in maste receive mode Addy Ke
2014-08-22 1:13 ` [PATCH v3] i2c: rk3x: fix bug that cause transfer fails in master " Addy Ke
2014-08-22 1:15 ` Doug Anderson
2014-08-22 16:16 ` Dmitry Torokhov
2014-08-22 18:00 ` Addy Ke [this message]
2014-08-22 18:33 ` [PATCH v4] " Doug Anderson
2014-08-22 18:47 ` addy ke
2014-08-22 20:04 ` Doug Anderson
2014-09-02 11:01 ` Wolfram Sang
2014-08-22 1:14 ` [PATCH v2] i2c: rk3x: fix bug that cause transfer fails in maste " Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408730452-3552-1-git-send-email-addy.ke@rock-chips.com \
--to=addy.ke@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).