From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Griffin <peter.griffin@linaro.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Lee Jones <lee@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
tudor.ambarus@linaro.org, andre.draszik@linaro.org,
willmcvicker@google.com, kernel-team@android.com
Subject: Re: [PATCH 2/4] dt-bindings: mfd: syscon: allow two reg regions for gs101-pmu
Date: Sun, 22 Dec 2024 13:06:50 +0100 [thread overview]
Message-ID: <1408dcd1-9a46-4cb9-8443-5aa51d61ed56@kernel.org> (raw)
In-Reply-To: <20241213-contrib-pg-cpu-hotplug-suspend2ram-fixes-v1-v1-2-c72978f63713@linaro.org>
On 13/12/2024 17:44, Peter Griffin wrote:
> To avoid dtschema warnings allow google,gs101-pmu to have
> two reg regions.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> I don't really like this patch, but also didn't want to submit the series
> with a dtschema warning ;-)
>
> Possibly a better solution is when Robs patch
> `mfd: syscon: Allow syscon nodes without a "syscon" compatible` [1]
PMU which spans over two blocks is not a simple syscon. These would be
two syscon devices.
If you request regmap from such syscon, which regmap you get?
I am not sure whether the PMU is really split here. Usually the main PMU
was only one and additional blocks called PMU were somehow specialized
per each IP block.
Maybe you have here two devices, maybe only one. If it is only one, then
it is not a syscon anymore, IMO.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-22 14:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 16:44 [PATCH 0/4] Fix Google Tensor GS101 CPU hotplug support Peter Griffin
2024-12-13 16:44 ` [PATCH 1/4] dt-bindings: soc: samsung: exynos-pmu: gs101: add pmu-intr-gen reg region Peter Griffin
2024-12-13 16:44 ` [PATCH 2/4] dt-bindings: mfd: syscon: allow two reg regions for gs101-pmu Peter Griffin
2024-12-13 18:26 ` Rob Herring (Arm)
2024-12-16 14:18 ` Rob Herring
2024-12-16 14:27 ` Rob Herring
2024-12-22 12:06 ` Krzysztof Kozlowski [this message]
2024-12-30 9:10 ` Peter Griffin
2025-01-03 17:14 ` Krzysztof Kozlowski
2025-01-06 13:41 ` Peter Griffin
2024-12-13 16:44 ` [PATCH 3/4] arm64: dts: exynos: gs101: add pmu-intr-gen regs to the PMU node Peter Griffin
2024-12-13 16:44 ` [PATCH 4/4] soc: samsung: exynos-pmu: enable CPU hotplug support for gs101 Peter Griffin
2024-12-22 12:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408dcd1-9a46-4cb9-8443-5aa51d61ed56@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox