* [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow
@ 2014-08-27 14:48 Ajay Kumar
2014-08-27 14:48 ` [PATCH 2/2] ARM: dts: Add DT changes for display on peach_pit Ajay Kumar
2014-08-27 15:01 ` [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow Mark Rutland
0 siblings, 2 replies; 9+ messages in thread
From: Ajay Kumar @ 2014-08-27 14:48 UTC (permalink / raw)
To: linux-arm-kernel
Add DT nodes for ptn3460 bridge chip and panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on snow.
Note that, snow doesn't support "chunghwa,claa101wb01" panel,
but still we choose to reuse the binding since "chunghwa,claa101wb01"
has similar LCD timings.
Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
Changes since V1:
-- Remove "simple-panel" compatible string.
-- Use GPIO_ACTIVE_HIGH instead of 0.
-- Change panel node naming from "panel-simple" to "panel".
arch/arm/boot/dts/exynos5250-snow.dts | 41 ++++++++++++++++++---------------
1 file changed, 22 insertions(+), 19 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index f2b8c41..1ac9709 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -9,6 +9,7 @@
*/
/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
#include "exynos5250.dtsi"
#include "exynos5250-cros-common.dtsi"
@@ -181,7 +182,7 @@
dcdc3 {
ti,enable-ext-control;
};
- fet1 {
+ fet1: fet1 {
regulator-name = "vcd_led";
ti,overcurrent-wait = <3>;
};
@@ -204,7 +205,7 @@
regulator-always-on;
ti,overcurrent-wait = <3>;
};
- fet6 {
+ fet6: fet6 {
regulator-name = "lcd_vdd";
ti,overcurrent-wait = <3>;
};
@@ -253,6 +254,15 @@
pinctrl-0 = <&max98095_en>;
pinctrl-names = "default";
};
+
+ ptn3460: lvds-bridge at 20 {
+ compatible = "nxp,ptn3460";
+ reg = <0x20>;
+ powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
+ edid-emulation = <5>;
+ panel = <&panel>;
+ };
};
i2s0: i2s at 03830000 {
@@ -300,11 +310,13 @@
vdd_pll-supply = <&ldo8_reg>;
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm 0 1000000 0>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
+ enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
+ power-supply = <&fet1>;
pinctrl-0 = <&pwm0_out>;
pinctrl-names = "default";
};
@@ -314,6 +326,12 @@
samsung,invert-vclk;
};
+ panel: panel {
+ compatible = "chunghwa,claa101wb01";
+ power-supply = <&fet6>;
+ backlight = <&backlight>;
+ };
+
dp-controller at 145B0000 {
status = "okay";
pinctrl-names = "default";
@@ -325,22 +343,7 @@
samsung,link-rate = <0x0a>;
samsung,lane-count = <2>;
samsung,hpd-gpio = <&gpx0 7 0>;
-
- display-timings {
- native-mode = <&timing1>;
-
- timing1: timing at 1 {
- clock-frequency = <70589280>;
- hactive = <1366>;
- vactive = <768>;
- hfront-porch = <40>;
- hback-porch = <40>;
- hsync-len = <32>;
- vback-porch = <10>;
- vfront-porch = <12>;
- vsync-len = <6>;
- };
- };
+ bridge = <&ptn3460>;
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] ARM: dts: Add DT changes for display on peach_pit
2014-08-27 14:48 [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow Ajay Kumar
@ 2014-08-27 14:48 ` Ajay Kumar
2014-08-27 15:01 ` [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow Mark Rutland
1 sibling, 0 replies; 9+ messages in thread
From: Ajay Kumar @ 2014-08-27 14:48 UTC (permalink / raw)
To: linux-arm-kernel
Add DT nodes for ps8622 bridge chip and panel.
Add backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on peach_pit.
Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel,
but still we choose to reuse the binding since "chunghwa,claa101wb01"
has similar LCD timings.
Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
Changes since V1:
-- Remove "simple-panel" compatible string.
-- Use GPIO_ACTIVE_HIGH instead of 0.
-- Change panel node naming from "panel-simple" to "panel".
arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++-------------
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..1070a31 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -30,11 +30,12 @@
i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm 0 1000000 0>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
+ power-supply = <&tps65090_fet1>;
pinctrl-0 = <&pwm0_out>;
pinctrl-names = "default";
};
@@ -100,6 +101,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel {
+ compatible = "chunghwa,claa101wb01";
+ power-supply = <&tps65090_fet6>;
+ backlight = <&backlight>;
+ };
};
&dp {
@@ -113,22 +120,7 @@
samsung,link-rate = <0x06>;
samsung,lane-count = <2>;
samsung,hpd-gpio = <&gpx2 6 0>;
-
- display-timings {
- native-mode = <&timing1>;
-
- timing1: timing at 1 {
- clock-frequency = <70589280>;
- hactive = <1366>;
- vactive = <768>;
- hfront-porch = <40>;
- hback-porch = <40>;
- hsync-len = <32>;
- vback-porch = <10>;
- vfront-porch = <12>;
- vsync-len = <6>;
- };
- };
+ bridge = <&ps8625>;
};
&fimd {
@@ -155,6 +147,16 @@
pinctrl-names = "default";
pinctrl-0 = <&max98090_irq>;
};
+
+ ps8625: lvds-bridge at 48 {
+ compatible = "parade,ps8625";
+ reg = <0x48>;
+ sleep-gpios = <&gpx3 5 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpy7 7 GPIO_ACTIVE_HIGH>;
+ lane-count = <2>;
+ panel = <&panel>;
+ use-external-pwm;
+ };
};
&hsi2c_9 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow
2014-08-27 14:48 [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow Ajay Kumar
2014-08-27 14:48 ` [PATCH 2/2] ARM: dts: Add DT changes for display on peach_pit Ajay Kumar
@ 2014-08-27 15:01 ` Mark Rutland
2014-08-28 5:34 ` Ajay kumar
1 sibling, 1 reply; 9+ messages in thread
From: Mark Rutland @ 2014-08-27 15:01 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote:
> Add DT nodes for ptn3460 bridge chip and panel.
> Add backlight enable pin and backlight power supply for pwm-backlight.
> Also add bridge phandle needed by dp to enable display on snow.
>
> Note that, snow doesn't support "chunghwa,claa101wb01" panel,
> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> has similar LCD timings.
What does it actually have?
It's fine to have "chunghwa,claa101wb01" as a fallback but we should
have an identifier for the actual display, too.
Thanks,
Mark.
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
> Changes since V1:
> -- Remove "simple-panel" compatible string.
> -- Use GPIO_ACTIVE_HIGH instead of 0.
> -- Change panel node naming from "panel-simple" to "panel".
>
> arch/arm/boot/dts/exynos5250-snow.dts | 41 ++++++++++++++++++---------------
> 1 file changed, 22 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index f2b8c41..1ac9709 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -9,6 +9,7 @@
> */
>
> /dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
> #include "exynos5250.dtsi"
> #include "exynos5250-cros-common.dtsi"
>
> @@ -181,7 +182,7 @@
> dcdc3 {
> ti,enable-ext-control;
> };
> - fet1 {
> + fet1: fet1 {
> regulator-name = "vcd_led";
> ti,overcurrent-wait = <3>;
> };
> @@ -204,7 +205,7 @@
> regulator-always-on;
> ti,overcurrent-wait = <3>;
> };
> - fet6 {
> + fet6: fet6 {
> regulator-name = "lcd_vdd";
> ti,overcurrent-wait = <3>;
> };
> @@ -253,6 +254,15 @@
> pinctrl-0 = <&max98095_en>;
> pinctrl-names = "default";
> };
> +
> + ptn3460: lvds-bridge at 20 {
> + compatible = "nxp,ptn3460";
> + reg = <0x20>;
> + powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
> + edid-emulation = <5>;
> + panel = <&panel>;
> + };
> };
>
> i2s0: i2s at 03830000 {
> @@ -300,11 +310,13 @@
> vdd_pll-supply = <&ldo8_reg>;
> };
>
> - backlight {
> + backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm 0 1000000 0>;
> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
> default-brightness-level = <7>;
> + enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
> + power-supply = <&fet1>;
> pinctrl-0 = <&pwm0_out>;
> pinctrl-names = "default";
> };
> @@ -314,6 +326,12 @@
> samsung,invert-vclk;
> };
>
> + panel: panel {
> + compatible = "chunghwa,claa101wb01";
> + power-supply = <&fet6>;
> + backlight = <&backlight>;
> + };
> +
> dp-controller at 145B0000 {
> status = "okay";
> pinctrl-names = "default";
> @@ -325,22 +343,7 @@
> samsung,link-rate = <0x0a>;
> samsung,lane-count = <2>;
> samsung,hpd-gpio = <&gpx0 7 0>;
> -
> - display-timings {
> - native-mode = <&timing1>;
> -
> - timing1: timing at 1 {
> - clock-frequency = <70589280>;
> - hactive = <1366>;
> - vactive = <768>;
> - hfront-porch = <40>;
> - hback-porch = <40>;
> - hsync-len = <32>;
> - vback-porch = <10>;
> - vfront-porch = <12>;
> - vsync-len = <6>;
> - };
> - };
> + bridge = <&ptn3460>;
> };
> };
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow
2014-08-27 15:01 ` [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow Mark Rutland
@ 2014-08-28 5:34 ` Ajay kumar
2014-08-28 9:15 ` Mark Rutland
0 siblings, 1 reply; 9+ messages in thread
From: Ajay kumar @ 2014-08-28 5:34 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 27, 2014 at 8:31 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote:
>> Add DT nodes for ptn3460 bridge chip and panel.
>> Add backlight enable pin and backlight power supply for pwm-backlight.
>> Also add bridge phandle needed by dp to enable display on snow.
>>
>> Note that, snow doesn't support "chunghwa,claa101wb01" panel,
>> but still we choose to reuse the binding since "chunghwa,claa101wb01"
>> has similar LCD timings.
>
> What does it actually have?
>
> It's fine to have "chunghwa,claa101wb01" as a fallback but we should
> have an identifier for the actual display, too.
Actual display used is "AUO,B116XTN0", for which no data currently exists
in panel file. Instead of adding a new panel_desc for B116XTN0,
why not we reuse existing ones? what is the "identifier" you are talking about?
Ajay
> Thanks,
> Mark.
>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> ---
>> Changes since V1:
>> -- Remove "simple-panel" compatible string.
>> -- Use GPIO_ACTIVE_HIGH instead of 0.
>> -- Change panel node naming from "panel-simple" to "panel".
>>
>> arch/arm/boot/dts/exynos5250-snow.dts | 41 ++++++++++++++++++---------------
>> 1 file changed, 22 insertions(+), 19 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index f2b8c41..1ac9709 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -9,6 +9,7 @@
>> */
>>
>> /dts-v1/;
>> +#include <dt-bindings/gpio/gpio.h>
>> #include "exynos5250.dtsi"
>> #include "exynos5250-cros-common.dtsi"
>>
>> @@ -181,7 +182,7 @@
>> dcdc3 {
>> ti,enable-ext-control;
>> };
>> - fet1 {
>> + fet1: fet1 {
>> regulator-name = "vcd_led";
>> ti,overcurrent-wait = <3>;
>> };
>> @@ -204,7 +205,7 @@
>> regulator-always-on;
>> ti,overcurrent-wait = <3>;
>> };
>> - fet6 {
>> + fet6: fet6 {
>> regulator-name = "lcd_vdd";
>> ti,overcurrent-wait = <3>;
>> };
>> @@ -253,6 +254,15 @@
>> pinctrl-0 = <&max98095_en>;
>> pinctrl-names = "default";
>> };
>> +
>> + ptn3460: lvds-bridge at 20 {
>> + compatible = "nxp,ptn3460";
>> + reg = <0x20>;
>> + powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
>> + reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
>> + edid-emulation = <5>;
>> + panel = <&panel>;
>> + };
>> };
>>
>> i2s0: i2s at 03830000 {
>> @@ -300,11 +310,13 @@
>> vdd_pll-supply = <&ldo8_reg>;
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> pwms = <&pwm 0 1000000 0>;
>> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
>> default-brightness-level = <7>;
>> + enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
>> + power-supply = <&fet1>;
>> pinctrl-0 = <&pwm0_out>;
>> pinctrl-names = "default";
>> };
>> @@ -314,6 +326,12 @@
>> samsung,invert-vclk;
>> };
>>
>> + panel: panel {
>> + compatible = "chunghwa,claa101wb01";
>> + power-supply = <&fet6>;
>> + backlight = <&backlight>;
>> + };
>> +
>> dp-controller at 145B0000 {
>> status = "okay";
>> pinctrl-names = "default";
>> @@ -325,22 +343,7 @@
>> samsung,link-rate = <0x0a>;
>> samsung,lane-count = <2>;
>> samsung,hpd-gpio = <&gpx0 7 0>;
>> -
>> - display-timings {
>> - native-mode = <&timing1>;
>> -
>> - timing1: timing at 1 {
>> - clock-frequency = <70589280>;
>> - hactive = <1366>;
>> - vactive = <768>;
>> - hfront-porch = <40>;
>> - hback-porch = <40>;
>> - hsync-len = <32>;
>> - vback-porch = <10>;
>> - vfront-porch = <12>;
>> - vsync-len = <6>;
>> - };
>> - };
>> + bridge = <&ptn3460>;
>> };
>> };
>>
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow
2014-08-28 5:34 ` Ajay kumar
@ 2014-08-28 9:15 ` Mark Rutland
2014-08-28 9:34 ` Ajay kumar
0 siblings, 1 reply; 9+ messages in thread
From: Mark Rutland @ 2014-08-28 9:15 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 28, 2014 at 06:34:33AM +0100, Ajay kumar wrote:
> On Wed, Aug 27, 2014 at 8:31 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote:
> >> Add DT nodes for ptn3460 bridge chip and panel.
> >> Add backlight enable pin and backlight power supply for pwm-backlight.
> >> Also add bridge phandle needed by dp to enable display on snow.
> >>
> >> Note that, snow doesn't support "chunghwa,claa101wb01" panel,
> >> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> >> has similar LCD timings.
> >
> > What does it actually have?
> >
> > It's fine to have "chunghwa,claa101wb01" as a fallback but we should
> > have an identifier for the actual display, too.
> Actual display used is "AUO,B116XTN0", for which no data currently exists
> in panel file. Instead of adding a new panel_desc for B116XTN0,
> why not we reuse existing ones? what is the "identifier" you are talking about?
The compatible string.
So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";
That way if we need specific data we can add it later.
What vendor is AU0? Can we add a vendor-prefix in parallel?
Thanks,
Mark.
>
> Ajay
> > Thanks,
> > Mark.
> >
> >> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> >> ---
> >> Changes since V1:
> >> -- Remove "simple-panel" compatible string.
> >> -- Use GPIO_ACTIVE_HIGH instead of 0.
> >> -- Change panel node naming from "panel-simple" to "panel".
> >>
> >> arch/arm/boot/dts/exynos5250-snow.dts | 41 ++++++++++++++++++---------------
> >> 1 file changed, 22 insertions(+), 19 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> >> index f2b8c41..1ac9709 100644
> >> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> >> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> >> @@ -9,6 +9,7 @@
> >> */
> >>
> >> /dts-v1/;
> >> +#include <dt-bindings/gpio/gpio.h>
> >> #include "exynos5250.dtsi"
> >> #include "exynos5250-cros-common.dtsi"
> >>
> >> @@ -181,7 +182,7 @@
> >> dcdc3 {
> >> ti,enable-ext-control;
> >> };
> >> - fet1 {
> >> + fet1: fet1 {
> >> regulator-name = "vcd_led";
> >> ti,overcurrent-wait = <3>;
> >> };
> >> @@ -204,7 +205,7 @@
> >> regulator-always-on;
> >> ti,overcurrent-wait = <3>;
> >> };
> >> - fet6 {
> >> + fet6: fet6 {
> >> regulator-name = "lcd_vdd";
> >> ti,overcurrent-wait = <3>;
> >> };
> >> @@ -253,6 +254,15 @@
> >> pinctrl-0 = <&max98095_en>;
> >> pinctrl-names = "default";
> >> };
> >> +
> >> + ptn3460: lvds-bridge at 20 {
> >> + compatible = "nxp,ptn3460";
> >> + reg = <0x20>;
> >> + powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
> >> + reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
> >> + edid-emulation = <5>;
> >> + panel = <&panel>;
> >> + };
> >> };
> >>
> >> i2s0: i2s at 03830000 {
> >> @@ -300,11 +310,13 @@
> >> vdd_pll-supply = <&ldo8_reg>;
> >> };
> >>
> >> - backlight {
> >> + backlight: backlight {
> >> compatible = "pwm-backlight";
> >> pwms = <&pwm 0 1000000 0>;
> >> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
> >> default-brightness-level = <7>;
> >> + enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
> >> + power-supply = <&fet1>;
> >> pinctrl-0 = <&pwm0_out>;
> >> pinctrl-names = "default";
> >> };
> >> @@ -314,6 +326,12 @@
> >> samsung,invert-vclk;
> >> };
> >>
> >> + panel: panel {
> >> + compatible = "chunghwa,claa101wb01";
> >> + power-supply = <&fet6>;
> >> + backlight = <&backlight>;
> >> + };
> >> +
> >> dp-controller at 145B0000 {
> >> status = "okay";
> >> pinctrl-names = "default";
> >> @@ -325,22 +343,7 @@
> >> samsung,link-rate = <0x0a>;
> >> samsung,lane-count = <2>;
> >> samsung,hpd-gpio = <&gpx0 7 0>;
> >> -
> >> - display-timings {
> >> - native-mode = <&timing1>;
> >> -
> >> - timing1: timing at 1 {
> >> - clock-frequency = <70589280>;
> >> - hactive = <1366>;
> >> - vactive = <768>;
> >> - hfront-porch = <40>;
> >> - hback-porch = <40>;
> >> - hsync-len = <32>;
> >> - vback-porch = <10>;
> >> - vfront-porch = <12>;
> >> - vsync-len = <6>;
> >> - };
> >> - };
> >> + bridge = <&ptn3460>;
> >> };
> >> };
> >>
> >> --
> >> 1.7.9.5
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> >> the body of a message to majordomo at vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow
2014-08-28 9:15 ` Mark Rutland
@ 2014-08-28 9:34 ` Ajay kumar
2014-08-28 9:52 ` Mark Rutland
2014-08-28 13:10 ` Thierry Reding
0 siblings, 2 replies; 9+ messages in thread
From: Ajay kumar @ 2014-08-28 9:34 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 28, 2014 at 2:45 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> On Thu, Aug 28, 2014 at 06:34:33AM +0100, Ajay kumar wrote:
>> On Wed, Aug 27, 2014 at 8:31 PM, Mark Rutland <mark.rutland@arm.com> wrote:
>> > On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote:
>> >> Add DT nodes for ptn3460 bridge chip and panel.
>> >> Add backlight enable pin and backlight power supply for pwm-backlight.
>> >> Also add bridge phandle needed by dp to enable display on snow.
>> >>
>> >> Note that, snow doesn't support "chunghwa,claa101wb01" panel,
>> >> but still we choose to reuse the binding since "chunghwa,claa101wb01"
>> >> has similar LCD timings.
>> >
>> > What does it actually have?
>> >
>> > It's fine to have "chunghwa,claa101wb01" as a fallback but we should
>> > have an identifier for the actual display, too.
>> Actual display used is "AUO,B116XTN0", for which no data currently exists
>> in panel file. Instead of adding a new panel_desc for B116XTN0,
>> why not we reuse existing ones? what is the "identifier" you are talking about?
>
> The compatible string.
>
> So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";
Sorry, hardware engineer says actual LCD name is "auo,b116xw03".
> That way if we need specific data we can add it later.
I think we can add a new panel_desc for "auo,b116xw03".
Because its actual LCD dimension is 256x144, but "chungwa, claa101wb01" has
LCD dimension 223x125.
What is Thierry's opinion on adding this new LCD?
> What vendor is AU0? Can we add a vendor-prefix in parallel?
its "auo" (already present: AU Optronics Corporation)
Ajay
> Thanks,
> Mark.
>
>>
>> Ajay
>> > Thanks,
>> > Mark.
>> >
>> >> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> >> ---
>> >> Changes since V1:
>> >> -- Remove "simple-panel" compatible string.
>> >> -- Use GPIO_ACTIVE_HIGH instead of 0.
>> >> -- Change panel node naming from "panel-simple" to "panel".
>> >>
>> >> arch/arm/boot/dts/exynos5250-snow.dts | 41 ++++++++++++++++++---------------
>> >> 1 file changed, 22 insertions(+), 19 deletions(-)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> >> index f2b8c41..1ac9709 100644
>> >> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> >> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> >> @@ -9,6 +9,7 @@
>> >> */
>> >>
>> >> /dts-v1/;
>> >> +#include <dt-bindings/gpio/gpio.h>
>> >> #include "exynos5250.dtsi"
>> >> #include "exynos5250-cros-common.dtsi"
>> >>
>> >> @@ -181,7 +182,7 @@
>> >> dcdc3 {
>> >> ti,enable-ext-control;
>> >> };
>> >> - fet1 {
>> >> + fet1: fet1 {
>> >> regulator-name = "vcd_led";
>> >> ti,overcurrent-wait = <3>;
>> >> };
>> >> @@ -204,7 +205,7 @@
>> >> regulator-always-on;
>> >> ti,overcurrent-wait = <3>;
>> >> };
>> >> - fet6 {
>> >> + fet6: fet6 {
>> >> regulator-name = "lcd_vdd";
>> >> ti,overcurrent-wait = <3>;
>> >> };
>> >> @@ -253,6 +254,15 @@
>> >> pinctrl-0 = <&max98095_en>;
>> >> pinctrl-names = "default";
>> >> };
>> >> +
>> >> + ptn3460: lvds-bridge at 20 {
>> >> + compatible = "nxp,ptn3460";
>> >> + reg = <0x20>;
>> >> + powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
>> >> + reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
>> >> + edid-emulation = <5>;
>> >> + panel = <&panel>;
>> >> + };
>> >> };
>> >>
>> >> i2s0: i2s at 03830000 {
>> >> @@ -300,11 +310,13 @@
>> >> vdd_pll-supply = <&ldo8_reg>;
>> >> };
>> >>
>> >> - backlight {
>> >> + backlight: backlight {
>> >> compatible = "pwm-backlight";
>> >> pwms = <&pwm 0 1000000 0>;
>> >> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
>> >> default-brightness-level = <7>;
>> >> + enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
>> >> + power-supply = <&fet1>;
>> >> pinctrl-0 = <&pwm0_out>;
>> >> pinctrl-names = "default";
>> >> };
>> >> @@ -314,6 +326,12 @@
>> >> samsung,invert-vclk;
>> >> };
>> >>
>> >> + panel: panel {
>> >> + compatible = "chunghwa,claa101wb01";
>> >> + power-supply = <&fet6>;
>> >> + backlight = <&backlight>;
>> >> + };
>> >> +
>> >> dp-controller at 145B0000 {
>> >> status = "okay";
>> >> pinctrl-names = "default";
>> >> @@ -325,22 +343,7 @@
>> >> samsung,link-rate = <0x0a>;
>> >> samsung,lane-count = <2>;
>> >> samsung,hpd-gpio = <&gpx0 7 0>;
>> >> -
>> >> - display-timings {
>> >> - native-mode = <&timing1>;
>> >> -
>> >> - timing1: timing at 1 {
>> >> - clock-frequency = <70589280>;
>> >> - hactive = <1366>;
>> >> - vactive = <768>;
>> >> - hfront-porch = <40>;
>> >> - hback-porch = <40>;
>> >> - hsync-len = <32>;
>> >> - vback-porch = <10>;
>> >> - vfront-porch = <12>;
>> >> - vsync-len = <6>;
>> >> - };
>> >> - };
>> >> + bridge = <&ptn3460>;
>> >> };
>> >> };
>> >>
>> >> --
>> >> 1.7.9.5
>> >>
>> >> --
>> >> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> >> the body of a message to majordomo at vger.kernel.org
>> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> >>
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow
2014-08-28 9:34 ` Ajay kumar
@ 2014-08-28 9:52 ` Mark Rutland
2014-08-28 13:10 ` Thierry Reding
1 sibling, 0 replies; 9+ messages in thread
From: Mark Rutland @ 2014-08-28 9:52 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 28, 2014 at 10:34:32AM +0100, Ajay kumar wrote:
> On Thu, Aug 28, 2014 at 2:45 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Thu, Aug 28, 2014 at 06:34:33AM +0100, Ajay kumar wrote:
> >> On Wed, Aug 27, 2014 at 8:31 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> >> > On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote:
> >> >> Add DT nodes for ptn3460 bridge chip and panel.
> >> >> Add backlight enable pin and backlight power supply for pwm-backlight.
> >> >> Also add bridge phandle needed by dp to enable display on snow.
> >> >>
> >> >> Note that, snow doesn't support "chunghwa,claa101wb01" panel,
> >> >> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> >> >> has similar LCD timings.
> >> >
> >> > What does it actually have?
> >> >
> >> > It's fine to have "chunghwa,claa101wb01" as a fallback but we should
> >> > have an identifier for the actual display, too.
> >> Actual display used is "AUO,B116XTN0", for which no data currently exists
> >> in panel file. Instead of adding a new panel_desc for B116XTN0,
> >> why not we reuse existing ones? what is the "identifier" you are talking about?
> >
> > The compatible string.
> >
> > So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";
> Sorry, hardware engineer says actual LCD name is "auo,b116xw03".
Ok.
> > That way if we need specific data we can add it later.
> I think we can add a new panel_desc for "auo,b116xw03".
> Because its actual LCD dimension is 256x144, but "chungwa, claa101wb01" has
> LCD dimension 223x125.
> What is Thierry's opinion on adding this new LCD?
>
> > What vendor is AU0? Can we add a vendor-prefix in parallel?
> its "auo" (already present: AU Optronics Corporation)
Ah, whoops. Mistook 'O' for '0'.
Thanks,
Mark.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow
2014-08-28 9:34 ` Ajay kumar
2014-08-28 9:52 ` Mark Rutland
@ 2014-08-28 13:10 ` Thierry Reding
2014-08-28 14:28 ` Mark Rutland
1 sibling, 1 reply; 9+ messages in thread
From: Thierry Reding @ 2014-08-28 13:10 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 28, 2014 at 03:04:32PM +0530, Ajay kumar wrote:
> On Thu, Aug 28, 2014 at 2:45 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Thu, Aug 28, 2014 at 06:34:33AM +0100, Ajay kumar wrote:
> >> On Wed, Aug 27, 2014 at 8:31 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> >> > On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote:
> >> >> Add DT nodes for ptn3460 bridge chip and panel.
> >> >> Add backlight enable pin and backlight power supply for pwm-backlight.
> >> >> Also add bridge phandle needed by dp to enable display on snow.
> >> >>
> >> >> Note that, snow doesn't support "chunghwa,claa101wb01" panel,
> >> >> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> >> >> has similar LCD timings.
> >> >
> >> > What does it actually have?
> >> >
> >> > It's fine to have "chunghwa,claa101wb01" as a fallback but we should
> >> > have an identifier for the actual display, too.
> >> Actual display used is "AUO,B116XTN0", for which no data currently exists
> >> in panel file. Instead of adding a new panel_desc for B116XTN0,
> >> why not we reuse existing ones? what is the "identifier" you are talking about?
> >
> > The compatible string.
> >
> > So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";
> Sorry, hardware engineer says actual LCD name is "auo,b116xw03".
>
> > That way if we need specific data we can add it later.
> I think we can add a new panel_desc for "auo,b116xw03".
> Because its actual LCD dimension is 256x144, but "chungwa, claa101wb01" has
> LCD dimension 223x125.
> What is Thierry's opinion on adding this new LCD?
I think you should simply add a new panel_desc for the panel. It may use
similar timings, but it's likely not "compatible" in the way required by
device tree. As you say, dimensions are different and those may have an
influence on the DPI setting. There's really no reason why this should
share the panel_desc with another panel.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140828/45546ce0/attachment-0001.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow
2014-08-28 13:10 ` Thierry Reding
@ 2014-08-28 14:28 ` Mark Rutland
0 siblings, 0 replies; 9+ messages in thread
From: Mark Rutland @ 2014-08-28 14:28 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 28, 2014 at 02:10:18PM +0100, Thierry Reding wrote:
> On Thu, Aug 28, 2014 at 03:04:32PM +0530, Ajay kumar wrote:
> > On Thu, Aug 28, 2014 at 2:45 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > > On Thu, Aug 28, 2014 at 06:34:33AM +0100, Ajay kumar wrote:
> > >> On Wed, Aug 27, 2014 at 8:31 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > >> > On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote:
> > >> >> Add DT nodes for ptn3460 bridge chip and panel.
> > >> >> Add backlight enable pin and backlight power supply for pwm-backlight.
> > >> >> Also add bridge phandle needed by dp to enable display on snow.
> > >> >>
> > >> >> Note that, snow doesn't support "chunghwa,claa101wb01" panel,
> > >> >> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> > >> >> has similar LCD timings.
> > >> >
> > >> > What does it actually have?
> > >> >
> > >> > It's fine to have "chunghwa,claa101wb01" as a fallback but we should
> > >> > have an identifier for the actual display, too.
> > >> Actual display used is "AUO,B116XTN0", for which no data currently exists
> > >> in panel file. Instead of adding a new panel_desc for B116XTN0,
> > >> why not we reuse existing ones? what is the "identifier" you are talking about?
> > >
> > > The compatible string.
> > >
> > > So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";
> > Sorry, hardware engineer says actual LCD name is "auo,b116xw03".
> >
> > > That way if we need specific data we can add it later.
> > I think we can add a new panel_desc for "auo,b116xw03".
> > Because its actual LCD dimension is 256x144, but "chungwa, claa101wb01" has
> > LCD dimension 223x125.
> > What is Thierry's opinion on adding this new LCD?
>
> I think you should simply add a new panel_desc for the panel. It may use
> similar timings, but it's likely not "compatible" in the way required by
> device tree. As you say, dimensions are different and those may have an
> influence on the DPI setting. There's really no reason why this should
> share the panel_desc with another panel.
>
> Thierry
This sounds sane to me.
Mark.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-08-28 14:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-27 14:48 [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow Ajay Kumar
2014-08-27 14:48 ` [PATCH 2/2] ARM: dts: Add DT changes for display on peach_pit Ajay Kumar
2014-08-27 15:01 ` [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow Mark Rutland
2014-08-28 5:34 ` Ajay kumar
2014-08-28 9:15 ` Mark Rutland
2014-08-28 9:34 ` Ajay kumar
2014-08-28 9:52 ` Mark Rutland
2014-08-28 13:10 ` Thierry Reding
2014-08-28 14:28 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).