* [PATCH v2 0/6] hix5hd2 add some nodes @ 2014-08-28 5:34 Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 1/6] ARM: dts: hix5hd2: add gmac node Zhangfei Gao ` (5 more replies) 0 siblings, 6 replies; 10+ messages in thread From: Zhangfei Gao @ 2014-08-28 5:34 UTC (permalink / raw) To: linux-arm-kernel v2: Add comments of mac-address, suggested by Mark Zhangfei Gao (6): ARM: dts: hix5hd2: add gmac node ARM: dts: hix5hd2: add mmc node ARM: dts: hix5hd2: add usb node ARM: dts: hix5hd2: add sata node ARM: dts: hix5hd2: add gpio node ARM: dts: hix5hd2: add wdg node arch/arm/boot/dts/hisi-x5hd2-dkb.dts | 33 ++++ arch/arm/boot/dts/hisi-x5hd2.dtsi | 310 ++++++++++++++++++++++++++++++++++ 2 files changed, 343 insertions(+) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/6] ARM: dts: hix5hd2: add gmac node 2014-08-28 5:34 [PATCH v2 0/6] hix5hd2 add some nodes Zhangfei Gao @ 2014-08-28 5:34 ` Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 2/6] ARM: dts: hix5hd2: add mmc node Zhangfei Gao ` (4 subsequent siblings) 5 siblings, 0 replies; 10+ messages in thread From: Zhangfei Gao @ 2014-08-28 5:34 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> --- arch/arm/boot/dts/hisi-x5hd2-dkb.dts | 28 ++++++++++++++++++++++++++++ arch/arm/boot/dts/hisi-x5hd2.dtsi | 16 ++++++++++++++++ 2 files changed, 44 insertions(+) diff --git a/arch/arm/boot/dts/hisi-x5hd2-dkb.dts b/arch/arm/boot/dts/hisi-x5hd2-dkb.dts index 05b44c2..0da3f3b 100644 --- a/arch/arm/boot/dts/hisi-x5hd2-dkb.dts +++ b/arch/arm/boot/dts/hisi-x5hd2-dkb.dts @@ -51,3 +51,31 @@ &uart0 { status = "okay"; }; + +&gmac0 { + #address-cells = <1>; + #size-cells = <0>; + phy-handle = <&phy2>; + phy-mode = "mii"; + /* Placeholder, overwritten by bootloader */ + mac-address = [00 00 00 00 00 00]; + status = "okay"; + + phy2: ethernet-phy at 2 { + reg = <2>; + }; +}; + +&gmac1 { + #address-cells = <1>; + #size-cells = <0>; + phy-handle = <&phy1>; + phy-mode = "rgmii"; + /* Placeholder, overwritten by bootloader */ + mac-address = [00 00 00 00 00 00]; + status = "okay"; + + phy1: ethernet-phy at 1 { + reg = <1>; + }; +}; diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi index f85ba29..012525c 100644 --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi @@ -166,5 +166,21 @@ #clock-cells = <1>; }; }; + + gmac0: ethernet at 1840000 { + compatible = "hisilicon,hix5hd2-gmac"; + reg = <0x1840000 0x1000>,<0x184300c 0x4>; + interrupts = <0 71 4>; + clocks = <&clock HIX5HD2_MAC0_CLK>; + status = "disabled"; + }; + + gmac1: ethernet at 1841000 { + compatible = "hisilicon,hix5hd2-gmac"; + reg = <0x1841000 0x1000>,<0x1843010 0x4>; + interrupts = <0 72 4>; + clocks = <&clock HIX5HD2_MAC1_CLK>; + status = "disabled"; + }; }; }; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/6] ARM: dts: hix5hd2: add mmc node 2014-08-28 5:34 [PATCH v2 0/6] hix5hd2 add some nodes Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 1/6] ARM: dts: hix5hd2: add gmac node Zhangfei Gao @ 2014-08-28 5:34 ` Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 3/6] ARM: dts: hix5hd2: add usb node Zhangfei Gao ` (3 subsequent siblings) 5 siblings, 0 replies; 10+ messages in thread From: Zhangfei Gao @ 2014-08-28 5:34 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> --- arch/arm/boot/dts/hisi-x5hd2.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi index 012525c..802331b 100644 --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi @@ -167,6 +167,23 @@ }; }; + /* unremovable emmc as mmcblk0 */ + mmc: mmc at 1830000 { + compatible = "snps,dw-mshc"; + reg = <0x1830000 0x1000>; + interrupts = <0 35 4>; + clocks = <&clock HIX5HD2_MMC_CIU_RST>, <&clock HIX5HD2_MMC_BIU_CLK>; + clock-names = "ciu", "biu"; + }; + + sd: mmc at 1820000 { + compatible = "snps,dw-mshc"; + reg = <0x1820000 0x1000>; + interrupts = <0 34 4>; + clocks = <&clock HIX5HD2_SD_CIU_RST>, <&clock HIX5HD2_SD_BIU_CLK>; + clock-names = "ciu","biu"; + }; + gmac0: ethernet at 1840000 { compatible = "hisilicon,hix5hd2-gmac"; reg = <0x1840000 0x1000>,<0x184300c 0x4>; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 3/6] ARM: dts: hix5hd2: add usb node 2014-08-28 5:34 [PATCH v2 0/6] hix5hd2 add some nodes Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 1/6] ARM: dts: hix5hd2: add gmac node Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 2/6] ARM: dts: hix5hd2: add mmc node Zhangfei Gao @ 2014-08-28 5:34 ` Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 4/6] ARM: dts: hix5hd2: add sata node Zhangfei Gao ` (2 subsequent siblings) 5 siblings, 0 replies; 10+ messages in thread From: Zhangfei Gao @ 2014-08-28 5:34 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> --- arch/arm/boot/dts/hisi-x5hd2.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi index 802331b..9252264 100644 --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi @@ -199,5 +199,19 @@ clocks = <&clock HIX5HD2_MAC1_CLK>; status = "disabled"; }; + + usb0: ehci at 1890000 { + compatible = "generic-ehci"; + reg = <0x1890000 0x1000>; + interrupts = <0 66 4>; + clocks = <&clock HIX5HD2_USB_CLK>; + }; + + usb1: ohci at 1880000 { + compatible = "generic-ohci"; + reg = <0x1880000 0x1000>; + interrupts = <0 67 4>; + clocks = <&clock HIX5HD2_USB_CLK>; + }; }; }; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 4/6] ARM: dts: hix5hd2: add sata node 2014-08-28 5:34 [PATCH v2 0/6] hix5hd2 add some nodes Zhangfei Gao ` (2 preceding siblings ...) 2014-08-28 5:34 ` [PATCH v2 3/6] ARM: dts: hix5hd2: add usb node Zhangfei Gao @ 2014-08-28 5:34 ` Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 5/6] ARM: dts: hix5hd2: add gpio node Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node Zhangfei Gao 5 siblings, 0 replies; 10+ messages in thread From: Zhangfei Gao @ 2014-08-28 5:34 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> --- arch/arm/boot/dts/hisi-x5hd2-dkb.dts | 5 +++++ arch/arm/boot/dts/hisi-x5hd2.dtsi | 20 ++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/arch/arm/boot/dts/hisi-x5hd2-dkb.dts b/arch/arm/boot/dts/hisi-x5hd2-dkb.dts index 0da3f3b..375a10c 100644 --- a/arch/arm/boot/dts/hisi-x5hd2-dkb.dts +++ b/arch/arm/boot/dts/hisi-x5hd2-dkb.dts @@ -79,3 +79,8 @@ reg = <1>; }; }; + +&ahci { + phys = <&sata_phy>; + phy-names = "sata-phy"; +}; diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi index 9252264..18f52f0 100644 --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi @@ -213,5 +213,25 @@ interrupts = <0 67 4>; clocks = <&clock HIX5HD2_USB_CLK>; }; + + peripheral_ctrl: syscon at a20000 { + compatible = "syscon"; + reg = <0xa20000 0x1000>; + }; + + sata_phy: phy at 1900000 { + compatible = "hisilicon,hix5hd2-sata-phy"; + reg = <0x1900000 0x10000>; + #phy-cells = <0>; + hisilicon,peripheral-syscon = <&peripheral_ctrl>; + hisilicon,power-reg = <0x8 10>; + }; + + ahci: sata at 1900000 { + compatible = "hisilicon,hisi-ahci"; + reg = <0x1900000 0x10000>; + interrupts = <0 70 4>; + clocks = <&clock HIX5HD2_SATA_CLK>; + }; }; }; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 5/6] ARM: dts: hix5hd2: add gpio node 2014-08-28 5:34 [PATCH v2 0/6] hix5hd2 add some nodes Zhangfei Gao ` (3 preceding siblings ...) 2014-08-28 5:34 ` [PATCH v2 4/6] ARM: dts: hix5hd2: add sata node Zhangfei Gao @ 2014-08-28 5:34 ` Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node Zhangfei Gao 5 siblings, 0 replies; 10+ messages in thread From: Zhangfei Gao @ 2014-08-28 5:34 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> --- arch/arm/boot/dts/hisi-x5hd2.dtsi | 234 +++++++++++++++++++++++++++++++++++++ 1 file changed, 234 insertions(+) diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi index 18f52f0..152f3ad 100644 --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi @@ -131,6 +131,240 @@ clock-names = "apb_pclk"; status = "disabled"; }; + + gpio0: gpio at b20000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb20000 0x1000>; + interrupts = <0 108 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio1: gpio at b21000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb21000 0x1000>; + interrupts = <0 109 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio2: gpio at b22000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb22000 0x1000>; + interrupts = <0 110 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio3: gpio at b23000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb23000 0x1000>; + interrupts = <0 111 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio4: gpio at b24000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb24000 0x1000>; + interrupts = <0 112 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio5: gpio at 004000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0x004000 0x1000>; + interrupts = <0 113 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio6: gpio at b26000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb26000 0x1000>; + interrupts = <0 114 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio7: gpio at b27000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb27000 0x1000>; + interrupts = <0 115 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio8: gpio at b28000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb28000 0x1000>; + interrupts = <0 116 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio9: gpio at b29000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb29000 0x1000>; + interrupts = <0 117 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio10: gpio at b2a000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb2a000 0x1000>; + interrupts = <0 118 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio11: gpio at b2b000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb2b000 0x1000>; + interrupts = <0 119 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio12: gpio at b2c000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb2c000 0x1000>; + interrupts = <0 120 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio13: gpio at b2d000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb2d000 0x1000>; + interrupts = <0 121 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio14: gpio at b2e000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb2e000 0x1000>; + interrupts = <0 122 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio15: gpio at b2f000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb2f000 0x1000>; + interrupts = <0 123 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio16: gpio at b30000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb30000 0x1000>; + interrupts = <0 124 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; + + gpio17: gpio at b31000 { + compatible = "arm,pl061", "arm,primecell"; + reg = <0xb31000 0x1000>; + interrupts = <0 125 0x4>; + gpio-controller; + #gpio-cells = <2>; + clocks = <&clock HIX5HD2_FIXED_100M>; + clock-names = "apb_pclk"; + interrupt-controller; + #interrupt-cells = <2>; + status = "disabled"; + }; }; local_timer at 00a00600 { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node 2014-08-28 5:34 [PATCH v2 0/6] hix5hd2 add some nodes Zhangfei Gao ` (4 preceding siblings ...) 2014-08-28 5:34 ` [PATCH v2 5/6] ARM: dts: hix5hd2: add gpio node Zhangfei Gao @ 2014-08-28 5:34 ` Zhangfei Gao 2014-08-28 9:21 ` Dinh Nguyen 5 siblings, 1 reply; 10+ messages in thread From: Zhangfei Gao @ 2014-08-28 5:34 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> --- arch/arm/boot/dts/hisi-x5hd2.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi index 152f3ad..7b1cb53 100644 --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi @@ -365,6 +365,15 @@ #interrupt-cells = <2>; status = "disabled"; }; + + wdg0: wdg at a2c000 { + compatible = "arm,sp805", "arm,primecell"; + arm,primecell-periphid = <0x00141805>; + reg = <0xa2c000 0x1000>; + interrupts = <0 29 4>; + clocks = <&clock HIX5HD2_WDG0_RST>; + clock-names = "apb_pclk"; + }; }; local_timer at 00a00600 { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node 2014-08-28 5:34 ` [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node Zhangfei Gao @ 2014-08-28 9:21 ` Dinh Nguyen 2014-08-28 17:12 ` Mark Rutland 0 siblings, 1 reply; 10+ messages in thread From: Dinh Nguyen @ 2014-08-28 9:21 UTC (permalink / raw) To: linux-arm-kernel On 8/28/14, 12:34 AM, Zhangfei Gao wrote: > Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> > Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> > --- > arch/arm/boot/dts/hisi-x5hd2.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi > index 152f3ad..7b1cb53 100644 > --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi > +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi > @@ -365,6 +365,15 @@ > #interrupt-cells = <2>; > status = "disabled"; > }; > + > + wdg0: wdg at a2c000 { A nit-pick here, but everybody else is using 'wdt' for a watchdog timer node. > + compatible = "arm,sp805", "arm,primecell"; I didn't see an entry for "arm,sp805" in Documentations, should there be one? Dinh > + arm,primecell-periphid = <0x00141805>; > + reg = <0xa2c000 0x1000>; > + interrupts = <0 29 4>; > + clocks = <&clock HIX5HD2_WDG0_RST>; > + clock-names = "apb_pclk"; > + }; > }; > > local_timer at 00a00600 { > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node 2014-08-28 9:21 ` Dinh Nguyen @ 2014-08-28 17:12 ` Mark Rutland 2014-08-29 8:12 ` zhangfei 0 siblings, 1 reply; 10+ messages in thread From: Mark Rutland @ 2014-08-28 17:12 UTC (permalink / raw) To: linux-arm-kernel On Thu, Aug 28, 2014 at 10:21:43AM +0100, Dinh Nguyen wrote: > > > On 8/28/14, 12:34 AM, Zhangfei Gao wrote: > > Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> > > Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> > > --- > > arch/arm/boot/dts/hisi-x5hd2.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi > > index 152f3ad..7b1cb53 100644 > > --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi > > +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi > > @@ -365,6 +365,15 @@ > > #interrupt-cells = <2>; > > status = "disabled"; > > }; > > + > > + wdg0: wdg at a2c000 { > > A nit-pick here, but everybody else is using 'wdt' for a watchdog timer > node. > > > + compatible = "arm,sp805", "arm,primecell"; > > I didn't see an entry for "arm,sp805" in Documentations, should there be > one? There probably should, yes. It looks like only the sp804 is documented. Pawel, it looks like you were the first sp805,sp810 dt user. Care to put together a couple of documents? ;) Mark. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node 2014-08-28 17:12 ` Mark Rutland @ 2014-08-29 8:12 ` zhangfei 0 siblings, 0 replies; 10+ messages in thread From: zhangfei @ 2014-08-29 8:12 UTC (permalink / raw) To: linux-arm-kernel On 08/29/2014 01:12 AM, Mark Rutland wrote: > On Thu, Aug 28, 2014 at 10:21:43AM +0100, Dinh Nguyen wrote: >> >> >> On 8/28/14, 12:34 AM, Zhangfei Gao wrote: >>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> >>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> >>> --- >>> arch/arm/boot/dts/hisi-x5hd2.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi >>> index 152f3ad..7b1cb53 100644 >>> --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi >>> +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi >>> @@ -365,6 +365,15 @@ >>> #interrupt-cells = <2>; >>> status = "disabled"; >>> }; >>> + >>> + wdg0: wdg at a2c000 { >> >> A nit-pick here, but everybody else is using 'wdt' for a watchdog timer >> node. Sure?will change to wdt0: watchdog at a2c000 >> >>> + compatible = "arm,sp805", "arm,primecell"; >> >> I didn't see an entry for "arm,sp805" in Documentations, should there be >> one? > > There probably should, yes. It looks like only the sp804 is documented. > > Pawel, it looks like you were the first sp805,sp810 dt user. Care to put > together a couple of documents? ;) > Yes, that would be great, Not find bindings for drivers/watchdog/sp805_wdt.c. Thanks ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-08-29 8:12 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-08-28 5:34 [PATCH v2 0/6] hix5hd2 add some nodes Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 1/6] ARM: dts: hix5hd2: add gmac node Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 2/6] ARM: dts: hix5hd2: add mmc node Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 3/6] ARM: dts: hix5hd2: add usb node Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 4/6] ARM: dts: hix5hd2: add sata node Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 5/6] ARM: dts: hix5hd2: add gpio node Zhangfei Gao 2014-08-28 5:34 ` [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node Zhangfei Gao 2014-08-28 9:21 ` Dinh Nguyen 2014-08-28 17:12 ` Mark Rutland 2014-08-29 8:12 ` zhangfei
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).