From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 4/5] rtc: max77686: Remove unneded info log
Date: Thu, 28 Aug 2014 10:36:39 +0200 [thread overview]
Message-ID: <1409214999.20020.0.camel@AMDC1943> (raw)
In-Reply-To: <1408350877-15921-5-git-send-email-javier.martinez@collabora.co.uk>
On pon, 2014-08-18 at 10:34 +0200, Javier Martinez Canillas wrote:
> If devm_rtc_device_register() fails a dev_err() is already
> reported so there is no need to do an additional dev_info().
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
> ---
> drivers/rtc/rtc-max77686.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> index 55396bb..b177ba1 100644
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -457,8 +457,6 @@ static int max77686_rtc_probe(struct platform_device *pdev)
> &max77686_rtc_ops, THIS_MODULE);
>
> if (IS_ERR(info->rtc_dev)) {
> - dev_info(&pdev->dev, "%s: fail\n", __func__);
> -
> ret = PTR_ERR(info->rtc_dev);
> dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
> if (ret == 0)
next prev parent reply other threads:[~2014-08-28 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 8:34 [PATCH v9 0/5] Add Maxim 77802 RTC support Javier Martinez Canillas
2014-08-18 8:34 ` [PATCH v9 1/5] rtc: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas
2014-08-18 8:34 ` [PATCH v9 2/5] rtc: max77686: Remove dead code for SMPL and WTSR Javier Martinez Canillas
2014-08-18 8:34 ` [PATCH v9 3/5] rtc: max77686: Fail to probe if no RTC regmap irqchip is set Javier Martinez Canillas
2014-08-28 9:21 ` Krzysztof Kozlowski
2014-09-08 6:50 ` Javier Martinez Canillas
2014-08-18 8:34 ` [PATCH v9 4/5] rtc: max77686: Remove unneded info log Javier Martinez Canillas
2014-08-28 8:36 ` Krzysztof Kozlowski [this message]
2014-08-18 8:34 ` [PATCH v9 5/5] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas
2014-09-08 6:48 ` [PATCH v9 0/5] Add Maxim 77802 RTC support Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409214999.20020.0.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).