* [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice
@ 2014-06-26 11:46 Krzysztof Kozlowski
2014-06-26 11:51 ` Sachin Kamat
2014-07-04 8:41 ` Kukjin Kim
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2014-06-26 11:46 UTC (permalink / raw)
To: linux-arm-kernel
Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT
bindings") introduced local variable boot_reg where boot address from
cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg()
again.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/mach-exynos/platsmp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
index 1c8d31e39520..55ed2e6729c5 100644
--- a/arch/arm/mach-exynos/platsmp.c
+++ b/arch/arm/mach-exynos/platsmp.c
@@ -155,7 +155,7 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle)
ret = PTR_ERR(boot_reg);
goto fail;
}
- __raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
+ __raw_writel(boot_addr, boot_reg);
}
call_firmware_op(cpu_boot, phys_cpu);
@@ -242,7 +242,7 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus)
if (IS_ERR(boot_reg))
break;
- __raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
+ __raw_writel(boot_addr, boot_reg);
}
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice
2014-06-26 11:46 [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice Krzysztof Kozlowski
@ 2014-06-26 11:51 ` Sachin Kamat
2014-07-04 8:41 ` Kukjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2014-06-26 11:51 UTC (permalink / raw)
To: linux-arm-kernel
Hi Krzysztof,
On Thu, Jun 26, 2014 at 5:16 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT
> bindings") introduced local variable boot_reg where boot address from
> cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg()
> again.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Thanks for the patch.
Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>
Regards,
Sachin.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice
2014-06-26 11:46 [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice Krzysztof Kozlowski
2014-06-26 11:51 ` Sachin Kamat
@ 2014-07-04 8:41 ` Kukjin Kim
2014-09-01 8:39 ` Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: Kukjin Kim @ 2014-07-04 8:41 UTC (permalink / raw)
To: linux-arm-kernel
Krzysztof Kozlowski wrote:
>
> Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT
> bindings") introduced local variable boot_reg where boot address from
> cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg()
> again.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/mach-exynos/platsmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
> index 1c8d31e39520..55ed2e6729c5 100644
> --- a/arch/arm/mach-exynos/platsmp.c
> +++ b/arch/arm/mach-exynos/platsmp.c
> @@ -155,7 +155,7 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle)
> ret = PTR_ERR(boot_reg);
> goto fail;
> }
> - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
> + __raw_writel(boot_addr, boot_reg);
> }
>
> call_firmware_op(cpu_boot, phys_cpu);
> @@ -242,7 +242,7 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus)
>
> if (IS_ERR(boot_reg))
> break;
> - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
> + __raw_writel(boot_addr, boot_reg);
> }
> }
> }
> --
> 1.9.1
Oh, good catch. will apply :-)
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice
2014-07-04 8:41 ` Kukjin Kim
@ 2014-09-01 8:39 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2014-09-01 8:39 UTC (permalink / raw)
To: linux-arm-kernel
On pi?, 2014-07-04 at 17:41 +0900, Kukjin Kim wrote:
> Krzysztof Kozlowski wrote:
> >
> > Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT
> > bindings") introduced local variable boot_reg where boot address from
> > cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg()
> > again.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > arch/arm/mach-exynos/platsmp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
> > index 1c8d31e39520..55ed2e6729c5 100644
> > --- a/arch/arm/mach-exynos/platsmp.c
> > +++ b/arch/arm/mach-exynos/platsmp.c
> > @@ -155,7 +155,7 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle)
> > ret = PTR_ERR(boot_reg);
> > goto fail;
> > }
> > - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
> > + __raw_writel(boot_addr, boot_reg);
> > }
> >
> > call_firmware_op(cpu_boot, phys_cpu);
> > @@ -242,7 +242,7 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus)
> >
> > if (IS_ERR(boot_reg))
> > break;
> > - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
> > + __raw_writel(boot_addr, boot_reg);
> > }
> > }
> > }
> > --
> > 1.9.1
>
> Oh, good catch. will apply :-)
Hi Kukjin,
I cannot find this patch in your tree or in next. Did you applied this?
Best regards,
Krzysztof
> Thanks,
> Kukjin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-01 8:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-26 11:46 [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice Krzysztof Kozlowski
2014-06-26 11:51 ` Sachin Kamat
2014-07-04 8:41 ` Kukjin Kim
2014-09-01 8:39 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).