linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: ux500: disable msp2 node on Snowball
@ 2014-09-02 12:41 Linus Walleij
  2014-09-02 13:19 ` Lee Jones
  2014-09-02 18:18 ` Kevin Hilman
  0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2014-09-02 12:41 UTC (permalink / raw)
  To: linux-arm-kernel

Analogous to commit 8858d88a25142544843869f0cd3e6654aa7b4aec
that fixed commit 70b41abc151f9
"ARM: ux500: move MSP pin control to the device tree"
accidentally activated MSP2, giving rise to a boot scroll
scream as the kernel attempts to probe a driver for it and
fails to obtain DMA channel 14.

For some reason I forgot to fix this on the Snowball. Fix
this up by marking the node disabled again.

Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ARM SoC folks: please apply this patch directly to fixes for
v3.17, I have no other pending Ux500 fixes.
---
 arch/arm/boot/dts/ste-snowball.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/ste-snowball.dts b/arch/arm/boot/dts/ste-snowball.dts
index 4a2000c620ad..3e97a669f15e 100644
--- a/arch/arm/boot/dts/ste-snowball.dts
+++ b/arch/arm/boot/dts/ste-snowball.dts
@@ -116,7 +116,6 @@
 		msp2: msp at 80117000 {
 			pinctrl-names = "default";
 			pinctrl-0 = <&msp2_default_mode>;
-			status = "okay";
 		};
 
 		msp3: msp at 80125000 {
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: ux500: disable msp2 node on Snowball
  2014-09-02 12:41 [PATCH] ARM: ux500: disable msp2 node on Snowball Linus Walleij
@ 2014-09-02 13:19 ` Lee Jones
  2014-09-02 18:18 ` Kevin Hilman
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2014-09-02 13:19 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, 02 Sep 2014, Linus Walleij wrote:

> Analogous to commit 8858d88a25142544843869f0cd3e6654aa7b4aec
> that fixed commit 70b41abc151f9
> "ARM: ux500: move MSP pin control to the device tree"
> accidentally activated MSP2, giving rise to a boot scroll
> scream as the kernel attempts to probe a driver for it and
> fails to obtain DMA channel 14.
> 
> For some reason I forgot to fix this on the Snowball. Fix
> this up by marking the node disabled again.
> 
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC folks: please apply this patch directly to fixes for
> v3.17, I have no other pending Ux500 fixes.
> ---
>  arch/arm/boot/dts/ste-snowball.dts | 1 -
>  1 file changed, 1 deletion(-)

Ah I see.  You fixed the HREF back in Feb, but I guess Snowball didn't
benefit from it.

Acked-by: Lee Jones <lee.jones@linaro.org>
 
> diff --git a/arch/arm/boot/dts/ste-snowball.dts b/arch/arm/boot/dts/ste-snowball.dts
> index 4a2000c620ad..3e97a669f15e 100644
> --- a/arch/arm/boot/dts/ste-snowball.dts
> +++ b/arch/arm/boot/dts/ste-snowball.dts
> @@ -116,7 +116,6 @@
>  		msp2: msp at 80117000 {
>  			pinctrl-names = "default";
>  			pinctrl-0 = <&msp2_default_mode>;
> -			status = "okay";
>  		};
>  
>  		msp3: msp at 80125000 {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: ux500: disable msp2 node on Snowball
  2014-09-02 12:41 [PATCH] ARM: ux500: disable msp2 node on Snowball Linus Walleij
  2014-09-02 13:19 ` Lee Jones
@ 2014-09-02 18:18 ` Kevin Hilman
  1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2014-09-02 18:18 UTC (permalink / raw)
  To: linux-arm-kernel

Linus Walleij <linus.walleij@linaro.org> writes:

> Analogous to commit 8858d88a25142544843869f0cd3e6654aa7b4aec
> that fixed commit 70b41abc151f9
> "ARM: ux500: move MSP pin control to the device tree"
> accidentally activated MSP2, giving rise to a boot scroll
> scream as the kernel attempts to probe a driver for it and
> fails to obtain DMA channel 14.
>
> For some reason I forgot to fix this on the Snowball. Fix
> this up by marking the node disabled again.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC folks: please apply this patch directly to fixes for
> v3.17, I have no other pending Ux500 fixes.

Tested on snowball, and applied to fixes.

Thanks,

Kevin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-02 18:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02 12:41 [PATCH] ARM: ux500: disable msp2 node on Snowball Linus Walleij
2014-09-02 13:19 ` Lee Jones
2014-09-02 18:18 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).