From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90173C43381 for ; Wed, 6 Mar 2019 03:14:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6018F2075B for ; Wed, 6 Mar 2019 03:14:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LBqWKpOb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DTDpQbfg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6018F2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/276iTOczu1HaW8UsJWR4qkgW0pQ65p1aPeUhYZUxXw=; b=LBqWKpObIwFyVh SuTwVKwzzeRN0dtKwAPHUetO9Uwm3nj3Buuk0JzltKolm8QY53OQh4G+DNdb/gqeJg88N+AdBvrqC 01tWVgyRDpnrlMaoOjhvgYJXpJUHlwLBUPQU7hb++/qclbKARd7rIElUqcUJ1Dek5KGeE+btVdzgV LrrXdkvLo3iRvcNkz+Uk4KVwrbg8wYKvmQWYEgGauv4BlcIBpICWU6UgjKrg7PDtIzALzCT6u5EYx hNL9MnqtaPQ26WpfFmp1DXnpJoQ3UHPcZzEPMysdJE7jzvP/7hOfmvq+p3alGyaXWbuSvTnm+KeMc nALkbWqs+EkKRL9uWbng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1N0h-0001ej-5B; Wed, 06 Mar 2019 03:14:23 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1N0e-0001eM-8a for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 03:14:21 +0000 Received: by mail-pf1-x441.google.com with SMTP id n22so7329652pfa.3 for ; Tue, 05 Mar 2019 19:14:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zZx3LPVRYeDN5lTmlindAbMPgNL5491ibVRuhSiXMNY=; b=DTDpQbfgbpDWxQ060i05QhSyxl8wezoI40+M3EHG13SJDv2wajZ8tAgrOO97Vmn7gY v7RFwNrJ8cjvHOiuErbmIOxUWvQaWJ2lF0bo5K23/GzXlV1DohUVGxtZkVVtHLPhHrCk 8+6OqB9z+IW7Qq5G2UseQsQb5yF0A6/K3/cIO6qiYpEPvpkYEmoeaEVwEyqsKnJrRCfh G6yvfnXLY92IyQETKpnqrv3hOK7z05jC2qNoj8SjCnq3lU0fXt6gKWS/VgpE+GnzXedH un059h+NgWI2aRmIk5B+x0EwZzPrUVfrT64dSnn13ZE/UBge0/hviJWtefd4SzcluZXm DKEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=zZx3LPVRYeDN5lTmlindAbMPgNL5491ibVRuhSiXMNY=; b=ZlToXNY7R23amMgweObBqMgc4dqQJEc1oMj86f8Q+Uc6bqVEJPjsUbJx3iylRwmA9z 8sfAio82MmsU41F3dSIOLKJiOKufRt0W4L2X3ihMryWzl8JOZSfMEhE5uuocQtH9aEHy OkgUtrCdQEY+G9TOe3x965SWCtKfZ24+gZVQisFWH3WSIYuOcrT7/Ri1ijaxSZNmicAD taGQWc1VOCtCyOWpkm1+h3nWiiI/7ONWgW1G3AMfsMRfAdxUwGDb22H95MpXllG3OqKC c3GNRi8QS1XVBJu8NVstbzxTG8yFZ8t+K35mGzYnXtUccjHWJZPL/vSYOh3wYX7hv6Vn 0Sbg== X-Gm-Message-State: APjAAAV6KLfqyBGCczIk0HS5n0jIkdhShuKdl3l+mtWY16lOVFIlmgCd EKek26oMHpG6JYLm1TGNPGFVr8QD X-Google-Smtp-Source: APXvYqzH2HnJgkWhUqiMJdWs0caxZN+R5RsLXt/KTz9ykezNqAe07kslsBmow0RaQKAbmiFNI+EVBg== X-Received: by 2002:a62:1382:: with SMTP id 2mr4991645pft.157.1551842058129; Tue, 05 Mar 2019 19:14:18 -0800 (PST) Received: from [10.230.28.107] ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id v186sm610299pfv.184.2019.03.05.19.14.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 19:14:16 -0800 (PST) Subject: Re: [PATCH 1/4] ARM: brcmstb: fix a leaked reference by adding missing of_node_put To: Wen Yang , linux-kernel@vger.kernel.org References: <1551785577-45896-1-git-send-email-wen.yang99@zte.com.cn> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0KEZsb3JpYW4gRmFpbmVsbGkgPGZhaW5lbGxpQGJyb2FkY29tLmNvbT6JAccEEAECALEF AlPAG9YXCgABv0jL/n0t8VEFmtDa8j7qERo7AN0gFAAAAAAAFgABa2V5LXVzYWdlLW1hc2tA cGdwLmNvbY4wFIAAAAAAIAAHcHJlZmVycmVkLWVtYWlsLWVuY29kaW5nQHBncC5jb21wZ3Bt aW1lCAsJCAcDAgEKAhkBBReAAAAAGRhsZGFwOi8va2V5cy5icm9hZGNvbS5jb20FGwMAAAAD FgIBBR4BAAAABBUICQoACgkQgTG1xCm8ZqD+Dgf9HhhzqvJYIPomNeg+ll7/TbzWb871E+HQ TaufJQFQwLEbgdFSZO2uj4UqfDpCyTwtHTVMJogWt3pCAE1sadeIY8OlT6918ofKIl8AiHj2 BlfL7ASZ5wzkRMt/4TZoinq9O1tPEynb5G6PdZTV3UQtmSGnpt2EOu7KtRJsnThBiXoOO9TJ Asg4vXJ0ZM1y/MPhQlZbPCHQZFe1gaVWBPLGnLyWyeprqgSLWHaGqrUhlfK1sLuJK1bjYDCI NetK0pS4cA4ZJgogr5FrtV64R19zLl02mt/Yj7rAmjC3ZBuwVi3V35kD8Kd4d9QM2apsiILV bzGbtVCSUgvxI+1SsJEm3bkBDQRTwBvBAQgArGvvWip77T4xgJztZp9YRylAcVTC9gtx0Gg6 eYk/EPANGm9TkuGpI++T/Il2H2TjFQNC7eubWohbYj0+6Tmf8nP+VmyobDxPXcMrK7x4xy9o D+Kub2Vf0SXbsM8fL/SqzGbFWZSm73L1L4GZoxvYIz0i7LExYSX2u5YVLaMBaH9HwKt2cvr7 MuTrRHtcbOZImoXT29g2UnoF1uwxYNeRhZY/lRvVkkY0lDipPuDwg3SpfHMtCybPq1uAswQd gEbHzRsEXwCR1OF3pIuGt4I3tSEhH/k1caqi0BlqjbGUOkku44xC2gf1ZU267FBBkdV3yJ/7 KnrJEnkMCYhS3kII9wARAQABiQJBBBgBAgErBQJTwBvCBRsMAAAAwF0gBBkBCAAGBQJTwBvB AAoJEJNgBqiYLw9VDRUIAJaTef6hsUAESnlGDpC+ymL2RZdzAJx9lXjU4hhaFcyhznuyyMJq d3mehmLxsqDRvHDiqyD71w2Bnc838MVZw0pwBPdnb/h9Ocmp0lL/9hwSGWvy4az5lYVyoA9u 14UIzh0YNGu6jr0isd/LJAbHXqwJwWWs3y8PTrpEp68V6lv+aXt5gR03lJEAvIR1Awp4JJ/e Z5y12gQISp0X8xal9YhhDWER92YLYrO2b6Hc2S31lAupzfCw8lmZsP1PRz1GmF/KmDD9J9N/ b8IehhWQqrBQjMjn2K2XkvN75HnAMHKFYfHZR3ZHtK52ZP1crV7THtbtrnPXVDq+vO4QPmdC +SEACgkQgTG1xCm8ZqC6BwgAl3kRh7oozpjpG8jpO8en5CBtTl3G+OpKJK9qbQyzdCsuJ0K1 qe1wZPZbP/Y+VtmqSgnExBzjStt9drjFBK8liPQZalp2sMlS9S7csSy6cMLF1auZubAZEqpm tpXagbtgR12YOo57Reb83F5KhtwwiWdoTpXRTx/nM0cHtjjrImONhP8OzVMmjem/B68NY++/ qt0F5XTsP2zjd+tRLrFh3W4XEcLt1lhYmNmbJR/l6+vVbWAKDAtcbQ8SL2feqbPWV6VDyVKh ya/EEq0xtf84qEB+4/+IjCdOzDD3kDZJo+JBkDnU3LBXw4WCw3QhOXY+VnhOn2EcREN7qdAK w0j9Sw== Message-ID: <140acf36-21df-bdc3-5ad2-b934e521554b@gmail.com> Date: Tue, 5 Mar 2019 19:14:18 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <1551785577-45896-1-git-send-email-wen.yang99@zte.com.cn> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_191420_330216_A121F010 X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, Florian Fainelli , Scott Branden , Ray Jui , Russell King , bcm-kernel-feedback-list@broadcom.com, Gregory Fong , Brian Norris , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/5/2019 3:32 AM, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-bcm/platsmp-brcmstb.c:337:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 329, but without a corresponding object release within this function. > ./arch/arm/mach-bcm/platsmp-brcmstb.c:341:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 329, but without a corresponding object release within this functio > ./arch/arm/mach-bcm/bcm63xx_smp.c:150:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 130, but without a corresponding object release within this function. I would actually lump that in your [PATCH v2 02/15] ARM: bcm: fix a leaked reference by adding missing of_node_put patch since the subject of that one is correct. Thanks! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel